-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
Description
These cause plenty of false positive warnings on GPU, and are a bit annoying. Instead, we should completely rely on stuff in Kokkos_MathematicalFunctions.hpp. Namely, I think we should
- Use
Kokkos::xyzinstead ofstd::xyzinside the pack loop of the fcn overload - Inject our pack utilities into the Kokkos namespace, so that downstream templated code can do
Kokkos::sqrt(my_value)without having to worry whethermy_valueis a builtin type or a pack. - Remove
ekat::impl::maxandekat::impl::min, in favor of the ones provided by Kokkos.
Reactions are currently unavailable