Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider lowering the ClockSkew in TokenValidator #1553

Open
AndersAbel opened this issue May 14, 2024 · 0 comments
Open

Consider lowering the ClockSkew in TokenValidator #1553

AndersAbel opened this issue May 14, 2024 · 0 comments

Comments

@AndersAbel
Copy link
Member

The TokenValidator uses the default ClockSkew of 5 minutes when validating JWTs. Having a generous clock skew is meant to be forgiving to clients that have their system clock out of sync. But in IdentityServer we only validates tokens that were issued by IdentityServer itself. It's the same clock that issued the token that validates it. We could do with a (near)-zero ClockSkew.

The only time a ClockSkew would be relevant to have is if there's a cluster and the times in the cluster are not in sync. But if the clocks in your cluster is more than a few seconds off there's a problem to your intrastructure.

I suggest setting the ClockSkew to 5 seconds in the TokenValidator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant