Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop when max_age=0 #1545

Closed
RolandGuijt opened this issue Apr 29, 2024 · 0 comments · Fixed by #1565
Closed

Infinite loop when max_age=0 #1545

RolandGuijt opened this issue Apr 29, 2024 · 0 comments · Fixed by #1565
Assignees
Labels
bug Something isn't working
Milestone

Comments

@RolandGuijt
Copy link

In v7 the login page is displayed over and over again when the max_age parameter in an authorization endpoint request is set to 0.

It is cause by the fact that the new time provider abstraction changed how we handle this case in practice. We want to treat max_age=0 as a special case because

  • current behavior is buggy
  • it is specifically mentioned in the spec as being equivalent to prompt=login
  • handling it as a special case (only remove when the parameter is 0) makes it a bug fix instead of a breaking change

DuendeSoftware/Support#1229

@josephdecock josephdecock linked a pull request May 31, 2024 that will close this issue
@josephdecock josephdecock added this to the 7.0.5 milestone Jun 4, 2024
@josephdecock josephdecock self-assigned this Jun 4, 2024
@josephdecock josephdecock added the bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants