-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding AsSingleQuery to EF joins #1393
Comments
Look into the older IS4 repo for something similar. We did have customers saying that single query was a problem. |
I didn't find anything just searching for "AsSingleQuery" or "AsSplitQuery" in the old issue tracker. I did find #705, where we are setting AsSplitQuery in one of the queries in the client store. I don't think we should change any places where we are explicitly setting single or split query behavior. I want to be explicit where we currently are not, to reduce warnings (there was a support issue where someone noticed some warnings). |
EF generates warnings when you include multiple collections but don't specify if you want joins or multiple queries with AsSingleQuery or AsSplitQuery. The idea is to force developers to consider the performance implications of doing a lot of joins. I'm not aware of any of our queries likely causing a cartestian explosion, so we should tell EF not to worry about it by explicitly saying AsSingleQuery on our queries.
Reference: https://learn.microsoft.com/en-us/ef/core/querying/single-split-queries#enabling-split-queries-globally
The text was updated successfully, but these errors were encountered: