RuntimeError: aiodns needs a SelectorEventLoop on Windows

[ruidazeng]

I have been trying to benchmark on my Windows machine today (instead of my usual Macbook), and I ran into these errors when running the program normally (with all the requirements installed).

  File "C:\Users\RAZEER\AppData\Local\Programs\Python\Python311\Lib\site-packages\aiohttp\connector.py", line 845, in __init__
    resolver = DefaultResolver(loop=self._loop)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\RAZEER\AppData\Local\Programs\Python\Python311\Lib\site-packages\aiohttp\resolver.py", line 95, in __init__
    self._resolver = aiodns.DNSResolver(*args, **kwargs)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\RAZEER\AppData\Local\Programs\Python\Python311\Lib\site-packages\aiodns\__init__.py", line 60, in __init__
    raise RuntimeError(
RuntimeError: aiodns needs a SelectorEventLoop on Windows. See more: https://github.com/saghul/aiodns/issues/86

This was fixed by adding this line on top of the code in main.py.

if __name__ == "__main__":
    if hasattr(asyncio, "WindowsSelectorEventLoopPolicy"):
        asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy()) # Windows handles asynchronous event loops

I am wondering if this is a common issue and if other people has ran into something similar, or if there is some other fixes possible.

I am checking for more issues while running the benchmarks, and will submit a pull request to both the benchmarks branch and the main branch (if needed) at some point later.

[ruidazeng]

This seems like a known issue due to differences in how Windows handles asynchronous event loops...and it doesn't work without the new line added on my Windows machine

[ruidazeng]

This is linked to #23

[ruidazeng]

Some references on how this issue is resolved, seems like both point to a common solution:

https://github.com/aio-libs/aiodns?tab=readme-ov-file#note-for-windows-users