-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Argument Validation Fails for ® #151
Comments
Regex fix for ®
|
As a workaround for myself going forward I am now “precleaning” these optional arguments – stripping away everything which the regex will not accept as valid before I pass them to this library, e.g.
I think that will work fine for me, perhaps for others too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had another instance of #99, this time with a trader name containing the registered trademark character: ®
I asked ChatGPT for some other characters commonly used in the west which are marked as invalid by the current regex. It came up with:
With sincere respect and gratefulness for your work on this library, the VIES service is an open, public sector API which is surely protected from the kinds of naive attacks which the regex is intended to prevent. I think this library could remove this layer of validation. ($vies->validateArgument) I can’t see that it would be irresponsible to do so. Or am I missing something?
The text was updated successfully, but these errors were encountered: