Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: event/action upgrades #281

Open
eradin opened this issue Jul 8, 2020 · 1 comment
Open

Feature: event/action upgrades #281

eradin opened this issue Jul 8, 2020 · 1 comment

Comments

@eradin
Copy link

eradin commented Jul 8, 2020

Both the events and actions systems are inadequate. As noted before, onAdd never fires for new rows, columns and fields. In addition, the data that it passes is simply the dom markup. It needs better object info like type of field (for new fields) and panel info for updated Attributes and Conditions. Field type can only be extracted from the markup which is ugly and subject to change.

In addition, the actions are not very useful as they don't have lifecycle management. All action notifications are after the fact notifications. For example, we should be able to prevent a delete action by returning false on a "clicked" action. Perhaps a full action lifecycle like beforeClick, Clicked and afterClick.

Perhaps there is current support for this and it's a documentation issue.

@kevinchappell
Copy link
Collaborator

100% agree with everything stated. Added to the roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants