Skip to content

Sleep Timer to End of Chapter #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gandalf-the-Blue opened this issue Apr 11, 2025 · 2 comments
Open

Sleep Timer to End of Chapter #75

Gandalf-the-Blue opened this issue Apr 11, 2025 · 2 comments
Labels
enhancement New feature or request ui changes in ui

Comments

@Gandalf-the-Blue
Copy link

Hi,
I'd like an option to set the sleep timer to end of chapter. I think this is an important feature.

@Dr-Blank
Copy link
Owner

This one is tricky, as a rudimentary feature app could just calculate the time and set sleep timer for that much time. Con is that if you seek or manually change chapter sleep timer will just continue without the knowledge.

Another option is to pause when actually chapter changes. This is logical but there are few concerns

  1. what happens when you shake to reset the timer? (i think extend it to another chapter)
  2. what if you manually skip, should the playing pause? (or should the timer adjust according the new chapter)

please let me know your thoughts

@Dr-Blank Dr-Blank added enhancement New feature or request ui changes in ui and removed needs triage labels Apr 11, 2025
@Gandalf-the-Blue
Copy link
Author

Oh, those are good questions I hadn't thought about.
I think tying the sleep timer to chapter change would be a good idea, it takes care of whatever the user does within the chapter without affecting the sleep timer.
When shake to reset is done, I think the sleep timer should just be disabled.
Similarly, when manually skipping, I think the player should pause and the sleep timer should just be disabled.

This way, I think there is consistency in that the sleep timer, when set for a chapter, is locked to that chapter. It doesn't care about what you do within the chapter (seek,rewind etc), and just disables itself when you move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui changes in ui
Projects
Status: Todo
Development

No branches or pull requests

2 participants