Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Tabs/TabPane内部增加className #2152

Open
wangzishun opened this issue Apr 7, 2024 · 5 comments
Open

[Tabs] Tabs/TabPane内部增加className #2152

wangzishun opened this issue Apr 7, 2024 · 5 comments
Labels
feature request Request new feature

Comments

@wangzishun
Copy link
Contributor

Which Component Need Enhancement 期望新增功能的组件

  • Tabs
  • TabPane

What does the proposed API look like 期望支持的API

  • Tabs增加 wrapperClassName
  • TabPane增加 wrapperClassName

或者叫做contentClassName

Feature Description 功能描述

  • 允许通过className对内层div进行样式管理。

Additional information 补充说明

  • 组件div层级过深,且内部div无法继承父元素的高度hight/滚动scroll 等样式;
  • 更适合搭配tailwindcss进行样式开发,css module方案进行样式覆盖对于业务管理十分不便。

image
image

@wangzishun wangzishun added the feature request Request new feature label Apr 7, 2024
@pointhalo pointhalo added good first issue Good for newcomers PR Welcome Welcome pull request :) labels Apr 7, 2024
@wangzishun
Copy link
Contributor Author

发起了PR申请解决这个问题

#2153

@pointhalo
Copy link
Collaborator

预计跟 v2.57 beta.0 版本合入

@pointhalo
Copy link
Collaborator

pointhalo commented Apr 19, 2024

没理解为什么一定要在 TabPane层再加一个 contentClassname,有什么样式控制是没法通过 TabPane 目前的 classname来实现的吗?

@YannLynn
Copy link
Collaborator

「组件div层级过深,且内部div无法继承父元素的高度hight/滚动scroll 等样式」 这个有相应的需求场景或者例子来辅助说明嘛~

@pointhalo
Copy link
Collaborator

<TabPane style={{ overflow: 'auto', height: 300 }}>
<div style={{ height: 600 or auto }}>

我没理解这里的不继承height、scroll会造成什么问题,似乎不是一个刚需。像这个例子它也是正常work的呀。

@pointhalo pointhalo removed good first issue Good for newcomers PR Welcome Welcome pull request :) labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request new feature
Projects
None yet
Development

No branches or pull requests

3 participants