Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage CRDs via Helm #53

Open
zoispag opened this issue Nov 22, 2023 · 1 comment
Open

Manage CRDs via Helm #53

zoispag opened this issue Nov 22, 2023 · 1 comment

Comments

@zoispag
Copy link

zoispag commented Nov 22, 2023

Request

Consider supporting managing for CRDs via Helm.

Reasoning

We manage our charts, including doppler-kubernetes-operator using ArgoCD. And we use Renovatebot to keep dependencies up to date.

The renovatebot PR looks like this:

image

and seeing there is a new property in the DopplerSecret, made me think that I might have to update my CRDs. But this might not always be the case, and I do not want to do this manually.

How to achieve

Helm cannot upgrade custom resource definitions in the <chart>/crds folder by design.

However, by moving the CRDs inside the <chart>/templates directory, it is possible to keep them in-sync, together with the rest of the templates when there's a new version.

See for example how ArgoCD project is doing the same: https://github.com/argoproj/argo-helm/tree/main/charts/argo-cd#custom-resource-definitions

@nmanoogian
Copy link
Member

Thanks for reaching out about this, @zoispag! We've hit several issues with Helm's recommendations for CRD management. It's good to know that other established projects are choosing to include their CRDs in the main /templates directory rather than using /crds.

I'll share this with the product team and see if we can dig in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants