-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Test Runner Exit code 2 #167
Labels
enhancement
New feature or request
Comments
Thank you @bdovaz for the detailed explaination. This change makes a lot of sense. |
@FejZa I'm glad you have implemented this functionality but I would make two small changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you look at this page, they clearly put that if the exit code is 2 it means that the Unity process has been executed correctly but that some tests have failed.
I am requesting this change because otherwise it would not be possible to subsequently execute a task that publishes the test results including the failures to analyze the cause.
Sources:
I put a link from an old version of Unity because in the new one it does not appear:
https://docs.unity3d.com/530/Documentation/Manual/testing-editortestsrunner.html
I put a link to a third party repository because the source code of the test framework package is not public, you can see the code there:
https://github.com/needle-mirror/com.unity.test-framework/blob/master/UnityEditor.TestRunner/CommandLineTest/ExitCallbacks.cs#L24
https://github.com/needle-mirror/com.unity.test-framework/blob/master/UnityEditor.TestRunner/CommandLineTest/Executer.cs#L60
Looking at the code I see that this exit code is not managed and the task is directly marked as failed so it does not allow you to execute tasks later in the pipeline.
https://github.com/Dinomite-Studios/unity-azure-pipelines-tasks/blob/main/Tasks/UnityTest/UnityTestV1/unity-test.ts#L117
The text was updated successfully, but these errors were encountered: