Testing (crayfishx#60)

* guarding initial spec stuff

* added initial testing

* added more tests

* added travis

* removed jruby

* added badge

Author: crayfishx

.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+script: "bundle exec rspec --format documentation"
+
+rvm:
+  - 2.1.9
+  - 2.4.1

Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+gem 'rspec'
+gem 'lookup_http'

README.md

@@ -1,3 +1,6 @@
+
+[![Build Status](https://travis-ci.org/crayfishx/hiera-http.svg?branch=master)](https://travis-ci.org/crayfishx/hiera-http)
+
 ## hiera_http : a HTTP data provider function (backend) for Hiera 5
 
 ### Description

Rakefile

@@ -23,6 +23,7 @@ def lookup_key(key, options, context)
       unless key[regex_key_match] == key
         context.explain { "Skipping hiera_http backend because key does not match confine_to_keys" }
         context.not_found
+        return
       end
     end
 

lib/puppet/functions/hiera_http.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+  
+require 'puppet/functions/hiera_http'
+
+describe FakeFunction do
+
+  let(:function) { described_class.new }
+  before(:each) do
+    @lookuphttp = instance_double("LookupHttp")
+    @context = instance_double("Puppet::LookupContext")
+    allow(LookupHttp).to receive(:new).and_return(@lookuphttp)
+    allow(@context).to receive(:cache_has_key)
+    allow(@context).to receive(:explain)
+    allow(@context).to receive(:interpolate)
+    allow(@context).to receive(:cache)
+    allow(@context).to receive(:not_found)
+    allow(@context).to receive(:interpolate).with('/path').and_return('/path')
+  end
+
+  describe "#lookup_key" do
+
+    context "Should run" do
+      let(:options) { {
+        'uri' => 'http://192.168.0.1:8080/path'
+      } }
+
+      it "should run" do
+        expect(LookupHttp).to receive(:new).with({ :host => '192.168.0.1', :port => 8080 })
+        expect(@lookuphttp).to receive(:get_parsed).with('/path').and_return('value')
+        expect(function.lookup_key('bar', options, @context)).to eq('value')
+      end
+    end
+
+    context "When using __XXX__ interpolation" do
+      let(:key) { 'foo::bar::tango' }
+       
+      it "should interpolate __KEY__ correctly" do
+        options = { 'uri' => 'http://localhost/path/__KEY__' }
+        expect(@context).to receive(:interpolate).with('/path/foo::bar::tango').and_return('/path/foo::bar::tango')
+        expect(@lookuphttp).to receive(:get_parsed).with('/path/foo::bar::tango')
+        function.lookup_key('foo::bar::tango', options, @context)
+      end
+    end
+
+    context "When confine_to_keys is set" do
+      let(:options) { {
+        'uri' => 'http://localhost/path',
+        'confine_to_keys' => [ /^tango.*/ ],
+      } }
+
+      before(:each) do
+        allow(@context).to receive(:interpolate).with('/path').and_return('/path')
+      end
+
+      it "should return not found for non matching keys" do
+        expect(@context).to receive(:not_found)
+        expect(@lookuphttp).not_to receive(:get_parsed)
+        function.lookup_key('bar', options, @context)
+      end
+
+      it "should run if key matches" do
+        expect(@context).not_to receive(:not_found)
+        expect(@lookuphttp).to receive(:get_parsed).with('/path').and_return('value')
+        expect(function.lookup_key('tangodelta', options, @context)).to eq('value')
+      end
+    end
+
+    context "Output of lookup_http" do
+      let(:options) { {
+        'uri' => 'http://localhost/path',
+      } }
+      it "should dig if the value is a hash" do
+        expect(@lookuphttp).to receive(:get_parsed).with('/path').and_return({ 'tango' => 'delta' })
+        expect(function.lookup_key('tango', options, @context)).to eq('delta')
+      end
+      it "should return the whole value if the value is a string" do
+        expect(@lookuphttp).to receive(:get_parsed).with('/path').and_return('delta')
+        expect(function.lookup_key('tango', options, @context)).to eq('delta')
+      end
+    end
+
+
+      
+      
+  end
+
+
+end

spec/functions/hiera_http_spec.rb

@@ -0,0 +1,20 @@
+
+
+class FakeFunction
+  def self.dispatch(name, &block)
+  end
+end
+
+
+module Puppet
+  module Functions
+    def self.create_function(name, &block)
+      FakeFunction.class_eval(&block)
+    end
+  end
+  class DataBinding
+    class LookupError < RuntimeError
+    end
+  end
+end
+