Skip to content

Commit 9d63866

Browse files
authored
Merge pull request #1353 from jbc25/oppia-1653-update-api-34
Oppia 1653 update api 34
2 parents 73c42cd + 97cff2d commit 9d63866

21 files changed

+74
-41
lines changed

app/src/androidTest/java/androidTestFiles/activities/DownloadActivityUITest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ private CourseInstallViewAdapter getBaseCourse() {
121121

122122
private void sendBroadcast(Context ctx, String action) {
123123
Intent intent = new Intent(CourseInstallerService.BROADCAST_ACTION);
124+
intent.setPackage(ctx.getPackageName());
124125
intent.putExtra(CourseInstallerService.SERVICE_ACTION, action);
125126
intent.putExtra(CourseInstallerService.SERVICE_URL, "Mock URL");
126127
intent.putExtra(CourseInstallerService.SERVICE_MESSAGE, "1");

app/src/androidTest/java/androidTestFiles/activities/DownloadMediaActivityUITest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ public class DownloadMediaActivityUITest extends CourseMediaBaseTest {
4545

4646
private void sendBroadcast(Context ctx, String action, String url) {
4747
Intent intent = new Intent(DownloadService.BROADCAST_ACTION);
48+
intent.setPackage(ctx.getPackageName());
4849
intent.putExtra(DownloadService.SERVICE_ACTION, action);
4950
intent.putExtra(DownloadService.SERVICE_URL, url);
5051
intent.putExtra(DownloadService.SERVICE_MESSAGE, "1");

app/src/androidTest/java/androidTestFiles/features/BluetoothTransferTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ public void setUp() throws Exception {
3636
private void sendBluetoothServiceBroadcast(String message, String errorMsg) {
3737

3838
Intent broadcastIntent = new Intent(BluetoothTransferService.BROADCAST_ACTION);
39+
broadcastIntent.setPackage(context.getPackageName());
3940
broadcastIntent.putExtra(BluetoothTransferService.SERVICE_MESSAGE, message);
4041
broadcastIntent.putExtra(BluetoothTransferService.SERVICE_ERROR, errorMsg);
4142
context.sendBroadcast(broadcastIntent);

app/src/androidTest/java/androidTestFiles/utils/parent/NotificationsUiTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package androidTestFiles.utils.parent;
22

3+
import android.content.Context;
34
import android.content.Intent;
45

56
import androidx.test.platform.app.InstrumentationRegistry;
@@ -13,6 +14,8 @@ public class NotificationsUiTest extends DaggerInjectMockUITest {
1314
@After
1415
public void tearDown() throws Exception {
1516
Intent closeIntent = new Intent(Intent.ACTION_CLOSE_SYSTEM_DIALOGS);
16-
InstrumentationRegistry.getInstrumentation().getTargetContext().sendBroadcast(closeIntent);
17+
Context context = InstrumentationRegistry.getInstrumentation().getTargetContext();
18+
closeIntent.setPackage(context.getPackageName());
19+
context.sendBroadcast(closeIntent);
1720
}
1821
}

app/src/main/java/org/digitalcampus/oppia/activity/AppActivity.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
import org.digitalcampus.oppia.model.Course;
6666
import org.digitalcampus.oppia.utils.TextUtilsJava;
6767
import org.digitalcampus.oppia.utils.UIUtils;
68-
import org.digitalcampus.oppia.utils.storage.Storage;
6968
import org.digitalcampus.oppia.utils.storage.StorageAccessStrategy;
7069

7170
import java.util.concurrent.TimeUnit;
@@ -123,7 +122,7 @@ public void onStart(){
123122
intentFilter.addAction(Intent.ACTION_MEDIA_MOUNTED);
124123
intentFilter.addAction(Intent.ACTION_MEDIA_UNMOUNTED);
125124
intentFilter.addDataScheme("file");
126-
registerReceiver(externalStorageReceiver, intentFilter);
125+
ContextCompat.registerReceiver(this, externalStorageReceiver, intentFilter, ContextCompat.RECEIVER_NOT_EXPORTED);
127126

128127
checkSdCardStatus();
129128
}
@@ -303,7 +302,7 @@ public void onResume() {
303302
gamificationReceiver.setGamificationEventListener(this);
304303
IntentFilter broadcastFilter = new IntentFilter(GamificationService.BROADCAST_ACTION);
305304
broadcastFilter.setPriority(IntentFilter.SYSTEM_HIGH_PRIORITY);
306-
registerReceiver(gamificationReceiver, broadcastFilter);
305+
ContextCompat.registerReceiver(this, gamificationReceiver, broadcastFilter, ContextCompat.RECEIVER_NOT_EXPORTED);
307306

308307
//We check if the user session time has expired to log him out
309308
if (BuildConfig.SESSION_EXPIRATION_ENABLED) {

app/src/main/java/org/digitalcampus/oppia/activity/CourseActivity.java

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
import android.view.WindowManager;
3333
import android.widget.Toast;
3434

35+
import androidx.annotation.NonNull;
36+
import androidx.appcompat.app.ActionBar;
37+
import androidx.fragment.app.Fragment;
38+
3539
import com.google.android.material.tabs.TabLayout;
3640

3741
import org.digitalcampus.mobile.learning.R;
@@ -59,10 +63,6 @@
5963
import java.util.List;
6064
import java.util.Locale;
6165

62-
import androidx.annotation.NonNull;
63-
import androidx.appcompat.app.ActionBar;
64-
import androidx.fragment.app.Fragment;
65-
6666
public class CourseActivity extends AppActivity implements OnInitListener, TabLayout.OnTabSelectedListener {
6767

6868
public static final String BASELINE_TAG = "BASELINE";
@@ -92,7 +92,7 @@ public void onCreate(Bundle savedInstanceState) {
9292

9393
binding = ActivityCourseBinding.inflate(LayoutInflater.from(this));
9494
setContentView(binding.getRoot());
95-
95+
9696
ActionBar actionBar = getSupportActionBar();
9797

9898
Bundle bundle = this.getIntent().getExtras();
@@ -114,28 +114,26 @@ public void onCreate(Bundle savedInstanceState) {
114114
actionBar.setDisplayShowTitleEnabled(true);
115115
}
116116

117-
if (section.isProtectedByPassword() && !section.isUnlocked()){
117+
if (section.isProtectedByPassword() && !section.isUnlocked()) {
118118
topicLocked = true;
119119
supportInvalidateOptionsMenu();
120120
binding.unlockTopicForm.setVisibility(View.VISIBLE);
121121
binding.submitPassword.setOnClickListener(view -> {
122122
String password = binding.sectionPasswordField.getText().toString();
123-
if (section.checkPassword(password)){
123+
if (section.checkPassword(password)) {
124124
DbHelper.getInstance(this).saveSectionUnlockedByUser(course, section, userID, password);
125125
binding.unlockTopicForm.setVisibility(View.GONE);
126126
topicLocked = false;
127127
loadActivities();
128128
supportInvalidateOptionsMenu();
129-
}
130-
else{
129+
} else {
131130
binding.sectionPasswordError.setVisibility(View.VISIBLE);
132131
SimpleAnimator.fade(binding.sectionPasswordError, SimpleAnimator.FADE_IN);
133132
binding.sectionPasswordField.setText("");
134133
}
135134

136135
});
137-
}
138-
else{
136+
} else {
139137
loadActivities();
140138
}
141139

@@ -222,7 +220,7 @@ public boolean onPrepareOptionsMenu(Menu menu) {
222220
ttsMenuItem.setTitle(ttsRunning ? R.string.menu_stop_read_aloud : R.string.menu_read_aloud);
223221

224222
// If there is only one language for this course, makes no sense to show the language menu
225-
if (course.getLangs().size() <= 1){
223+
if (course.getLangs().size() <= 1) {
226224
MenuItem langMenuItem = menu.findItem(R.id.menu_language);
227225
langMenuItem.setVisible(false);
228226
langMenuItem.setEnabled(false);
@@ -244,8 +242,11 @@ public boolean onOptionsItemSelected(MenuItem item) {
244242
return true;
245243

246244
case R.id.menu_text_size:
247-
UIUtils.showChangeTextSizeDialog(this,
248-
() -> sendBroadcast(new Intent(BaseWidget.ACTION_TEXT_SIZE_CHANGED)));
245+
UIUtils.showChangeTextSizeDialog(this, () -> {
246+
Intent intent = new Intent(BaseWidget.ACTION_TEXT_SIZE_CHANGED);
247+
intent.setPackage(getPackageName());
248+
sendBroadcast(intent);
249+
});
249250
return true;
250251

251252
case R.id.menu_help:
@@ -331,7 +332,7 @@ private void loadActivities() {
331332

332333
for (int i = 0; i < activities.size(); i++) {
333334
Activity activity = determineActivityType(i, fragments);
334-
if (activity != null){
335+
if (activity != null) {
335336
titles.add(activity.getTitle(currentLang));
336337
}
337338
}
@@ -344,7 +345,7 @@ private void loadActivities() {
344345
binding.tabsToolbar.addOnTabSelectedListener(this);
345346
apAdapter.updateTabViews(binding.tabsToolbar);
346347

347-
if (currentActivityNo >= fragments.size()){
348+
if (currentActivityNo >= fragments.size()) {
348349
//Wrong activity number passed
349350
Toast.makeText(this, "Wrong activity parameter", Toast.LENGTH_SHORT).show();
350351
this.finish();
@@ -353,7 +354,7 @@ private void loadActivities() {
353354
binding.activityWidgetPager.setCurrentItem(currentActivityNo);
354355
}
355356

356-
private Activity determineActivityType(int i, List<Fragment> fragments){
357+
private Activity determineActivityType(int i, List<Fragment> fragments) {
357358
Activity activity = activities.get(i);
358359
//Fragment creation
359360
if (activity.getActType().equalsIgnoreCase("page")) {
@@ -379,8 +380,7 @@ private Activity determineActivityType(int i, List<Fragment> fragments){
379380
} else if (activities.get(i).getActType().equalsIgnoreCase("url")) {
380381
UrlWidget f = UrlWidget.newInstance(activities.get(i), course, isBaseline);
381382
fragments.add(f);
382-
}
383-
else {
383+
} else {
384384
return null;
385385
}
386386

app/src/main/java/org/digitalcampus/oppia/activity/DeviceListActivity.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import android.widget.TextView;
3434

3535
import androidx.annotation.NonNull;
36+
import androidx.core.content.ContextCompat;
3637

3738
import org.digitalcampus.mobile.learning.R;
3839
import org.digitalcampus.mobile.learning.databinding.ActivityDeviceListBinding;
@@ -119,11 +120,11 @@ protected void onCreate(Bundle savedInstanceState) {
119120

120121
// Register for broadcasts when a device is discovered
121122
IntentFilter filter = new IntentFilter(BluetoothDevice.ACTION_FOUND);
122-
this.registerReceiver(mReceiver, filter);
123+
ContextCompat.registerReceiver(this, mReceiver, filter, ContextCompat.RECEIVER_NOT_EXPORTED);
123124

124125
// Register for broadcasts when discovery has finished
125126
filter = new IntentFilter(BluetoothAdapter.ACTION_DISCOVERY_FINISHED);
126-
this.registerReceiver(mReceiver, filter);
127+
ContextCompat.registerReceiver(this, mReceiver, filter, ContextCompat.RECEIVER_NOT_EXPORTED);
127128

128129
}
129130

@@ -147,7 +148,7 @@ protected void onResume() {
147148
receiver.setListener(this);
148149
IntentFilter broadcastFilter = new IntentFilter(BluetoothTransferService.BROADCAST_ACTION);
149150
broadcastFilter.setPriority(IntentFilter.SYSTEM_HIGH_PRIORITY);
150-
registerReceiver(receiver, broadcastFilter);
151+
ContextCompat.registerReceiver(this, receiver, broadcastFilter, ContextCompat.RECEIVER_NOT_EXPORTED);
151152
}
152153

153154
/**

app/src/main/java/org/digitalcampus/oppia/activity/DownloadActivity.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
import android.view.View;
2929
import android.widget.Toast;
3030

31+
import androidx.core.content.ContextCompat;
32+
3133
import org.digitalcampus.mobile.learning.R;
3234
import org.digitalcampus.mobile.learning.databinding.ActivityDownloadBinding;
3335
import org.digitalcampus.oppia.application.App;
@@ -256,7 +258,7 @@ public void onResume() {
256258
receiver.setCourseInstallerListener(this);
257259
IntentFilter broadcastFilter = new IntentFilter(CourseInstallerService.BROADCAST_ACTION);
258260
broadcastFilter.setPriority(IntentFilter.SYSTEM_HIGH_PRIORITY);
259-
registerReceiver(receiver, broadcastFilter);
261+
ContextCompat.registerReceiver(this, receiver, broadcastFilter, ContextCompat.RECEIVER_NOT_EXPORTED);
260262

261263
if (json == null) {
262264
// The JSON download task has not started or been completed yet

app/src/main/java/org/digitalcampus/oppia/activity/DownloadMediaActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
import javax.inject.Inject;
5454

5555
import androidx.annotation.NonNull;
56+
import androidx.core.content.ContextCompat;
5657

5758
public class DownloadMediaActivity extends AppActivity implements DownloadMediaListener, ScanMediaListener {
5859

@@ -244,7 +245,7 @@ public void onResume() {
244245
receiver.setMediaListener(this);
245246
IntentFilter broadcastFilter = new IntentFilter(DownloadService.BROADCAST_ACTION);
246247
broadcastFilter.setPriority(IntentFilter.SYSTEM_HIGH_PRIORITY);
247-
registerReceiver(receiver, broadcastFilter);
248+
ContextCompat.registerReceiver(this, receiver, broadcastFilter, ContextCompat.RECEIVER_NOT_EXPORTED);
248249

249250
invalidateOptionsMenu();
250251
}

app/src/main/java/org/digitalcampus/oppia/activity/SyncActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
import java.util.List;
4545

4646
import androidx.annotation.NonNull;
47+
import androidx.core.content.ContextCompat;
4748
import androidx.recyclerview.widget.DividerItemDecoration;
4849
import androidx.recyclerview.widget.LinearLayoutManager;
4950
import androidx.recyclerview.widget.RecyclerView;
@@ -184,7 +185,7 @@ public void onResume() {
184185
receiver.setListener(this);
185186
IntentFilter broadcastFilter = new IntentFilter(BluetoothTransferService.BROADCAST_ACTION);
186187
broadcastFilter.setPriority(IntentFilter.SYSTEM_HIGH_PRIORITY);
187-
registerReceiver(receiver, broadcastFilter);
188+
ContextCompat.registerReceiver(this, receiver, broadcastFilter, ContextCompat.RECEIVER_NOT_EXPORTED);
188189

189190
updateStatus(true);
190191

0 commit comments

Comments
 (0)