Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reaction on Comments Doesn't Work properly as reacting on posts #512

Open
SanskarGosavi2003 opened this issue Dec 8, 2023 · 0 comments
Open

Reaction on Comments Doesn't Work properly as reacting on posts #512

SanskarGosavi2003 opened this issue Dec 8, 2023 · 0 comments
Labels
discussion DOPE-contribution effort3: high flag: breaking change priority2: important severity3: broken type: performance

Comments

@SanskarGosavi2003
Copy link
Member

SanskarGosavi2003 commented Dec 8, 2023 •
edited
Loading

How to replicate the issue on app

  1. React on a comment
  2. Go back from the full post view
  3. Come back you will see your reaction still in the combined reactions
  4. But will also see add new reaction icon instead of your reaction
  5. On clicking on your previous reaction your reaction wont delete
  6. To do so you have to click twice on your previous reaction

Probable Reasons

  1. Reaction by the user is not saved properly
  2. The logic applied while saving isn't foolproof

How to Solve

  1. Think of a better logic to save the user reactions
  2. Document that logic and also have a conversation regarding that logic with @SanskarGosavi2003 or @PalMit2002
  3. Code :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion DOPE-contribution effort3: high flag: breaking change priority2: important severity3: broken type: performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SanskarGosavi2003