Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't filter action run on semver #16

Open
maxheld83 opened this issue Feb 1, 2025 · 0 comments
Open

don't filter action run on semver #16

maxheld83 opened this issue Feb 1, 2025 · 0 comments

Comments

@maxheld83
Copy link
Contributor

total nitpick, but:

    tags:
      - "v?[0-9]+.[0-9]+.[0-9]+*"

... isn't this (= whether the tag is valid semver and what to do if not) a concern for the https://github.com/DeterminateSystems/flakehub-push action?

If, for example, I fumble the git tag -a v.a.b.c, I'd rather have the action still run, and then (possibly) have the push to FlakeHub fail, if FlakeHub requires semantic versioning.

So I'd suggest just removing that line from the example workflow uses.

(Or I'd be curious to know why we should filter already at the GHA workflow run level).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant