Update behavior so setting off = no hover behavior

Author: FlaminSarge

config/i18n.json

@@ -1259,7 +1259,7 @@
     "MaxParallelCores": "Maximum cores for parallel tasks",
     "MaxParallelCoresExplanation": "Controls how many CPU cores DIM can use for intensive tasks like Loadout Optimizer and Loadout Analyzer. Higher values may improve performance but use more system resources.",
     "OrnamentDisplay": "Show Ornaments on item tiles",
-    "OrnamentDisplayExplanationDisabled": "Hovering or long-pressing armor will show its ornament",
+    "OrnamentDisplayExplanationDisabled": "Items will never display their ornaments",
     "OrnamentDisplayExplanationEnabled": "Hovering or long-pressing armor will hide its ornament",
     "OrnamentDisplayExplanationHide": "Hovering or long-pressing an item will hide its ornament",
     "OrnamentDisplayExplanationShow": "Hovering or long-pressing an item will show its ornament",

src/app/inventory/ItemIcon.m.scss

@@ -98,7 +98,10 @@ $commonBg: #366f42;
   }
 
   :global(.item):hover &.isArmor {
-    opacity: var(--ornament-display-opacity, 1);
+    opacity: calc(
+      1 - var(--ornament-display-opacity, 1) * (1 - var(--ornament-display-opacity, 1))
+    );
+    // there's probably some additional visibility handling needed here
     content-visibility: var(--ornament-display-visibility, auto);
   }
 }
@@ -115,7 +118,8 @@ $commonBg: #366f42;
   }
 
   :global(.item):hover &.isArmor {
-    opacity: calc(1 - var(--ornament-display-opacity, 1));
+    opacity: calc(var(--ornament-display-opacity, 1) * (1 - var(--ornament-display-opacity, 1)));
+    // there's probably some additional visibility handling needed here
     content-visibility: var(--ornament-display-visibility-inverse, hidden);
   }
 }

src/locale/en.json

@@ -1242,7 +1242,7 @@
     "MaxParallelCores": "Maximum cores for parallel tasks",
     "MaxParallelCoresExplanation": "Controls how many CPU cores DIM can use for intensive tasks like Loadout Optimizer and Loadout Analyzer. Higher values may improve performance but use more system resources.",
     "OrnamentDisplay": "Show Ornaments on item tiles",
-    "OrnamentDisplayExplanationDisabled": "Hovering or long-pressing armor will show its ornament",
+    "OrnamentDisplayExplanationDisabled": "Items will never display their ornaments",
     "OrnamentDisplayExplanationEnabled": "Hovering or long-pressing armor will hide its ornament",
     "OrnamentDisplayExplanationHide": "Hovering or long-pressing an item will hide its ornament",
     "OrnamentDisplayExplanationShow": "Hovering or long-pressing an item will show its ornament",