Merge pull request #10327 from DestinyItemManager/itemValueVisibility

use itemValueVisibility to filter item rewards

Author: nev-r

docs/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Next
 
 * Loadouts with only armor mods, or only fashion (shaders & ornaments), now display a symbol in the equip dropdown, and can be filtered from among other loadouts.
+* BRAVE bounties now display correct rewards instead of all possible rewards.
 
 ## 8.15.0 <span class="changelog-date">(2024-04-07)</span>
 

package.json

@@ -208,7 +208,7 @@
     "@textcomplete/core": "^0.1.13",
     "@textcomplete/textarea": "^0.1.13",
     "@textcomplete/utils": "^0.1.13",
-    "bungie-api-ts": "^5.0.0",
+    "bungie-api-ts": "^5.1.0",
     "caniuse-lite": "^1.0.30001588",
     "clsx": "^2.1.0",
     "comlink": "^4.4.1",

pnpm-lock.yaml

@@ -28,6 +28,7 @@ import {
   DestinyItemTooltipNotification,
   DestinyObjectiveProgress,
   DestinyProfileResponse,
+  DestinyVendorSaleItemComponent,
   DictionaryComponentResponse,
   ItemBindStatus,
   ItemLocation,
@@ -142,6 +143,8 @@ export function makeFakeItem(
   itemInstanceId = '0',
   quantity = 1,
   allowWishList = false,
+  /** if available, this should be passed in from a vendor saleItem (DestinyVendorSaleItemComponent) */
+  itemValueVisibility?: DestinyVendorSaleItemComponent['itemValueVisibility'],
 ): DimItem | undefined {
   const item = makeItem(
     context,
@@ -153,7 +156,7 @@ export function makeFakeItem(
       location: ItemLocation.Vendor,
       bucketHash: 0,
       transferStatus: TransferStatuses.NotTransferrable,
-      itemValueVisibility: [],
+      itemValueVisibility,
       lockable: false,
       state: ItemState.None,
       isWrapper: false,
@@ -781,7 +784,12 @@ function buildPursuitInfo(
   item: DestinyItemComponent,
   itemDef: DestinyInventoryItemDefinition,
 ) {
-  const rewards = itemDef.value ? itemDef.value.itemValue.filter((v) => v.itemHash) : [];
+  const rewards = itemDef.value
+    ? itemDef.value.itemValue.filter(
+        (v, i) => v.itemHash && (item.itemValueVisibility?.[i] ?? true),
+      )
+    : [];
+
   const questLine = getQuestLineInfo(itemDef);
   const expiration = getExpirationInfo(item, itemDef);
 

src/app/inventory/store/d2-item-factory.ts

@@ -111,6 +111,7 @@ function makeVendorItem(
       vendorItemDef ? vendorItemDef.quantity : 1,
       // vendor items are wish list enabled!
       true,
+      saleItem?.itemValueVisibility,
     ),
   };