New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`ribasim --version` is wrong for releases #2040

Open

visr opened this issue Feb 4, 2025 · 0 comments

Labels

CI/CD

Member

visr commented Feb 4, 2025

Previously we had the issue #1655 that failed the release tests. The tests we fixed, but the issue described in #1655 (comment) remains.

The README.md for the v2025.1.0 build states:

version = "2024.11.0-74-ge2b86cd"
commit = "https://github.com/Deltares/Ribasim/tree/e2b86cdb0d"
branch = "https://github.com/Deltares/Ribasim/tree/main"

That commit is the right one: https://github.com/Deltares/Ribasim/tree/e2b86cdb0d. So why is it not recognizing the tag? The release workflow is supposed to trigger on the tag being pushed, as mentioned here: https://ribasim.org/dev/release.html#create-a-new-release. Perhaps that is not the case? Or if it already built the same commit that is later tagged it doesn't build new artifacts or something?

github-project-automation bot added this to Ribasim

github-project-automation bot moved this to To do in Ribasim

visr added the CI/CD label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment