From 723d4b3e99ac57a33aa29e7281700bc4b812fb5d Mon Sep 17 00:00:00 2001 From: veenstrajelmer Date: Mon, 17 Jun 2024 12:23:12 +0200 Subject: [PATCH] corrected comments --- kenmerkendewaarden/gemiddeldgetij.py | 2 +- tests/test_slotgemiddelden.py | 2 +- tests/test_tidalindicators.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kenmerkendewaarden/gemiddeldgetij.py b/kenmerkendewaarden/gemiddeldgetij.py index 08a336e..25c86dd 100644 --- a/kenmerkendewaarden/gemiddeldgetij.py +++ b/kenmerkendewaarden/gemiddeldgetij.py @@ -322,7 +322,7 @@ def reshape_signal(ts, ts_ext, HW_goal, LW_goal, tP_goal=None): time_down was scaled with havengetallen before, but not anymore to avoid issues with aggers """ - # early escape # TODO: consider not calling function in this case + # early escape # TODO: should also be possible to only scale tP_goal if HW_goal is None and LW_goal is None: return ts diff --git a/tests/test_slotgemiddelden.py b/tests/test_slotgemiddelden.py index 327f284..6805816 100644 --- a/tests/test_slotgemiddelden.py +++ b/tests/test_slotgemiddelden.py @@ -131,7 +131,7 @@ def test_calc_slotgemiddelden_with_gap(df_meas_2010_2014): slotgemiddelden_dict_withgap = kw.calc_slotgemiddelden(df_meas=df_meas_withgap, df_ext=None, min_coverage=1) slotgemiddelden_dict_withgap_lower_threshold = kw.calc_slotgemiddelden(df_meas=df_meas_withgap, df_ext=None, min_coverage=0.95) - # TODO: value to be updated, but should contain at least one nan value + # check if too large gap results in nan assert slotgemiddelden_dict_nogap["wl_mean_peryear"].isnull().sum() == 0 assert slotgemiddelden_dict_withgap["wl_mean_peryear"].isnull().sum() == 1 assert slotgemiddelden_dict_withgap_lower_threshold["wl_mean_peryear"].isnull().sum() == 0 diff --git a/tests/test_tidalindicators.py b/tests/test_tidalindicators.py index 43c8522..4682a22 100644 --- a/tests/test_tidalindicators.py +++ b/tests/test_tidalindicators.py @@ -53,7 +53,7 @@ def test_calc_wltidalindicators_mincount(df_meas_2010_2014): slotgemiddelden_dict_withgap = kw.calc_wltidalindicators(df_meas_withgap, min_coverage=1) slotgemiddelden_dict_withgap_lower_threshold = kw.calc_wltidalindicators(df_meas_withgap, min_coverage=0.95) - # TODO: value to be updated, but should contain at least one nan value + # check if too large gap results in nan assert slotgemiddelden_dict_nogap["wl_mean_peryear"].isnull().sum() == 0 assert slotgemiddelden_dict_withgap["wl_mean_peryear"].isnull().sum() == 1 assert slotgemiddelden_dict_withgap_lower_threshold["wl_mean_peryear"].isnull().sum() == 0