Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach out to CHT team and plan coordination meeting to align on test coverage (DoD) #649

Open
kathrynroscoe opened this issue Jan 16, 2025 · 2 comments
Assignees

Comments

@kathrynroscoe
Copy link
Contributor

kathrynroscoe commented Jan 16, 2025

Outcome from this should be a workplan and a working alignment between teams for efficiency

@LuukBlom
Copy link
Contributor

Putting my email here as well for documentation:

Hi all,

I updated all cht_repos to have:

  • The only way changes allowed into main are via PRs.
  • PRs can only be merged when all tests pass on each combination of python [3.10, 3.11] and os [windows, Linux, Mac]
  • Pre-commit for linting and code formatting
  • The same release workflow (creating and pushing a tag will create the release on GitHub + publish to PyPi)

All workflows are working, I also fixed some low hanging fruit w.r.t the tests, however I did not get all tests are green:
https://github.com/Deltares-research/cht_observations --> all green and merged already
Deltares-research/cht_meteo#5 --> all green, ready to be merged
Deltares-research/cht_cyclones#11 --> 3 / 4 tests green, 1 red due to an Overflow Error
Deltares-research/cht_tide#4 --> 2 / 4 tests green, 2 red due to non-existent abs paths + Key Error
Deltares-research/cht_tiling#8 --> 2 / 4 tests green, 2 red due to non-existent abs paths + Key Error

There are some things that we need to clarify:
1. Who is using the code (possibly get budget from them)
2. Who is responsible for writing the tests & reviewing (including budget)
3. Who is responsible for cleaning up the old / refactored code?
4. Who is responsible for maintaining the code in the future? (if no one, this will happen again)
5. What level of testing is acceptable?

I'd like to meet next week to discuss so we get started.
Does Wednesday 15.00 work for everyone?

I am hoping @Maarten v. Ormondt will attend as well since you probably know most about these repos and their users.
So somewhere in the afternoon is preferred!
If it doesn’t work, please let me know so we can schedule another time.

Best,

Luuk

@LuukBlom
Copy link
Contributor

LuukBlom commented Feb 4, 2025

Speak to Kathryn for budget for us and for Roel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants