Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot run risk with RPs bellow 1 year #554

Open
2 of 5 tasks
panosatha opened this issue Oct 4, 2024 · 0 comments
Open
2 of 5 tasks

cannot run risk with RPs bellow 1 year #554

panosatha opened this issue Oct 4, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@panosatha
Copy link
Contributor

FloodAdapt version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of FloodAdapt.

Reproducible Example

if an RP of less than a year or in general a decimal RP is configured in the site.toml an error will be returned :
Unknown format code 'd' for object of type 'float'

Current behaviour

map_fn.append(results_path.joinpath(f"RP_{rp:04d}_maps.nc"))

this part assumes that the RP is always an integer.

Desired behaviour

It could be desired that we have RPs bellow 1 year so we should allow for this option.

Task list

  • check all parts that this assumption is used
  • updated workflow
  • write tests

Additional context

No response

@panosatha panosatha added the Bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant