From 424ecb9dd71b928b1702e970651856d5d388de44 Mon Sep 17 00:00:00 2001 From: Jack Bates Date: Mon, 28 Dec 2020 08:41:58 -0700 Subject: [PATCH 1/5] Fix ping stale reviewers on subsequent reviews --- src/compute-pr-actions.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compute-pr-actions.ts b/src/compute-pr-actions.ts index 9ab42e2c8..aa1f5ae9a 100644 --- a/src/compute-pr-actions.ts +++ b/src/compute-pr-actions.ts @@ -2,7 +2,7 @@ import * as Comments from "./comments"; import * as urls from "./urls"; import { PrInfo, BotResult, FileInfo } from "./pr-info"; import { ReviewInfo } from "./pr-info"; -import { noNullish, flatten, unique, sameUser, min, sha256, abbrOid } from "./util/util"; +import { noNullish, flatten, unique, sameUser, max, sha256, abbrOid } from "./util/util"; import * as dayjs from "dayjs"; import * as advancedFormat from "dayjs/plugin/advancedFormat"; dayjs.extend(advancedFormat); @@ -345,7 +345,7 @@ export function process(prInfo: BotResult, } // Ping stale reviewers if any if (info.staleReviews.length > 0) { - const { abbrOid } = min(info.staleReviews, (l, r) => +l.date - +r.date)!; + const { abbrOid } = max(info.staleReviews, (l, r) => +l.date - +r.date)!; const reviewers = info.staleReviews.map(r => r.reviewer); post(Comments.PingStaleReviewer(abbrOid, reviewers)); } From 986ed3259fd7f679760670be99a9a7a0eadbd38b Mon Sep 17 00:00:00 2001 From: Jack Bates Date: Mon, 28 Dec 2020 08:43:18 -0700 Subject: [PATCH 2/5] Update snapshots --- src/_tests/fixtures/38979/mutations.json | 2 +- src/_tests/fixtures/38979/result.json | 2 +- src/_tests/fixtures/43695-duplicate-comment/mutations.json | 2 +- src/_tests/fixtures/43695-duplicate-comment/result.json | 2 +- src/_tests/fixtures/48652-merge-offer/mutations.json | 2 +- src/_tests/fixtures/48652-merge-offer/result.json | 2 +- src/_tests/fixtures/48652-prereq/mutations.json | 2 +- src/_tests/fixtures/48652-prereq/result.json | 2 +- src/_tests/fixtures/49575/mutations.json | 2 +- src/_tests/fixtures/49575/result.json | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/_tests/fixtures/38979/mutations.json b/src/_tests/fixtures/38979/mutations.json index 72a424364..9145ed938 100644 --- a/src/_tests/fixtures/38979/mutations.json +++ b/src/_tests/fixtures/38979/mutations.json @@ -55,7 +55,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", - "body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } }, diff --git a/src/_tests/fixtures/38979/result.json b/src/_tests/fixtures/38979/result.json index 476e15a96..c7321a0af 100644 --- a/src/_tests/fixtures/38979/result.json +++ b/src/_tests/fixtures/38979/result.json @@ -16,7 +16,7 @@ "status": "🔔 @RReverser — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." }, { - "tag": "stale-ping-764528-0e6e7f4", + "tag": "stale-ping-764528-3aba5ac", "status": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" }, { diff --git a/src/_tests/fixtures/43695-duplicate-comment/mutations.json b/src/_tests/fixtures/43695-duplicate-comment/mutations.json index fd72ae034..332167822 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/mutations.json +++ b/src/_tests/fixtures/43695-duplicate-comment/mutations.json @@ -54,7 +54,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", - "body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } }, diff --git a/src/_tests/fixtures/43695-duplicate-comment/result.json b/src/_tests/fixtures/43695-duplicate-comment/result.json index 9b4391fbf..fc4d7d940 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/result.json +++ b/src/_tests/fixtures/43695-duplicate-comment/result.json @@ -15,7 +15,7 @@ "status": "🔔 @alexandercerutti — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" }, { - "tag": "stale-ping-61f252-a5285cd", + "tag": "stale-ping-61f252-68463fd", "status": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" }, { diff --git a/src/_tests/fixtures/48652-merge-offer/mutations.json b/src/_tests/fixtures/48652-merge-offer/mutations.json index d7bcedca0..62cbcbc37 100644 --- a/src/_tests/fixtures/48652-merge-offer/mutations.json +++ b/src/_tests/fixtures/48652-merge-offer/mutations.json @@ -42,7 +42,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTAwNjg4ODM0", - "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/48652-merge-offer/result.json b/src/_tests/fixtures/48652-merge-offer/result.json index fdbb19bea..70d10b6d0 100644 --- a/src/_tests/fixtures/48652-merge-offer/result.json +++ b/src/_tests/fixtures/48652-merge-offer/result.json @@ -17,7 +17,7 @@ "status": "@mgol Everything looks good here. Great job! I am ready to merge this PR (at 06d8d67) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" }, { - "tag": "stale-ping-024242-753cdb3", + "tag": "stale-ping-024242-fa21531", "status": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], diff --git a/src/_tests/fixtures/48652-prereq/mutations.json b/src/_tests/fixtures/48652-prereq/mutations.json index 25e592300..dd0ab07f9 100644 --- a/src/_tests/fixtures/48652-prereq/mutations.json +++ b/src/_tests/fixtures/48652-prereq/mutations.json @@ -42,7 +42,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTAwNjg4ODM0", - "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } }, diff --git a/src/_tests/fixtures/48652-prereq/result.json b/src/_tests/fixtures/48652-prereq/result.json index b9693c845..e5b53a949 100644 --- a/src/_tests/fixtures/48652-prereq/result.json +++ b/src/_tests/fixtures/48652-prereq/result.json @@ -17,7 +17,7 @@ "status": "@mgol Everything looks good here. Great job! I am ready to merge this PR (at 06d8d67) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" }, { - "tag": "stale-ping-024242-753cdb3", + "tag": "stale-ping-024242-fa21531", "status": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" }, { diff --git a/src/_tests/fixtures/49575/mutations.json b/src/_tests/fixtures/49575/mutations.json index 01b2cd3e3..2453ca2f2 100644 --- a/src/_tests/fixtures/49575/mutations.json +++ b/src/_tests/fixtures/49575/mutations.json @@ -44,7 +44,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTIxMTM3NjEy", - "body": "@elibarzilay, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@elibarzilay, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/49575/result.json b/src/_tests/fixtures/49575/result.json index 974e8aef7..df7d39235 100644 --- a/src/_tests/fixtures/49575/result.json +++ b/src/_tests/fixtures/49575/result.json @@ -15,7 +15,7 @@ "status": "🔔 @jablko — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" }, { - "tag": "stale-ping-d2e897-6400f4c", + "tag": "stale-ping-d2e897-90ff51a", "status": "@elibarzilay, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], From 54a33330e6717451fb91db4e4854532f0135c8a6 Mon Sep 17 00:00:00 2001 From: Jack Bates Date: Mon, 18 Jan 2021 14:08:52 -0700 Subject: [PATCH 3/5] Add tests --- src/_tests/fixtures/49699/_downloads.json | 3 + src/_tests/fixtures/49699/_files.json | 7 + src/_tests/fixtures/49699/_response.json | 945 ++++++++++++++++++++++ src/_tests/fixtures/49699/derived.json | 140 ++++ src/_tests/fixtures/49699/mutations.json | 40 + src/_tests/fixtures/49699/result.json | 27 + 6 files changed, 1162 insertions(+) create mode 100644 src/_tests/fixtures/49699/_downloads.json create mode 100644 src/_tests/fixtures/49699/_files.json create mode 100644 src/_tests/fixtures/49699/_response.json create mode 100644 src/_tests/fixtures/49699/derived.json create mode 100644 src/_tests/fixtures/49699/mutations.json create mode 100644 src/_tests/fixtures/49699/result.json diff --git a/src/_tests/fixtures/49699/_downloads.json b/src/_tests/fixtures/49699/_downloads.json new file mode 100644 index 000000000..66f6fc745 --- /dev/null +++ b/src/_tests/fixtures/49699/_downloads.json @@ -0,0 +1,3 @@ +{ + "node": 153005732 +} diff --git a/src/_tests/fixtures/49699/_files.json b/src/_tests/fixtures/49699/_files.json new file mode 100644 index 000000000..d4e9abfcf --- /dev/null +++ b/src/_tests/fixtures/49699/_files.json @@ -0,0 +1,7 @@ +{ + "139c1679ecb5c2a475639582b7a312e4e7a1cde5:types/node/package.json": "{\n \"private\": true,\n \"types\": \"index\",\n \"typesVersions\": {\n \"<=3.4\": {\n \"*\": [\n \"ts3.4/*\"\n ]\n },\n \"<=3.6\": {\n \"*\": [\n \"ts3.6/*\"\n ]\n },\n \"<=3.9\": {\n \"*\": [\n \"ts3.9/*\"\n ]\n }\n }\n}\n", + "master:types/node/package.json": "{\n \"private\": true,\n \"types\": \"index\",\n \"typesVersions\": {\n \"<=3.4\": {\n \"*\": [\n \"ts3.4/*\"\n ]\n },\n \"<=3.6\": {\n \"*\": [\n \"ts3.6/*\"\n ]\n }\n }\n}\n", + "139c1679ecb5c2a475639582b7a312e4e7a1cde5:types/node/ts3.9/tsconfig.json": "{\n \"files\": [\n \"index.d.ts\",\n \"node-tests.ts\"\n ],\n \"compilerOptions\": {\n \"module\": \"commonjs\",\n \"target\": \"esnext\",\n \"lib\": [\n \"es6\",\n \"dom\"\n ],\n \"noImplicitAny\": true,\n \"noImplicitThis\": true,\n \"strictNullChecks\": true,\n \"strictFunctionTypes\": true,\n \"baseUrl\": \"../../\",\n \"typeRoots\": [\n \"../../\"\n ],\n \"types\": [],\n \"noEmit\": true,\n \"forceConsistentCasingInFileNames\": true\n }\n}\n", + "139c1679ecb5c2a475639582b7a312e4e7a1cde5:types/node/ts3.9/tslint.json": "{\n \"extends\": \"dtslint/dt.json\",\n \"rules\": {\n \"no-bad-reference\": false\n }\n}\n", + "master:types/node/index.d.ts": "// Type definitions for non-npm package Node.js 14.14\n// Project: http://nodejs.org/\n// Definitions by: Microsoft TypeScript \n// DefinitelyTyped \n// Alberto Schiabel \n// Alexander T. \n// Alvis HT Tang \n// Andrew Makarov \n// Benjamin Toueg \n// Bruno Scheufler \n// Chigozirim C. \n// David Junger \n// Deividas Bakanas \n// Eugene Y. Q. Shen \n// Flarna \n// Hannes Magnusson \n// Hoàng Văn Khải \n// Huw \n// Kelvin Jin \n// Klaus Meinhardt \n// Lishude \n// Mariusz Wiktorczyk \n// Mohsen Azimi \n// Nicolas Even \n// Nikita Galkin \n// Parambir Singh \n// Sebastian Silbermann \n// Simon Schick \n// Thomas den Hollander \n// Wilco Bakker \n// wwwy3y3 \n// Samuel Ainsworth \n// Kyle Uehlein \n// Jordi Oliveras Rovira \n// Thanik Bhongbhibhat \n// Marcin Kopacz \n// Trivikram Kamat \n// Minh Son Nguyen \n// Junxiao Shi \n// Ilia Baryshnikov \n// ExE Boss \n// Surasak Chaisurin \n// Piotr Błażejewicz \n// Anna Henningsen \n// Jason Kwok \n// Victor Perin \n// Yongsheng Zhang \n// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n\n// NOTE: These definitions support NodeJS and TypeScript 3.7.\n// Typically type modifications should be made in base.d.ts instead of here\n\n/// \n\n// NOTE: TypeScript version-specific augmentations can be found in the following paths:\n// - ~/base.d.ts - Shared definitions common to all TypeScript versions\n// - ~/index.d.ts - Definitions specific to TypeScript 2.8\n// - ~/ts3.5/index.d.ts - Definitions specific to TypeScript 3.5\n\n// NOTE: Augmentations for TypeScript 3.5 and later should use individual files for overrides\n// within the respective ~/ts3.5 (or later) folder. However, this is disallowed for versions\n// prior to TypeScript 3.5, so the older definitions will be found here.\n" +} diff --git a/src/_tests/fixtures/49699/_response.json b/src/_tests/fixtures/49699/_response.json new file mode 100644 index 000000000..538607cbc --- /dev/null +++ b/src/_tests/fixtures/49699/_response.json @@ -0,0 +1,945 @@ +{ + "data": { + "repository": { + "__typename": "Repository", + "id": "MDEwOlJlcG9zaXRvcnk2MDkzMzE2", + "pullRequest": { + "__typename": "PullRequest", + "id": "MDExOlB1bGxSZXF1ZXN0NTI0NjE3Njcz", + "title": "[node]: Base promisify signature on rest arguments and conditional types", + "createdAt": "2020-11-20T10:46:15Z", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "authorAssociation": "CONTRIBUTOR", + "baseRef": { + "__typename": "Ref", + "name": "master" + }, + "labels": { + "__typename": "LabelConnection", + "nodes": [ + { + "__typename": "Label", + "name": "Check Config" + }, + { + "__typename": "Label", + "name": "Critical package" + }, + { + "__typename": "Label", + "name": "The CI failed" + } + ] + }, + "isDraft": false, + "mergeable": "MERGEABLE", + "number": 49699, + "state": "OPEN", + "headRefOid": "139c1679ecb5c2a475639582b7a312e4e7a1cde5", + "timelineItems": { + "__typename": "PullRequestTimelineItemsConnection", + "nodes": [ + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-11-20T10:47:46Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-11-29T10:30:16Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-11-29T10:50:55Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-11-29T11:19:23Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-11-29T12:17:27Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-11-29T12:40:05Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-12-01T18:27:46Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-12-01T18:54:39Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-12-08T01:36:07Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-12-08T17:33:34Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-12-08T17:41:28Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2020-12-09T12:46:06Z" + }, + { + "__typename": "ReopenedEvent", + "createdAt": "2020-12-09T13:00:56Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2021-01-01T13:50:27Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2021-01-01T13:52:25Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "elibarzilay" + }, + "createdAt": "2021-01-01T19:24:49Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2021-01-04T13:24:54Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2021-01-04T22:17:31Z" + }, + { + "__typename": "MovedColumnsInProjectEvent", + "actor": { + "__typename": "User", + "login": "typescript-bot" + }, + "createdAt": "2021-01-15T23:08:24Z" + } + ] + }, + "reviews": { + "__typename": "PullRequestReviewConnection", + "nodes": [ + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "commit": { + "__typename": "Commit", + "oid": "1ec185ff30c89dbe8ceb03862043a434da4e8b99" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "createdAt": "2020-11-29T11:18:34Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "CHANGES_REQUESTED", + "submittedAt": "2020-11-29T11:18:44Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-540470063" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "commit": { + "__typename": "Commit", + "oid": "54b22fd03abac34c70b4b420b8b3d93ae96f9a16" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "createdAt": "2020-12-02T15:11:05Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2020-12-02T15:11:05Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-542933901" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "commit": { + "__typename": "Commit", + "oid": "54b22fd03abac34c70b4b420b8b3d93ae96f9a16" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "createdAt": "2020-12-02T15:12:29Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2020-12-02T15:12:30Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-542935409" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "commit": { + "__typename": "Commit", + "oid": "54b22fd03abac34c70b4b420b8b3d93ae96f9a16" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "createdAt": "2020-12-02T22:04:53Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2020-12-02T22:04:53Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-543276124" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "rbuckton" + }, + "commit": { + "__typename": "Commit", + "oid": "54b22fd03abac34c70b4b420b8b3d93ae96f9a16" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "rbuckton" + }, + "createdAt": "2020-12-08T01:30:14Z" + } + ] + }, + "authorAssociation": "COLLABORATOR", + "state": "COMMENTED", + "submittedAt": "2020-12-08T01:30:15Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-546675733" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "rbuckton" + }, + "commit": { + "__typename": "Commit", + "oid": "54b22fd03abac34c70b4b420b8b3d93ae96f9a16" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "rbuckton" + }, + "createdAt": "2020-12-08T01:32:18Z" + } + ] + }, + "authorAssociation": "COLLABORATOR", + "state": "CHANGES_REQUESTED", + "submittedAt": "2020-12-08T01:35:34Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-546676436" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "commit": { + "__typename": "Commit", + "oid": "54b22fd03abac34c70b4b420b8b3d93ae96f9a16" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "createdAt": "2020-12-08T17:07:03Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2020-12-08T17:07:03Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-547443237" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "commit": { + "__typename": "Commit", + "oid": "54b22fd03abac34c70b4b420b8b3d93ae96f9a16" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "createdAt": "2020-12-08T17:08:01Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2020-12-08T17:08:01Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-547444131" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "commit": { + "__typename": "Commit", + "oid": "2e0ee3aa5bce2071d1688a6f891352b5728b6227" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "createdAt": "2020-12-08T20:36:23Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2020-12-08T20:36:23Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-547608540" + }, + { + "__typename": "PullRequestReview", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "commit": { + "__typename": "Commit", + "oid": "9ba9fdd301b80eeb2348ba491c4cd7e969523007" + }, + "comments": { + "__typename": "PullRequestReviewCommentConnection", + "nodes": [ + { + "__typename": "PullRequestReviewComment", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "createdAt": "2021-01-15T07:34:48Z" + } + ] + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2021-01-15T07:34:48Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699#pullrequestreview-568998305" + } + ] + }, + "commits": { + "__typename": "PullRequestCommitConnection", + "totalCount": 8, + "nodes": [ + { + "__typename": "PullRequestCommit", + "commit": { + "__typename": "Commit", + "checkSuites": { + "__typename": "CheckSuiteConnection", + "nodes": [ + { + "__typename": "CheckSuite", + "app": { + "__typename": "App", + "name": "GitHub Actions" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/139c1679ecb5c2a475639582b7a312e4e7a1cde5/checks?check_suite_id=1839569975", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/139c1679ecb5c2a475639582b7a312e4e7a1cde5/checks?check_suite_id=1839569975", + "checkRuns": { + "__typename": "CheckRunConnection", + "nodes": [ + { + "__typename": "CheckRun", + "title": "test" + } + ] + } + }, + { + "__typename": "CheckSuite", + "app": { + "__typename": "App", + "name": "Azure Pipelines" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/139c1679ecb5c2a475639582b7a312e4e7a1cde5/checks?check_suite_id=1839570738", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/139c1679ecb5c2a475639582b7a312e4e7a1cde5/checks?check_suite_id=1839570738", + "checkRuns": { + "__typename": "CheckRunConnection", + "nodes": [ + { + "__typename": "CheckRun", + "title": "Build #20210115.76 failed" + } + ] + } + } + ] + }, + "status": null, + "authoredDate": "2021-01-15T22:37:22Z", + "committedDate": "2021-01-15T23:23:54Z", + "pushedDate": "2021-01-15T23:24:04Z", + "oid": "139c1679ecb5c2a475639582b7a312e4e7a1cde5" + } + } + ] + }, + "comments": { + "__typename": "IssueCommentConnection", + "totalCount": 20, + "nodes": [ + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczMTA5NDQ0NQ==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@AlCalzone Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `node` [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n - Config files to check:\n - [`node/ts3.9/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files/139c1679ecb5c2a475639582b7a312e4e7a1cde5#diff-7d194a0ca3b6db7e32fc4eb435e98e205402ead7b75989483e1511b93b957a0b): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n - [`node/ts3.9/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files/139c1679ecb5c2a475639582b7a312e4e7a1cde5#diff-eb53a23489cce7c707fb8bdd6f8eda9ce727019af8d141241a5dbbc741f786c7): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n", + "createdAt": "2020-11-20T10:46:49Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczMTA5NDQ1NQ==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "🔔 @Microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @brunoscheufler @smac89 @touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on.\n", + "createdAt": "2020-11-20T10:46:50Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczMTA5NDg4OA==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@AlCalzone The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/86aa4c0b3a5bf263cae09daac15562ede4004b31/checks?check_suite_id=1534481828).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n", + "createdAt": "2020-11-20T10:47:48Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczNTM3NzM2Nw==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@AlCalzone One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. If you disagree with the reviewer's comments, you can \"dismiss\" the review using GitHub's review UI. Thank you!\n", + "createdAt": "2020-11-29T11:19:25Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczNTM4NDY5Ng==", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "body": "> You just need to override the promisify function.\r\n\r\nThat would be simpler, but wouldn't that just add another overload instead of replacing the existing ones? ", + "createdAt": "2020-11-29T12:16:23Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczNTM4NzYwMg==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2020-11-29T12:40:07Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczNTY1MzkzNw==", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "body": "> > You just need to override the promisify function.\r\n> \r\n> That would be simpler, but wouldn't that just add another overload instead of replacing the existing ones?\r\n\r\nYou can do what’s being done with [the `globals.global.d.ts` file](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/globals.global.d.ts) to provide different definitions of `declare var global` between **TypeScript 3.7+** and **TypeScript ≤3.6** by utilising `util.promisify.d.ts`.", + "createdAt": "2020-11-30T09:04:37Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDczNjczNTk2OQ==", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "body": "@ExE-Boss I've tried what you suggested - hope it is correct this time. All the interdependencies between the different types-versions are confusing.\r\n\r\nI've also solved the problem that promisify returned `Promisify<...>` instead of the function signature type.", + "createdAt": "2020-12-01T18:27:06Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc0MDMwMjYzMg==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@AlCalzone One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!\n", + "createdAt": "2020-12-08T01:36:09Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc0MDc5MDc3Mg==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@rbuckton, @ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2020-12-08T17:41:30Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc0MTc0ODEzOA==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@AlCalzone The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/8ca68ab70898720a5a948665c08af4a52fae3e55/checks?check_suite_id=1635337343).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n", + "createdAt": "2020-12-09T12:46:08Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc0MTc1NTA1Mg==", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "body": "Huh, the tests work on my machine:\r\n![grafik](https://user-images.githubusercontent.com/17641229/101632970-e4febc80-3a26-11eb-9930-0e1b95bb31cd.png)\r\n", + "createdAt": "2020-12-09T13:00:35Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc0MjY5MTc5Mg==", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "body": "The failure is in `@types/morgan`: \r\n\r\nAnd `@types/serve‑static`: () ", + "createdAt": "2020-12-10T18:00:35Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc1Mjc3NTYxMw==", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "body": "Anything I need to do here?", + "createdAt": "2020-12-30T22:19:45Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc1MzI5MjczMQ==", + "author": { + "__typename": "User", + "login": "ExE-Boss" + }, + "body": "@AlCalzone Simply rebase on top of the latest `master` branch.", + "createdAt": "2021-01-01T09:30:52Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [ + { + "__typename": "Reaction", + "user": { + "__typename": "User", + "login": "AlCalzone" + } + } + ] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc1MzMxOTI3OA==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2021-01-01T13:52:27Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc2MDM5MTU4Nw==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "Re-ping @Microsoft, @DefinitelyTyped, @jkomyno, @a-tarasyuk, @alvis, @r3nya, @btoueg, @brunoscheufler, @smac89, @touffy, @DeividasBakanas, @eyqs, @Flarna, @Hannes-Magnusson-CK, @KSXGitHub, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @j-oliveras, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @ExE-Boss, @Ryan-Willpower, @peterblazejewicz, @addaleax, @JasonHK, @victorperin, @ZYSzys:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!\n", + "createdAt": "2021-01-14T18:38:39Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc2MTI0NDQwNQ==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@AlCalzone The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/c8af2dd851cc9db15026c03c090caac9bee35bcd/checks?check_suite_id=1839376193).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n", + "createdAt": "2021-01-15T23:08:26Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc2MTI1OTk3Mg==", + "author": { + "__typename": "User", + "login": "typescript-bot" + }, + "body": "@AlCalzone The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/139c1679ecb5c2a475639582b7a312e4e7a1cde5/checks?check_suite_id=1839569975).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!\n", + "createdAt": "2021-01-15T23:51:38Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + }, + { + "__typename": "IssueComment", + "id": "MDEyOklzc3VlQ29tbWVudDc2MTI2NDM5Mg==", + "author": { + "__typename": "User", + "login": "AlCalzone" + }, + "body": "Build error happens in MONGOOSE, not sure if that is related.", + "createdAt": "2021-01-15T23:58:14Z", + "reactions": { + "__typename": "ReactionConnection", + "nodes": [] + } + } + ] + }, + "files": { + "__typename": "PullRequestChangedFileConnection", + "totalCount": 13, + "nodes": [ + { + "__typename": "PullRequestChangedFile", + "path": "types/node/base.d.ts", + "additions": 4, + "deletions": 1 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/package.json", + "additions": 5, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/test/util.ts", + "additions": 32, + "deletions": 6 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.4/index.d.ts", + "additions": 1, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.4/util.promisify.d.ts", + "additions": 24, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.6/index.d.ts", + "additions": 1, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.9/base.d.ts", + "additions": 4, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.9/index.d.ts", + "additions": 8, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.9/node-tests.ts", + "additions": 3, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.9/tsconfig.json", + "additions": 25, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/ts3.9/tslint.json", + "additions": 6, + "deletions": 0 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/util.d.ts", + "additions": 1, + "deletions": 22 + }, + { + "__typename": "PullRequestChangedFile", + "path": "types/node/util.promisify.d.ts", + "additions": 49, + "deletions": 0 + } + ] + }, + "projectCards": { + "__typename": "ProjectCardConnection", + "nodes": [ + { + "__typename": "ProjectCard", + "id": "MDExOlByb2plY3RDYXJkNDk3NTYzNzU=", + "project": { + "__typename": "Project", + "id": "MDc6UHJvamVjdDM3NDExMDQ=", + "number": 5, + "name": "New Pull Request Status Board" + }, + "column": { + "__typename": "ProjectColumn", + "id": "MDEzOlByb2plY3RDb2x1bW43NTUyOTI0", + "name": "Needs Author Action" + } + } + ] + } + } + } + }, + "loading": false, + "networkStatus": 7 +} diff --git a/src/_tests/fixtures/49699/derived.json b/src/_tests/fixtures/49699/derived.json new file mode 100644 index 000000000..ca16bab8f --- /dev/null +++ b/src/_tests/fixtures/49699/derived.json @@ -0,0 +1,140 @@ +{ + "type": "info", + "now": "2021-01-18T21:07:50.342Z", + "pr_number": 49699, + "author": "AlCalzone", + "headCommitOid": "139c1679ecb5c2a475639582b7a312e4e7a1cde5", + "lastPushDate": "2021-01-15T23:24:04.000Z", + "lastActivityDate": "2021-01-15T23:58:14.000Z", + "maintainerBlessed": false, + "hasMergeConflict": false, + "isFirstContribution": false, + "popularityLevel": "Critical", + "pkgInfo": [ + { + "name": "node", + "kind": "edit", + "files": [ + { + "path": "types/node/base.d.ts", + "kind": "definition" + }, + { + "path": "types/node/package.json", + "kind": "package-meta-ok" + }, + { + "path": "types/node/test/util.ts", + "kind": "test" + }, + { + "path": "types/node/ts3.4/index.d.ts", + "kind": "definition" + }, + { + "path": "types/node/ts3.4/util.promisify.d.ts", + "kind": "definition" + }, + { + "path": "types/node/ts3.6/index.d.ts", + "kind": "definition" + }, + { + "path": "types/node/ts3.9/base.d.ts", + "kind": "definition" + }, + { + "path": "types/node/ts3.9/index.d.ts", + "kind": "definition" + }, + { + "path": "types/node/ts3.9/node-tests.ts", + "kind": "test" + }, + { + "path": "types/node/ts3.9/tsconfig.json", + "kind": "package-meta", + "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)" + }, + { + "path": "types/node/ts3.9/tslint.json", + "kind": "package-meta", + "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson)" + }, + { + "path": "types/node/util.d.ts", + "kind": "definition" + }, + { + "path": "types/node/util.promisify.d.ts", + "kind": "definition" + } + ], + "owners": [ + "Microsoft", + "DefinitelyTyped", + "jkomyno", + "a-tarasyuk", + "alvis", + "r3nya", + "btoueg", + "brunoscheufler", + "smac89", + "touffy", + "DeividasBakanas", + "eyqs", + "Flarna", + "Hannes-Magnusson-CK", + "KSXGitHub", + "hoo29", + "kjin", + "ajafff", + "islishude", + "mwiktorczyk", + "mohsen1", + "n-e", + "galkin", + "parambirs", + "eps1lon", + "SimonSchick", + "ThomasdenH", + "WilcoBakker", + "wwwy3y3", + "samuela", + "kuehlein", + "j-oliveras", + "bhongy", + "chyzwar", + "trivikr", + "nguymin4", + "yoursunny", + "qwelias", + "ExE-Boss", + "Ryan-Willpower", + "peterblazejewicz", + "addaleax", + "JasonHK", + "victorperin", + "ZYSzys" + ], + "addedOwners": [], + "deletedOwners": [], + "popularityLevel": "Critical" + } + ], + "reviews": [ + { + "type": "stale", + "reviewer": "ExE-Boss", + "date": "2021-01-15T07:34:48.000Z", + "abbrOid": "9ba9fdd" + }, + { + "type": "stale", + "reviewer": "rbuckton", + "date": "2020-12-08T01:35:34.000Z", + "abbrOid": "54b22fd" + } + ], + "ciResult": "pass" +} diff --git a/src/_tests/fixtures/49699/mutations.json b/src/_tests/fixtures/49699/mutations.json new file mode 100644 index 000000000..b80d9996d --- /dev/null +++ b/src/_tests/fixtures/49699/mutations.json @@ -0,0 +1,40 @@ +[ + { + "mutation": "mutation ($input: RemoveLabelsFromLabelableInput!) {\n removeLabelsFromLabelable(input: $input) {\n __typename\n }\n}\n", + "variables": { + "input": { + "labelIds": [ + "MDU6TGFiZWwyMDk2NzQzNjAw" + ], + "labelableId": "MDExOlB1bGxSZXF1ZXN0NTI0NjE3Njcz" + } + } + }, + { + "mutation": "mutation ($input: MoveProjectCardInput!) {\n moveProjectCard(input: $input) {\n __typename\n }\n}\n", + "variables": { + "input": { + "cardId": "MDExOlByb2plY3RDYXJkNDk3NTYzNzU=", + "columnId": "MDEzOlByb2plY3RDb2x1bW43NTUyOTIy" + } + } + }, + { + "mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n", + "variables": { + "input": { + "id": "MDEyOklzc3VlQ29tbWVudDczMTA5NDQ0NQ==", + "body": "@AlCalzone Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `node` [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n - Config files to check:\n - [`node/ts3.9/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files/139c1679ecb5c2a475639582b7a312e4e7a1cde5#diff-7d194a0ca3b6db7e32fc4eb435e98e205402ead7b75989483e1511b93b957a0b): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n - [`node/ts3.9/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files/139c1679ecb5c2a475639582b7a312e4e7a1cde5#diff-eb53a23489cce7c707fb8bdd6f8eda9ce727019af8d141241a5dbbc741f786c7): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + } + } + }, + { + "mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n", + "variables": { + "input": { + "subjectId": "MDExOlB1bGxSZXF1ZXN0NTI0NjE3Njcz", + "body": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + } + } + } +] diff --git a/src/_tests/fixtures/49699/result.json b/src/_tests/fixtures/49699/result.json new file mode 100644 index 000000000..af6ecaa8c --- /dev/null +++ b/src/_tests/fixtures/49699/result.json @@ -0,0 +1,27 @@ +{ + "pr_number": 49699, + "targetColumn": "Needs Maintainer Review", + "labels": [ + "Critical package", + "Check Config" + ], + "responseComments": [ + { + "tag": "welcome", + "status": "@AlCalzone Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `node` [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n - Config files to check:\n - [`node/ts3.9/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files/139c1679ecb5c2a475639582b7a312e4e7a1cde5#diff-7d194a0ca3b6db7e32fc4eb435e98e205402ead7b75989483e1511b93b957a0b): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n - [`node/ts3.9/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files/139c1679ecb5c2a475639582b7a312e4e7a1cde5#diff-eb53a23489cce7c707fb8bdd6f8eda9ce727019af8d141241a5dbbc741f786c7): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + }, + { + "tag": "pinging-reviewers", + "status": "🔔 @Microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @brunoscheufler @smac89 @touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." + }, + { + "tag": "stale-ping-fdfaf0-9ba9fdd", + "status": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" + } + ], + "shouldClose": false, + "shouldMerge": false, + "shouldUpdateLabels": true, + "shouldUpdateProjectColumn": true, + "shouldRemoveFromActiveColumns": false +} From 75440cb218b5fbd3a12db26978f9855cb08272d1 Mon Sep 17 00:00:00 2001 From: Jack Bates Date: Wed, 6 Jan 2021 07:26:58 -0700 Subject: [PATCH 4/5] New stale reviewers implies new reviewedAbbrOid --- src/comments.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/comments.ts b/src/comments.ts index 9c50bf45a..aa0fa1133 100644 --- a/src/comments.ts +++ b/src/comments.ts @@ -1,5 +1,3 @@ -import { sha256 } from "./util/util"; - // use `deletedWhenNotPresent` for comments that should be removed if not in the actions export const tagsToDeleteIfNotPosted: string[] = []; const deletedWhenNotPresent = (tag: string, f: (tag: string) => T) => { @@ -59,7 +57,7 @@ ${names.map(n => `${n}`).join(" ")} }); export const PingStaleReviewer = (reviewedAbbrOid: string, reviewers: string[]) => ({ - tag: `stale-ping-${sha256(reviewers.join("-")).substr(0, 6)}-${reviewedAbbrOid}`, + tag: `stale-ping-${reviewedAbbrOid}`, status: `@${reviewers.join(", @")} Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?` }); From b8021e774f55d6bba2b49119953e118aadc89d89 Mon Sep 17 00:00:00 2001 From: Jack Bates Date: Wed, 6 Jan 2021 07:32:43 -0700 Subject: [PATCH 5/5] Update snapshots --- src/_tests/fixtures/38979/_response.json | 10 +++++----- src/_tests/fixtures/38979/mutations.json | 6 +++--- src/_tests/fixtures/38979/result.json | 2 +- src/_tests/fixtures/43136/mutations.json | 2 +- src/_tests/fixtures/43136/result.json | 2 +- src/_tests/fixtures/43175/mutations.json | 2 +- src/_tests/fixtures/43175/result.json | 2 +- .../fixtures/43695-duplicate-comment/_response.json | 4 ++-- .../fixtures/43695-duplicate-comment/mutations.json | 2 +- .../fixtures/43695-duplicate-comment/result.json | 2 +- src/_tests/fixtures/43695-post-review/_response.json | 4 ++-- src/_tests/fixtures/44256/_response.json | 2 +- src/_tests/fixtures/44857/_response.json | 2 +- src/_tests/fixtures/44857/result.json | 2 +- src/_tests/fixtures/45890/_response.json | 2 +- src/_tests/fixtures/45999/_response.json | 2 +- src/_tests/fixtures/46120/_response.json | 2 +- src/_tests/fixtures/48652-merge-offer/_response.json | 4 ++-- src/_tests/fixtures/48652-merge-offer/mutations.json | 2 +- src/_tests/fixtures/48652-merge-offer/result.json | 2 +- src/_tests/fixtures/48652-prereq/_response.json | 4 ++-- src/_tests/fixtures/48652-prereq/mutations.json | 2 +- src/_tests/fixtures/48652-prereq/result.json | 2 +- .../_response.json | 4 ++-- .../fixtures/48652-retract-merge-offer/_response.json | 4 ++-- src/_tests/fixtures/49417/_response.json | 2 +- src/_tests/fixtures/49417/result.json | 2 +- src/_tests/fixtures/49575/mutations.json | 2 +- src/_tests/fixtures/49575/result.json | 2 +- src/_tests/fixtures/49699/_response.json | 6 +++--- src/_tests/fixtures/49699/mutations.json | 2 +- src/_tests/fixtures/49699/result.json | 2 +- 32 files changed, 46 insertions(+), 46 deletions(-) diff --git a/src/_tests/fixtures/38979/_response.json b/src/_tests/fixtures/38979/_response.json index 78150680b..e7ace9788 100644 --- a/src/_tests/fixtures/38979/_response.json +++ b/src/_tests/fixtures/38979/_response.json @@ -1915,7 +1915,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-05-12T04:12:42Z", "reactions": { "nodes": [], @@ -1929,7 +1929,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-05-12T04:12:43Z", "reactions": { "nodes": [], @@ -1943,7 +1943,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-05-12T04:12:43Z", "reactions": { "nodes": [], @@ -1957,7 +1957,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-05-12T04:12:44Z", "reactions": { "nodes": [], @@ -1971,7 +1971,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-05-12T04:12:45Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/38979/mutations.json b/src/_tests/fixtures/38979/mutations.json index 9145ed938..b0836aea6 100644 --- a/src/_tests/fixtures/38979/mutations.json +++ b/src/_tests/fixtures/38979/mutations.json @@ -51,11 +51,11 @@ } }, { - "mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n", + "mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n", "variables": { "input": { - "subjectId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", - "body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxNw==", + "body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } }, diff --git a/src/_tests/fixtures/38979/result.json b/src/_tests/fixtures/38979/result.json index c7321a0af..fb79949b2 100644 --- a/src/_tests/fixtures/38979/result.json +++ b/src/_tests/fixtures/38979/result.json @@ -16,7 +16,7 @@ "status": "🔔 @RReverser — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." }, { - "tag": "stale-ping-764528-3aba5ac", + "tag": "stale-ping-3aba5ac", "status": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" }, { diff --git a/src/_tests/fixtures/43136/mutations.json b/src/_tests/fixtures/43136/mutations.json index 0db4d907a..b5e2a7c58 100644 --- a/src/_tests/fixtures/43136/mutations.json +++ b/src/_tests/fixtures/43136/mutations.json @@ -54,7 +54,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4MzgyMzYy", - "body": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/43136/result.json b/src/_tests/fixtures/43136/result.json index 302d49296..1e9f51766 100644 --- a/src/_tests/fixtures/43136/result.json +++ b/src/_tests/fixtures/43136/result.json @@ -14,7 +14,7 @@ "status": "🔔 @RReverser — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43136/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." }, { - "tag": "stale-ping-f5a3ad-37d784d", + "tag": "stale-ping-37d784d", "status": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], diff --git a/src/_tests/fixtures/43175/mutations.json b/src/_tests/fixtures/43175/mutations.json index 4c849d34b..32ddd5a16 100644 --- a/src/_tests/fixtures/43175/mutations.json +++ b/src/_tests/fixtures/43175/mutations.json @@ -40,7 +40,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5NzQ2Mjcx", - "body": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/43175/result.json b/src/_tests/fixtures/43175/result.json index 0e84ff3b1..dc25a4957 100644 --- a/src/_tests/fixtures/43175/result.json +++ b/src/_tests/fixtures/43175/result.json @@ -19,7 +19,7 @@ "status": "🔔 @matthewkimber @otiai10 @couven92 @rreverser @sreimer15 @MatCarlson @ekinsol @tregagnon @echoabstract @spasma — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43175/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." }, { - "tag": "stale-ping-bbb366-767a750", + "tag": "stale-ping-767a750", "status": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], diff --git a/src/_tests/fixtures/43695-duplicate-comment/_response.json b/src/_tests/fixtures/43695-duplicate-comment/_response.json index b24e8a627..4cdaab480 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/_response.json +++ b/src/_tests/fixtures/43695-duplicate-comment/_response.json @@ -996,7 +996,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-04-15T16:26:50Z", "reactions": { "nodes": [], @@ -1010,7 +1010,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-04-15T16:26:50Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/43695-duplicate-comment/mutations.json b/src/_tests/fixtures/43695-duplicate-comment/mutations.json index 332167822..4b052c6aa 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/mutations.json +++ b/src/_tests/fixtures/43695-duplicate-comment/mutations.json @@ -54,7 +54,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", - "body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } }, diff --git a/src/_tests/fixtures/43695-duplicate-comment/result.json b/src/_tests/fixtures/43695-duplicate-comment/result.json index fc4d7d940..ba85dc17e 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/result.json +++ b/src/_tests/fixtures/43695-duplicate-comment/result.json @@ -15,7 +15,7 @@ "status": "🔔 @alexandercerutti — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" }, { - "tag": "stale-ping-61f252-68463fd", + "tag": "stale-ping-68463fd", "status": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" }, { diff --git a/src/_tests/fixtures/43695-post-review/_response.json b/src/_tests/fixtures/43695-post-review/_response.json index bd02ba7a5..12839d4e8 100644 --- a/src/_tests/fixtures/43695-post-review/_response.json +++ b/src/_tests/fixtures/43695-post-review/_response.json @@ -649,7 +649,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-04-15T16:26:50Z", "reactions": { "nodes": [], @@ -663,7 +663,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-04-15T16:26:50Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/44256/_response.json b/src/_tests/fixtures/44256/_response.json index 62e1727ab..894ea7145 100644 --- a/src/_tests/fixtures/44256/_response.json +++ b/src/_tests/fixtures/44256/_response.json @@ -448,7 +448,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@marcobeltempo Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@marcobeltempo Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-04-30T00:59:09Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/44857/_response.json b/src/_tests/fixtures/44857/_response.json index fcb733392..def91c167 100644 --- a/src/_tests/fixtures/44857/_response.json +++ b/src/_tests/fixtures/44857/_response.json @@ -757,7 +757,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-05-21T11:57:32Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/44857/result.json b/src/_tests/fixtures/44857/result.json index 3157277e4..fa3ac3682 100644 --- a/src/_tests/fixtures/44857/result.json +++ b/src/_tests/fixtures/44857/result.json @@ -16,7 +16,7 @@ "status": "🔔 @Microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @brunoscheufler @smac89 @touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44857/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." }, { - "tag": "stale-ping-37410c-b0cfd18", + "tag": "stale-ping-b0cfd18", "status": "@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" }, { diff --git a/src/_tests/fixtures/45890/_response.json b/src/_tests/fixtures/45890/_response.json index 0b77a4ed2..0f77cf7ca 100644 --- a/src/_tests/fixtures/45890/_response.json +++ b/src/_tests/fixtures/45890/_response.json @@ -310,7 +310,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-07-04T22:05:17Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/45999/_response.json b/src/_tests/fixtures/45999/_response.json index 6cdb71382..2a285c9b4 100644 --- a/src/_tests/fixtures/45999/_response.json +++ b/src/_tests/fixtures/45999/_response.json @@ -418,7 +418,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@eps1lon Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-07-10T13:31:50Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/46120/_response.json b/src/_tests/fixtures/46120/_response.json index 26e33728e..0659c4d5c 100644 --- a/src/_tests/fixtures/46120/_response.json +++ b/src/_tests/fixtures/46120/_response.json @@ -2078,7 +2078,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@jgonggrijp Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@jgonggrijp Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-07-17T05:47:20Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/48652-merge-offer/_response.json b/src/_tests/fixtures/48652-merge-offer/_response.json index b90d1b3b2..a4eb5fcd5 100644 --- a/src/_tests/fixtures/48652-merge-offer/_response.json +++ b/src/_tests/fixtures/48652-merge-offer/_response.json @@ -639,7 +639,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-10-13T08:30:42Z", "reactions": { "nodes": [], @@ -717,7 +717,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-11-03T02:25:17Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/48652-merge-offer/mutations.json b/src/_tests/fixtures/48652-merge-offer/mutations.json index 62cbcbc37..fac9ed50b 100644 --- a/src/_tests/fixtures/48652-merge-offer/mutations.json +++ b/src/_tests/fixtures/48652-merge-offer/mutations.json @@ -42,7 +42,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTAwNjg4ODM0", - "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/48652-merge-offer/result.json b/src/_tests/fixtures/48652-merge-offer/result.json index 70d10b6d0..469f22ec8 100644 --- a/src/_tests/fixtures/48652-merge-offer/result.json +++ b/src/_tests/fixtures/48652-merge-offer/result.json @@ -17,7 +17,7 @@ "status": "@mgol Everything looks good here. Great job! I am ready to merge this PR (at 06d8d67) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" }, { - "tag": "stale-ping-024242-fa21531", + "tag": "stale-ping-fa21531", "status": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], diff --git a/src/_tests/fixtures/48652-prereq/_response.json b/src/_tests/fixtures/48652-prereq/_response.json index e870ee314..72a5dbbc4 100644 --- a/src/_tests/fixtures/48652-prereq/_response.json +++ b/src/_tests/fixtures/48652-prereq/_response.json @@ -639,7 +639,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-10-13T08:30:42Z", "reactions": { "nodes": [], @@ -717,7 +717,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-11-03T02:25:17Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/48652-prereq/mutations.json b/src/_tests/fixtures/48652-prereq/mutations.json index dd0ab07f9..f0e132b90 100644 --- a/src/_tests/fixtures/48652-prereq/mutations.json +++ b/src/_tests/fixtures/48652-prereq/mutations.json @@ -42,7 +42,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTAwNjg4ODM0", - "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } }, diff --git a/src/_tests/fixtures/48652-prereq/result.json b/src/_tests/fixtures/48652-prereq/result.json index e5b53a949..1428c9fb8 100644 --- a/src/_tests/fixtures/48652-prereq/result.json +++ b/src/_tests/fixtures/48652-prereq/result.json @@ -17,7 +17,7 @@ "status": "@mgol Everything looks good here. Great job! I am ready to merge this PR (at 06d8d67) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" }, { - "tag": "stale-ping-024242-fa21531", + "tag": "stale-ping-fa21531", "status": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" }, { diff --git a/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/_response.json b/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/_response.json index b28710195..9caafca48 100644 --- a/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/_response.json +++ b/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/_response.json @@ -639,7 +639,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-10-13T08:30:42Z", "reactions": { "nodes": [], @@ -717,7 +717,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-11-03T02:25:17Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/48652-retract-merge-offer/_response.json b/src/_tests/fixtures/48652-retract-merge-offer/_response.json index ef2010860..90293b5ff 100644 --- a/src/_tests/fixtures/48652-retract-merge-offer/_response.json +++ b/src/_tests/fixtures/48652-retract-merge-offer/_response.json @@ -639,7 +639,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-10-13T08:30:42Z", "reactions": { "nodes": [], @@ -717,7 +717,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-11-03T02:25:17Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/49417/_response.json b/src/_tests/fixtures/49417/_response.json index 097194615..919b100af 100644 --- a/src/_tests/fixtures/49417/_response.json +++ b/src/_tests/fixtures/49417/_response.json @@ -666,7 +666,7 @@ "login": "typescript-bot", "__typename": "User" }, - "body": "@tuuling Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@tuuling Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-11-08T07:57:39Z", "reactions": { "nodes": [], diff --git a/src/_tests/fixtures/49417/result.json b/src/_tests/fixtures/49417/result.json index a1980e551..84f7f3aad 100644 --- a/src/_tests/fixtures/49417/result.json +++ b/src/_tests/fixtures/49417/result.json @@ -16,7 +16,7 @@ "status": "@Methuselah96 Everything looks good here. Great job! I am ready to merge this PR (at 2b9d098) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@gustavderdrache, @borisyankov, @tomwanzek, @denisname, @ledragon: you can do this too.)" }, { - "tag": "stale-ping-98aca3-525f75c", + "tag": "stale-ping-525f75c", "status": "@tuuling Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], diff --git a/src/_tests/fixtures/49575/mutations.json b/src/_tests/fixtures/49575/mutations.json index 2453ca2f2..02b08f4ef 100644 --- a/src/_tests/fixtures/49575/mutations.json +++ b/src/_tests/fixtures/49575/mutations.json @@ -44,7 +44,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTIxMTM3NjEy", - "body": "@elibarzilay, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@elibarzilay, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/49575/result.json b/src/_tests/fixtures/49575/result.json index df7d39235..1843e7492 100644 --- a/src/_tests/fixtures/49575/result.json +++ b/src/_tests/fixtures/49575/result.json @@ -15,7 +15,7 @@ "status": "🔔 @jablko — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" }, { - "tag": "stale-ping-d2e897-90ff51a", + "tag": "stale-ping-90ff51a", "status": "@elibarzilay, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], diff --git a/src/_tests/fixtures/49699/_response.json b/src/_tests/fixtures/49699/_response.json index 538607cbc..0c9c153d6 100644 --- a/src/_tests/fixtures/49699/_response.json +++ b/src/_tests/fixtures/49699/_response.json @@ -620,7 +620,7 @@ "__typename": "User", "login": "typescript-bot" }, - "body": "@ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-11-29T12:40:07Z", "reactions": { "__typename": "ReactionConnection", @@ -676,7 +676,7 @@ "__typename": "User", "login": "typescript-bot" }, - "body": "@rbuckton, @ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@rbuckton, @ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2020-12-08T17:41:30Z", "reactions": { "__typename": "ReactionConnection", @@ -768,7 +768,7 @@ "__typename": "User", "login": "typescript-bot" }, - "body": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "body": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", "createdAt": "2021-01-01T13:52:27Z", "reactions": { "__typename": "ReactionConnection", diff --git a/src/_tests/fixtures/49699/mutations.json b/src/_tests/fixtures/49699/mutations.json index b80d9996d..4c5ab086d 100644 --- a/src/_tests/fixtures/49699/mutations.json +++ b/src/_tests/fixtures/49699/mutations.json @@ -33,7 +33,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTI0NjE3Njcz", - "body": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/49699/result.json b/src/_tests/fixtures/49699/result.json index af6ecaa8c..46b62beb1 100644 --- a/src/_tests/fixtures/49699/result.json +++ b/src/_tests/fixtures/49699/result.json @@ -15,7 +15,7 @@ "status": "🔔 @Microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @brunoscheufler @smac89 @touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49699/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." }, { - "tag": "stale-ping-fdfaf0-9ba9fdd", + "tag": "stale-ping-9ba9fdd", "status": "@ExE-Boss, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ],