diff --git a/src/_tests/fixtures/38979/derived.json b/src/_tests/fixtures/38979/derived.json index 43f348811..be0ff8225 100644 --- a/src/_tests/fixtures/38979/derived.json +++ b/src/_tests/fixtures/38979/derived.json @@ -299,12 +299,16 @@ { "path": "types/es-abstract/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/es-abstract/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [ diff --git a/src/_tests/fixtures/38979/mutations.json b/src/_tests/fixtures/38979/mutations.json index 2dff4599c..643834bd3 100644 --- a/src/_tests/fixtures/38979/mutations.json +++ b/src/_tests/fixtures/38979/mutations.json @@ -36,7 +36,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==", - "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n - Config files to check:\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc), [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -66,5 +66,35 @@ "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "path": "types/es-abstract/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "path": "types/es-abstract/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "body": "@ExE-Boss I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/38979/result.json b/src/_tests/fixtures/38979/result.json index 99230d3bf..d6eb40ad9 100644 --- a/src/_tests/fixtures/38979/result.json +++ b/src/_tests/fixtures/38979/result.json @@ -10,7 +10,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n - Config files to check:\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc), [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", @@ -25,7 +25,16 @@ "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/es-abstract/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/es-abstract/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43136/result.json b/src/_tests/fixtures/43136/result.json index 01d1bdf1c..1dfd4a9aa 100644 --- a/src/_tests/fixtures/43136/result.json +++ b/src/_tests/fixtures/43136/result.json @@ -18,7 +18,7 @@ "status": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43144/result.json b/src/_tests/fixtures/43144/result.json index 3e3af8bdf..9602d7d7b 100644 --- a/src/_tests/fixtures/43144/result.json +++ b/src/_tests/fixtures/43144/result.json @@ -15,7 +15,7 @@ "status": "@jeffreymeng Everything looks good here. Great job! I am ready to merge this PR (at f1f5c4b) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@pocesar: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43151/derived.json b/src/_tests/fixtures/43151/derived.json index dbed97b8e..7498101a3 100644 --- a/src/_tests/fixtures/43151/derived.json +++ b/src/_tests/fixtures/43151/derived.json @@ -27,12 +27,16 @@ { "path": "types/gaze/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/gaze/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43151/mutations.json b/src/_tests/fixtures/43151/mutations.json index ad7e93f39..d52a37cb9 100644 --- a/src/_tests/fixtures/43151/mutations.json +++ b/src/_tests/fixtures/43151/mutations.json @@ -35,7 +35,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", - "body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n - Config files to check:\n - [`gaze/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-75a1852febb3e488c3c078da451a82e5a8609bd59ef44ddd0656bbb96150c1a0): couldn't fetch contents\n - [`gaze/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-a0512397f95f6b7994f9713c8ceb6144061e7cf0d81618a2a9a90cceda075f80): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -47,5 +47,35 @@ "body": "🔔 @adamzerella — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", + "path": "types/gaze/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", + "path": "types/gaze/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", + "body": "@adamzerella I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43151/result.json b/src/_tests/fixtures/43151/result.json index 524f00a31..f5d5cfd3d 100644 --- a/src/_tests/fixtures/43151/result.json +++ b/src/_tests/fixtures/43151/result.json @@ -8,14 +8,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n - Config files to check:\n - [`gaze/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-75a1852febb3e488c3c078da451a82e5a8609bd59ef44ddd0656bbb96150c1a0): couldn't fetch contents\n - [`gaze/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-a0512397f95f6b7994f9713c8ceb6144061e7cf0d81618a2a9a90cceda075f80): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", "status": "🔔 @adamzerella — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/gaze/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/gaze/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43160/result.json b/src/_tests/fixtures/43160/result.json index e6227f1ee..5e5a7133c 100644 --- a/src/_tests/fixtures/43160/result.json +++ b/src/_tests/fixtures/43160/result.json @@ -20,7 +20,7 @@ "status": "@rikkertkoppes The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/22c73c88cc9c09efd4c2998ec360607dd4c36c2e/checks?check_suite_id=731664306).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43175/result.json b/src/_tests/fixtures/43175/result.json index 2bc27c679..1daf37556 100644 --- a/src/_tests/fixtures/43175/result.json +++ b/src/_tests/fixtures/43175/result.json @@ -23,7 +23,7 @@ "status": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43235/result.json b/src/_tests/fixtures/43235/result.json index f4e4b9d40..b165bc470 100644 --- a/src/_tests/fixtures/43235/result.json +++ b/src/_tests/fixtures/43235/result.json @@ -12,7 +12,7 @@ "status": "🔔 @Esri @bsvensson — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43235/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43314/derived.json b/src/_tests/fixtures/43314/derived.json index e2604a37a..21246e78e 100644 --- a/src/_tests/fixtures/43314/derived.json +++ b/src/_tests/fixtures/43314/derived.json @@ -27,12 +27,16 @@ { "path": "types/carbon__icon-helpers/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/carbon__icon-helpers/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43314/mutations.json b/src/_tests/fixtures/43314/mutations.json index 59349da25..962b58354 100644 --- a/src/_tests/fixtures/43314/mutations.json +++ b/src/_tests/fixtures/43314/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYwMjIzODI3OQ==", - "body": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n - Config files to check:\n - [`carbon__icon-helpers/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-b85b46e7b1a183dc24eae51fb57ec188fd779236bfc818bea60bf6ac573d7be5): couldn't fetch contents\n - [`carbon__icon-helpers/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-9f7808ddcec9553672dd10ae54a269326e3346253364745d3f187e0b2b95b27b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -36,5 +36,35 @@ "body": "🔔 @metonym — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzkyMDM2NjA4", + "path": "types/carbon__icon-helpers/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzkyMDM2NjA4", + "path": "types/carbon__icon-helpers/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzkyMDM2NjA4", + "body": "@metonym I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43314/result.json b/src/_tests/fixtures/43314/result.json index c7d5eac9d..0535cb2e0 100644 --- a/src/_tests/fixtures/43314/result.json +++ b/src/_tests/fixtures/43314/result.json @@ -8,14 +8,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n - Config files to check:\n - [`carbon__icon-helpers/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-b85b46e7b1a183dc24eae51fb57ec188fd779236bfc818bea60bf6ac573d7be5): couldn't fetch contents\n - [`carbon__icon-helpers/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-9f7808ddcec9553672dd10ae54a269326e3346253364745d3f187e0b2b95b27b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", "status": "🔔 @metonym — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/carbon__icon-helpers/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/carbon__icon-helpers/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43695-duplicate-comment/derived.json b/src/_tests/fixtures/43695-duplicate-comment/derived.json index d9abd3aa2..322c0f556 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/derived.json +++ b/src/_tests/fixtures/43695-duplicate-comment/derived.json @@ -27,12 +27,16 @@ { "path": "types/accedo__accedo-one/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/accedo__accedo-one/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43695-duplicate-comment/mutations.json b/src/_tests/fixtures/43695-duplicate-comment/mutations.json index a80a36d54..f77fa768e 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/mutations.json +++ b/src/_tests/fixtures/43695-duplicate-comment/mutations.json @@ -35,7 +35,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -65,5 +65,35 @@ "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping «anyone?».)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "body": "@alexandercerutti I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43695-duplicate-comment/result.json b/src/_tests/fixtures/43695-duplicate-comment/result.json index 669980f0b..28709e769 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/result.json +++ b/src/_tests/fixtures/43695-duplicate-comment/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", @@ -24,7 +24,16 @@ "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping «anyone?».)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43695-post-review/derived.json b/src/_tests/fixtures/43695-post-review/derived.json index b0c3caeaf..1ed9b0461 100644 --- a/src/_tests/fixtures/43695-post-review/derived.json +++ b/src/_tests/fixtures/43695-post-review/derived.json @@ -27,12 +27,16 @@ { "path": "types/accedo__accedo-one/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/accedo__accedo-one/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43695-post-review/mutations.json b/src/_tests/fixtures/43695-post-review/mutations.json index cd15e8e79..c5ab0eafc 100644 --- a/src/_tests/fixtures/43695-post-review/mutations.json +++ b/src/_tests/fixtures/43695-post-review/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -36,5 +36,35 @@ "body": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "body": "@alexandercerutti I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43695-post-review/result.json b/src/_tests/fixtures/43695-post-review/result.json index 23c5fcef6..f4c23f2c6 100644 --- a/src/_tests/fixtures/43695-post-review/result.json +++ b/src/_tests/fixtures/43695-post-review/result.json @@ -9,14 +9,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "reviewer-complaint-90c94f9", "status": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43695/derived.json b/src/_tests/fixtures/43695/derived.json index c4e340d10..efd8f3a66 100644 --- a/src/_tests/fixtures/43695/derived.json +++ b/src/_tests/fixtures/43695/derived.json @@ -27,12 +27,16 @@ { "path": "types/accedo__accedo-one/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/accedo__accedo-one/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/43695/mutations.json b/src/_tests/fixtures/43695/mutations.json index baf7801c1..57a8aa1e8 100644 --- a/src/_tests/fixtures/43695/mutations.json +++ b/src/_tests/fixtures/43695/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -36,5 +36,35 @@ "body": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", + "body": "@alexandercerutti I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/43695/result.json b/src/_tests/fixtures/43695/result.json index 772632029..2ac26f0e5 100644 --- a/src/_tests/fixtures/43695/result.json +++ b/src/_tests/fixtures/43695/result.json @@ -9,14 +9,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "reviewer-complaint-a5285cd", "status": "@alexandercerutti One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/accedo__accedo-one/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/accedo__accedo-one/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/43960-post-close/result.json b/src/_tests/fixtures/43960-post-close/result.json index 295c8db3f..625c6ab75 100644 --- a/src/_tests/fixtures/43960-post-close/result.json +++ b/src/_tests/fixtures/43960-post-close/result.json @@ -2,7 +2,7 @@ "pr_number": 43960, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/43960/result.json b/src/_tests/fixtures/43960/result.json index 2ecddafdc..3787fddb4 100644 --- a/src/_tests/fixtures/43960/result.json +++ b/src/_tests/fixtures/43960/result.json @@ -15,7 +15,7 @@ "status": "@aaltepet One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44105/result.json b/src/_tests/fixtures/44105/result.json index 9a9c73cd0..4e4495b28 100644 --- a/src/_tests/fixtures/44105/result.json +++ b/src/_tests/fixtures/44105/result.json @@ -2,7 +2,7 @@ "pr_number": 44105, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44256/result.json b/src/_tests/fixtures/44256/result.json index 69d95b0ac..762124ffe 100644 --- a/src/_tests/fixtures/44256/result.json +++ b/src/_tests/fixtures/44256/result.json @@ -2,7 +2,7 @@ "pr_number": 44256, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44267/result.json b/src/_tests/fixtures/44267/result.json index 7b886f461..b4172a108 100644 --- a/src/_tests/fixtures/44267/result.json +++ b/src/_tests/fixtures/44267/result.json @@ -15,7 +15,7 @@ "status": "@ErikMartensson Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `intercom-client` [on npm](https://www.npmjs.com/package/intercom-client), [on unpkg](https://unpkg.com/browse/intercom-client@latest/)\n - owner-approval: @malithrw\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44282/result.json b/src/_tests/fixtures/44282/result.json index 62dadebf2..e3f335100 100644 --- a/src/_tests/fixtures/44282/result.json +++ b/src/_tests/fixtures/44282/result.json @@ -15,7 +15,7 @@ "status": "🔔 @fishcharlie — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44282/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44288/result.json b/src/_tests/fixtures/44288/result.json index 703d8b431..84d059024 100644 --- a/src/_tests/fixtures/44288/result.json +++ b/src/_tests/fixtures/44288/result.json @@ -12,7 +12,7 @@ "status": "🔔 @gosticks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44288/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44290/result.json b/src/_tests/fixtures/44290/result.json index 1409d8f4f..25712ee51 100644 --- a/src/_tests/fixtures/44290/result.json +++ b/src/_tests/fixtures/44290/result.json @@ -2,7 +2,7 @@ "pr_number": 44290, "labels": [], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44299-with-files/derived.json b/src/_tests/fixtures/44299-with-files/derived.json index 88bfd708e..af5f2b919 100644 --- a/src/_tests/fixtures/44299-with-files/derived.json +++ b/src/_tests/fixtures/44299-with-files/derived.json @@ -27,12 +27,16 @@ { "path": "types/hcaptcha__vue-hcaptcha/package.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tslint.json", diff --git a/src/_tests/fixtures/44299-with-files/mutations.json b/src/_tests/fixtures/44299-with-files/mutations.json index 316908073..945460609 100644 --- a/src/_tests/fixtures/44299-with-files/mutations.json +++ b/src/_tests/fixtures/44299-with-files/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMDcwMjk5OQ==", - "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -36,5 +36,35 @@ "body": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "body": "@geopic I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/44299-with-files/result.json b/src/_tests/fixtures/44299-with-files/result.json index e1dc68ff0..05c6cd6db 100644 --- a/src/_tests/fixtures/44299-with-files/result.json +++ b/src/_tests/fixtures/44299-with-files/result.json @@ -8,14 +8,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", "status": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44299/derived.json b/src/_tests/fixtures/44299/derived.json index 1bad25eab..9543bd69a 100644 --- a/src/_tests/fixtures/44299/derived.json +++ b/src/_tests/fixtures/44299/derived.json @@ -27,17 +27,23 @@ { "path": "types/hcaptcha__vue-hcaptcha/package.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/hcaptcha__vue-hcaptcha/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/44299/mutations.json b/src/_tests/fixtures/44299/mutations.json index fa7a56424..f5df9de4b 100644 --- a/src/_tests/fixtures/44299/mutations.json +++ b/src/_tests/fixtures/44299/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMDcwMjk5OQ==", - "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-c441c94ec5219d4722929ccb738301643b5eef17a151184505f387fdbec13408): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -36,5 +36,45 @@ "body": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "path": "types/hcaptcha__vue-hcaptcha/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMjE2Nzgz", + "body": "@geopic I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/44299/result.json b/src/_tests/fixtures/44299/result.json index a5652e015..6fdc00085 100644 --- a/src/_tests/fixtures/44299/result.json +++ b/src/_tests/fixtures/44299/result.json @@ -8,14 +8,27 @@ "responseComments": [ { "tag": "welcome", - "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-c441c94ec5219d4722929ccb738301643b5eef17a151184505f387fdbec13408): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", "status": "🔔 @geopic — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/hcaptcha__vue-hcaptcha/package.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/hcaptcha__vue-hcaptcha/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/hcaptcha__vue-hcaptcha/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44316/derived.json b/src/_tests/fixtures/44316/derived.json index 760ac7528..25c8a58f7 100644 --- a/src/_tests/fixtures/44316/derived.json +++ b/src/_tests/fixtures/44316/derived.json @@ -23,7 +23,9 @@ { "path": "types/vimeo/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/vimeo/vimeo-tests.ts", diff --git a/src/_tests/fixtures/44316/mutations.json b/src/_tests/fixtures/44316/mutations.json index a349bdd7e..276081f2b 100644 --- a/src/_tests/fixtures/44316/mutations.json +++ b/src/_tests/fixtures/44316/mutations.json @@ -13,7 +13,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMDg5MzUyMA==", - "body": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n - Config files to check:\n - [`vimeo/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files/55357f7d60d059b5c84a23bd92854276a8f9a419#diff-2b7f4c3a0b1cb5a892e62dacc9c3d0caa20601673c8d00380be51ba66708f2d1): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -25,5 +25,25 @@ "body": "🔔 @mattleff — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMzk4NzAw", + "path": "types/vimeo/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEwMzk4NzAw", + "body": "@mattleff I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/44316/result.json b/src/_tests/fixtures/44316/result.json index b4b687520..8999192ac 100644 --- a/src/_tests/fixtures/44316/result.json +++ b/src/_tests/fixtures/44316/result.json @@ -9,14 +9,19 @@ "responseComments": [ { "tag": "welcome", - "status": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n - Config files to check:\n - [`vimeo/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files/55357f7d60d059b5c84a23bd92854276a8f9a419#diff-2b7f4c3a0b1cb5a892e62dacc9c3d0caa20601673c8d00380be51ba66708f2d1): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", "status": "🔔 @mattleff — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/vimeo/tsconfig.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44343-pending-travis/result.json b/src/_tests/fixtures/44343-pending-travis/result.json index 944f8e0fe..653a01822 100644 --- a/src/_tests/fixtures/44343-pending-travis/result.json +++ b/src/_tests/fixtures/44343-pending-travis/result.json @@ -12,7 +12,7 @@ "status": "🔔 @joeriks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44343/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44343-pre-travis/result.json b/src/_tests/fixtures/44343-pre-travis/result.json index 944f8e0fe..653a01822 100644 --- a/src/_tests/fixtures/44343-pre-travis/result.json +++ b/src/_tests/fixtures/44343-pre-travis/result.json @@ -12,7 +12,7 @@ "status": "🔔 @joeriks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44343/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": false, diff --git a/src/_tests/fixtures/44343/result.json b/src/_tests/fixtures/44343/result.json index 5631d9dad..ad69ee679 100644 --- a/src/_tests/fixtures/44343/result.json +++ b/src/_tests/fixtures/44343/result.json @@ -12,7 +12,7 @@ "status": "🔔 @joeriks — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44343/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44402/result.json b/src/_tests/fixtures/44402/result.json index d087d2f90..5b9756d06 100644 --- a/src/_tests/fixtures/44402/result.json +++ b/src/_tests/fixtures/44402/result.json @@ -8,7 +8,7 @@ "Edits Infrastructure" ], "responseComments": [], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44411/derived.json b/src/_tests/fixtures/44411/derived.json index d1d2c9d21..11a1920e8 100644 --- a/src/_tests/fixtures/44411/derived.json +++ b/src/_tests/fixtures/44411/derived.json @@ -35,12 +35,16 @@ { "path": "types/jest-image-snapshot/v2/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/jest-image-snapshot/v2/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [ diff --git a/src/_tests/fixtures/44411/mutations.json b/src/_tests/fixtures/44411/mutations.json index efd6554e4..cf720b026 100644 --- a/src/_tests/fixtures/44411/mutations.json +++ b/src/_tests/fixtures/44411/mutations.json @@ -24,7 +24,37 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjMzMzI3Ng==", - "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n - Config files to check:\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc), [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMDc3MDI1", + "path": "types/jest-image-snapshot/v2/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMDc3MDI1", + "path": "types/jest-image-snapshot/v2/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMDc3MDI1", + "body": "@peterblazejewicz I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" } } } diff --git a/src/_tests/fixtures/44411/result.json b/src/_tests/fixtures/44411/result.json index 887c7087e..d514e8bf6 100644 --- a/src/_tests/fixtures/44411/result.json +++ b/src/_tests/fixtures/44411/result.json @@ -8,14 +8,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n - Config files to check:\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc), [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", "status": "🔔 @dawnmist @erbridge — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [ + { + "path": "types/jest-image-snapshot/v2/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/jest-image-snapshot/v2/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json index 82d2c6313..3ca9e8359 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/derived.json @@ -19,7 +19,9 @@ { "path": "types/openfin/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/_v2/api/application/application.d.ts", @@ -172,12 +174,16 @@ { "path": "types/openfin/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/_v2/api/application/application.d.ts", diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json index 4d0f3839c..060a03a4d 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json @@ -13,7 +13,47 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjUyNzAxNQ==", - "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "body": "@tomer-openfin I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" } } } diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json index a5036503d..13fabfeb5 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json @@ -8,14 +8,27 @@ "responseComments": [ { "tag": "welcome", - "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", "status": "🔔 @chrisbarker @rdepena @whyn07m3 @licui3936 — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [ + { + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44424-2-after-travis-second/derived.json b/src/_tests/fixtures/44424-2-after-travis-second/derived.json index 803cb9ea7..372b0d3f4 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/derived.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/derived.json @@ -19,7 +19,9 @@ { "path": "types/openfin/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/_v2/api/application/application.d.ts", @@ -172,12 +174,16 @@ { "path": "types/openfin/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/OTHER_FILES.txt", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/openfin/v49/_v2/api/application/application.d.ts", diff --git a/src/_tests/fixtures/44424-2-after-travis-second/mutations.json b/src/_tests/fixtures/44424-2-after-travis-second/mutations.json index 6b1b6e7d3..a78802cc5 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/mutations.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/mutations.json @@ -4,7 +4,47 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjUyNzAxNQ==", - "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDEyMjY1MDE2", + "body": "@tomer-openfin I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" } } } diff --git a/src/_tests/fixtures/44424-2-after-travis-second/result.json b/src/_tests/fixtures/44424-2-after-travis-second/result.json index be6843999..25388dbc5 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/result.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/result.json @@ -8,14 +8,27 @@ "responseComments": [ { "tag": "welcome", - "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4), [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03), [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", "status": "🔔 @chrisbarker @rdepena @whyn07m3 @licui3936 — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [ + { + "path": "types/openfin/OTHER_FILES.txt", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/tslint.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/openfin/v49/OTHER_FILES.txt", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44437/result.json b/src/_tests/fixtures/44437/result.json index 667089f09..0fe09349d 100644 --- a/src/_tests/fixtures/44437/result.json +++ b/src/_tests/fixtures/44437/result.json @@ -17,7 +17,7 @@ "status": "@johnnyreilly Everything looks good here. Great job! I am ready to merge this PR (at eb92456) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@Berkays, @unindented, @kamontat, @theweirdone, @whoaa512: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44439/result.json b/src/_tests/fixtures/44439/result.json index fcc51023e..f3befe363 100644 --- a/src/_tests/fixtures/44439/result.json +++ b/src/_tests/fixtures/44439/result.json @@ -15,7 +15,7 @@ "status": "🔔 @lith-light-g — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44439/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44631/result.json b/src/_tests/fixtures/44631/result.json index 6c05c3611..a07ce3e63 100644 --- a/src/_tests/fixtures/44631/result.json +++ b/src/_tests/fixtures/44631/result.json @@ -15,7 +15,7 @@ "status": "@mAAdhaTTah Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44857/result.json b/src/_tests/fixtures/44857/result.json index b92ce2901..ed3f59b83 100644 --- a/src/_tests/fixtures/44857/result.json +++ b/src/_tests/fixtures/44857/result.json @@ -24,7 +24,7 @@ "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @Microsoft, @DefinitelyTyped, @jkomyno, @a-tarasyuk, @alvis, @r3nya, @btoueg, @brunoscheufler, @smac89, @touffy, @DeividasBakanas, @eyqs, @Flarna, @Hannes-Magnusson-CK, @KSXGitHub, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @j-oliveras, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @Ryan-Willpower, @peterblazejewicz, @addaleax, @JasonHK.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-14days/result.json b/src/_tests/fixtures/44989-14days/result.json index 1e497ffe1..1115acbc8 100644 --- a/src/_tests/fixtures/44989-14days/result.json +++ b/src/_tests/fixtures/44989-14days/result.json @@ -21,7 +21,7 @@ "status": "Re-ping @petr-motejlek / @TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii:\n\nThis PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it in three weeks if this doesn't happen.\n\n(Note that posting a comment will restart the month-timer again, so avoid doing that if you don't want me to nag you again... or you can just close it or turn it into a draft now.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-32days/result.json b/src/_tests/fixtures/44989-32days/result.json index dece6cef3..cb5b6a973 100644 --- a/src/_tests/fixtures/44989-32days/result.json +++ b/src/_tests/fixtures/44989-32days/result.json @@ -21,7 +21,7 @@ "status": "After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it." } ], - "suggestions": [], + "explanations": [], "shouldClose": true, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-3days/result.json b/src/_tests/fixtures/44989-3days/result.json index 1a661ca65..b8f6acc83 100644 --- a/src/_tests/fixtures/44989-3days/result.json +++ b/src/_tests/fixtures/44989-3days/result.json @@ -16,7 +16,7 @@ "status": "@petr-motejlek Everything looks good here. Great job! I am ready to merge this PR (at 9ca6086) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/44989-7days/result.json b/src/_tests/fixtures/44989-7days/result.json index 42e2d6df4..22ad366db 100644 --- a/src/_tests/fixtures/44989-7days/result.json +++ b/src/_tests/fixtures/44989-7days/result.json @@ -16,7 +16,7 @@ "status": "@petr-motejlek Everything looks good here. Great job! I am ready to merge this PR (at 9ca6086) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45137/result.json b/src/_tests/fixtures/45137/result.json index 0d32cad87..0b3d00f4c 100644 --- a/src/_tests/fixtures/45137/result.json +++ b/src/_tests/fixtures/45137/result.json @@ -18,7 +18,7 @@ "status": "@lirbank Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mongodb` [on npm](https://www.npmjs.com/package/mongodb), [on unpkg](https://unpkg.com/browse/mongodb@latest/) (author is owner)\n - owner-approval: @LinusU\n - 1 removed owner: ✎@lirbank\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45627/result.json b/src/_tests/fixtures/45627/result.json index 201ecad3e..5b2ad8ef6 100644 --- a/src/_tests/fixtures/45627/result.json +++ b/src/_tests/fixtures/45627/result.json @@ -27,7 +27,7 @@ "status": "After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it." } ], - "suggestions": [], + "explanations": [], "shouldClose": true, "shouldMerge": true, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45836/result.json b/src/_tests/fixtures/45836/result.json index 858a8b5a4..765335a63 100644 --- a/src/_tests/fixtures/45836/result.json +++ b/src/_tests/fixtures/45836/result.json @@ -16,7 +16,7 @@ "status": ":passport_control: Hi @mmorearty,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45884/result.json b/src/_tests/fixtures/45884/result.json index 58fab9a92..798d43598 100644 --- a/src/_tests/fixtures/45884/result.json +++ b/src/_tests/fixtures/45884/result.json @@ -20,7 +20,7 @@ "status": "@sgratzl Everything looks good here. Great job! I am ready to merge this PR (at 1dcf44a) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@phreed, @wy193777, @ypconstante, @janniclas, @cerberuser, @gsbelarus, @peterjferrarotto, @spaxe, @appleparan, @Veckodag: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45888/result.json b/src/_tests/fixtures/45888/result.json index f95671679..c9df1b6bf 100644 --- a/src/_tests/fixtures/45888/result.json +++ b/src/_tests/fixtures/45888/result.json @@ -19,7 +19,7 @@ "status": "🔔 @sampsonjoliver @andipaetzold @JiriBalcar @CodeLenny — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45888/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45890/derived.json b/src/_tests/fixtures/45890/derived.json index 628a96201..bb24fa658 100644 --- a/src/_tests/fixtures/45890/derived.json +++ b/src/_tests/fixtures/45890/derived.json @@ -27,12 +27,16 @@ { "path": "types/greek-utils/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/greek-utils/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [], diff --git a/src/_tests/fixtures/45890/mutations.json b/src/_tests/fixtures/45890/mutations.json index 13e5b8e67..b98476496 100644 --- a/src/_tests/fixtures/45890/mutations.json +++ b/src/_tests/fixtures/45890/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDY1MzgxMDQ1NA==", - "body": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n - Config files to check:\n - [`greek-utils/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-8580e62e675e57ce0e41bc84092e01b449be703b016d9bf5378c75fb02e5adc3): couldn't fetch contents\n - [`greek-utils/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-1beeab429f4237a976a64069a8a9b4eee96b609637784407d8975647ca13c8a5): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -36,5 +36,35 @@ "body": "🔔 @dimkirt — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ0MzI2NjIy", + "path": "types/greek-utils/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ0MzI2NjIy", + "path": "types/greek-utils/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ0MzI2NjIy", + "body": "@dimkirt I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/45890/result.json b/src/_tests/fixtures/45890/result.json index 367fecfa1..f2b83c781 100644 --- a/src/_tests/fixtures/45890/result.json +++ b/src/_tests/fixtures/45890/result.json @@ -9,14 +9,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n - Config files to check:\n - [`greek-utils/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-8580e62e675e57ce0e41bc84092e01b449be703b016d9bf5378c75fb02e5adc3): couldn't fetch contents\n - [`greek-utils/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-1beeab429f4237a976a64069a8a9b4eee96b609637784407d8975647ca13c8a5): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", "status": "🔔 @dimkirt — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/greek-utils/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/greek-utils/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45946/derived.json b/src/_tests/fixtures/45946/derived.json index ebad7c97e..ddec99c5c 100644 --- a/src/_tests/fixtures/45946/derived.json +++ b/src/_tests/fixtures/45946/derived.json @@ -41,12 +41,16 @@ { "path": "types/asynciterator/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/asynciterator/tslint.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } } ], "owners": [ diff --git a/src/_tests/fixtures/45946/mutations.json b/src/_tests/fixtures/45946/mutations.json index 2218376cb..0925fb9ba 100644 --- a/src/_tests/fixtures/45946/mutations.json +++ b/src/_tests/fixtures/45946/mutations.json @@ -35,7 +35,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDY1NTMxNzQwNQ==", - "body": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n - Config files to check:\n - [`asynciterator/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-be20504719e5f1036e683d4ddaab8bf2b1c609ea12aa30786497768f575095ad): couldn't fetch contents\n - [`asynciterator/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-e3a26c4ba64c5ed587d2b797151728488e274f4be74c1558722a8a32cf7a31c9): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -47,5 +47,35 @@ "body": "🔔 @rubensworks — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ2MDIxMjkw", + "path": "types/asynciterator/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ2MDIxMjkw", + "path": "types/asynciterator/tslint.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ2MDIxMjkw", + "body": "@rubensworks I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/45946/result.json b/src/_tests/fixtures/45946/result.json index f6dccca82..016a4f9ee 100644 --- a/src/_tests/fixtures/45946/result.json +++ b/src/_tests/fixtures/45946/result.json @@ -9,14 +9,23 @@ "responseComments": [ { "tag": "welcome", - "status": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n - Config files to check:\n - [`asynciterator/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-be20504719e5f1036e683d4ddaab8bf2b1c609ea12aa30786497768f575095ad): couldn't fetch contents\n - [`asynciterator/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-e3a26c4ba64c5ed587d2b797151728488e274f4be74c1558722a8a32cf7a31c9): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", "status": "🔔 @rubensworks — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/asynciterator/tsconfig.json", + "body": "couldn't fetch contents" + }, + { + "path": "types/asynciterator/tslint.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45982/result.json b/src/_tests/fixtures/45982/result.json index 7be9ba77a..be4017f14 100644 --- a/src/_tests/fixtures/45982/result.json +++ b/src/_tests/fixtures/45982/result.json @@ -10,7 +10,7 @@ "status": "@dasa — There was an error that prevented me from properly processing this PR:\n\n error parsing owners: At 1:1 : Expected /\\/\\/ Type definitions for (non-npm package )?/" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/45999/result.json b/src/_tests/fixtures/45999/result.json index d7e7f11cc..ca6a0b0c5 100644 --- a/src/_tests/fixtures/45999/result.json +++ b/src/_tests/fixtures/45999/result.json @@ -16,7 +16,7 @@ "status": "@alexpyzhianov Everything looks good here. Great job! I am ready to merge this PR (at 381a2a9) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@johnnyreilly, @bbenezech, @pzavolinsky, @digiguru, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @eps1lon, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46008/result.json b/src/_tests/fixtures/46008/result.json index d625a2573..a82800a96 100644 --- a/src/_tests/fixtures/46008/result.json +++ b/src/_tests/fixtures/46008/result.json @@ -20,7 +20,7 @@ "status": "@risingBirdSong Everything looks good here. Great job! I am ready to merge this PR (at 3e19cb9) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@p5-types, @Zalastax: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46019/derived.json b/src/_tests/fixtures/46019/derived.json index cd3e5088e..21e84b13f 100644 --- a/src/_tests/fixtures/46019/derived.json +++ b/src/_tests/fixtures/46019/derived.json @@ -28,7 +28,9 @@ { "path": "types/is-secret/tsconfig.json", "kind": "package-meta", - "suspect": "couldn't fetch contents" + "suspect": { + "body": "couldn't fetch contents" + } }, { "path": "types/is-secret/tslint.json", diff --git a/src/_tests/fixtures/46019/mutations.json b/src/_tests/fixtures/46019/mutations.json index ae94ff4ac..9e51fd80e 100644 --- a/src/_tests/fixtures/46019/mutations.json +++ b/src/_tests/fixtures/46019/mutations.json @@ -15,7 +15,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDY1NzEyNjg3Mg==", - "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n - Config files to check:\n - [`is-secret/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46019/files/ceca9f768be945932c692d7dd48fa14b6ff38096#diff-d5cb28ac6bc4842869aa49fee16653bddadedda2f36bf881ddd3ed7cdc6cce6b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -27,5 +27,25 @@ "body": "@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at ceca9f7) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n" } } + }, + { + "query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ3ODE1MDgx", + "path": "types/is-secret/tsconfig.json", + "body": "couldn't fetch contents" + } + } + }, + { + "query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }", + "variables": { + "input": { + "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NDQ3ODE1MDgx", + "body": "@peterblazejewicz I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!", + "event": "COMMENT" + } + } } ] diff --git a/src/_tests/fixtures/46019/result.json b/src/_tests/fixtures/46019/result.json index 80dc662cc..562c69e84 100644 --- a/src/_tests/fixtures/46019/result.json +++ b/src/_tests/fixtures/46019/result.json @@ -10,14 +10,19 @@ "responseComments": [ { "tag": "welcome", - "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n - Config files to check:\n - [`is-secret/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46019/files/ceca9f768be945932c692d7dd48fa14b6ff38096#diff-d5cb28ac6bc4842869aa49fee16653bddadedda2f36bf881ddd3ed7cdc6cce6b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", "status": "@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at ceca9f7) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" } ], - "suggestions": [], + "explanations": [ + { + "path": "types/is-secret/tsconfig.json", + "body": "couldn't fetch contents" + } + ], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46120/result.json b/src/_tests/fixtures/46120/result.json index 28a82d2ea..ee05f3d39 100644 --- a/src/_tests/fixtures/46120/result.json +++ b/src/_tests/fixtures/46120/result.json @@ -21,7 +21,7 @@ "status": ":passport_control: Hi @reubenrybnik,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46191/result.json b/src/_tests/fixtures/46191/result.json index 73ff64f60..814a08d69 100644 --- a/src/_tests/fixtures/46191/result.json +++ b/src/_tests/fixtures/46191/result.json @@ -24,7 +24,7 @@ "status": "@jordanoverbye The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3cc81dbde57a1b0eda6f69f539fa49b8d420adff/checks?check_suite_id=938074936).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46196/result.json b/src/_tests/fixtures/46196/result.json index 4528e5c4e..d6153fb44 100644 --- a/src/_tests/fixtures/46196/result.json +++ b/src/_tests/fixtures/46196/result.json @@ -12,7 +12,7 @@ "status": "🔔 @HeeL — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46196/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46279/result.json b/src/_tests/fixtures/46279/result.json index 5f99b598b..829370c08 100644 --- a/src/_tests/fixtures/46279/result.json +++ b/src/_tests/fixtures/46279/result.json @@ -20,7 +20,7 @@ "status": "🔔 @pzingg — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46279/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46804/result.json b/src/_tests/fixtures/46804/result.json index 0d964733c..2a98f0514 100644 --- a/src/_tests/fixtures/46804/result.json +++ b/src/_tests/fixtures/46804/result.json @@ -18,7 +18,7 @@ "status": "🔔 @hrngoode @adina-todoran @BreadAndRoses95 — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46804/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/46879/result.json b/src/_tests/fixtures/46879/result.json index 81a657f98..baa937e22 100644 --- a/src/_tests/fixtures/46879/result.json +++ b/src/_tests/fixtures/46879/result.json @@ -14,7 +14,7 @@ "status": "🔔 @sudoplz @GiedriusGrabauskas — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46879/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017-blessed-and-one-owner/result.json b/src/_tests/fixtures/47017-blessed-and-one-owner/result.json index 9a0170069..11b309c8b 100644 --- a/src/_tests/fixtures/47017-blessed-and-one-owner/result.json +++ b/src/_tests/fixtures/47017-blessed-and-one-owner/result.json @@ -11,7 +11,7 @@ "status": "@mastermatt Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 2 packages in this PR\n\n* `express-serve-static-core` [on npm](https://www.npmjs.com/package/express-serve-static-core), [on unpkg](https://unpkg.com/browse/express-serve-static-core@latest/)\n - owner-approval: @dwrss\n* `express` [on npm](https://www.npmjs.com/package/express), [on unpkg](https://unpkg.com/browse/express@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ All owners or a DT maintainer needs to approve changes which affect more than one package\n - ✅ express-serve-static-core\n - ❌ express\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017-blessed-and-two-owner/result.json b/src/_tests/fixtures/47017-blessed-and-two-owner/result.json index 01cdff040..88b7abf88 100644 --- a/src/_tests/fixtures/47017-blessed-and-two-owner/result.json +++ b/src/_tests/fixtures/47017-blessed-and-two-owner/result.json @@ -17,7 +17,7 @@ "status": "@mastermatt Everything looks good here. Great job! I am ready to merge this PR (at dbe687d) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017-blessed/result.json b/src/_tests/fixtures/47017-blessed/result.json index 4d86e07f9..25d285914 100644 --- a/src/_tests/fixtures/47017-blessed/result.json +++ b/src/_tests/fixtures/47017-blessed/result.json @@ -15,7 +15,7 @@ "status": "🔔 @borisyankov @19majkel94 @kacepe @micksatana @samijaber @aereal @JoseLion @dwrss @andoshin11 @CMUH @puneetar @dfrankland — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47017/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/47017/result.json b/src/_tests/fixtures/47017/result.json index 62750ebdc..64f30894e 100644 --- a/src/_tests/fixtures/47017/result.json +++ b/src/_tests/fixtures/47017/result.json @@ -15,7 +15,7 @@ "status": "🔔 @borisyankov @19majkel94 @kacepe @micksatana @samijaber @aereal @JoseLion @dwrss @andoshin11 @CMUH @puneetar @dfrankland — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47017/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48216/result.json b/src/_tests/fixtures/48216/result.json index 332821b18..677644abb 100644 --- a/src/_tests/fixtures/48216/result.json +++ b/src/_tests/fixtures/48216/result.json @@ -12,7 +12,7 @@ "status": "🔔 @innovation-team @rlbaxter — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48216/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48236/result.json b/src/_tests/fixtures/48236/result.json index 68f12242a..d15eae45e 100644 --- a/src/_tests/fixtures/48236/result.json +++ b/src/_tests/fixtures/48236/result.json @@ -19,7 +19,7 @@ "status": "@jablko Everything looks good here. Great job! I am ready to merge this PR (at b4d71f6) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@climba03003: you can do this too.)" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": true, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-merge-offer/result.json b/src/_tests/fixtures/48652-merge-offer/result.json index 69ea0ea80..8208bf5fc 100644 --- a/src/_tests/fixtures/48652-merge-offer/result.json +++ b/src/_tests/fixtures/48652-merge-offer/result.json @@ -21,7 +21,7 @@ "status": "@RyanCavanaugh, @thorn0, @falsyvalues Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-prereq/result.json b/src/_tests/fixtures/48652-prereq/result.json index 83ef3b86e..8925e4f5c 100644 --- a/src/_tests/fixtures/48652-prereq/result.json +++ b/src/_tests/fixtures/48652-prereq/result.json @@ -25,7 +25,7 @@ "status": ":passport_control: Hi @mgol,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json b/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json index 080c72ce8..64398d601 100644 --- a/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json +++ b/src/_tests/fixtures/48652-retract-merge-offer-and-prerequest/result.json @@ -19,7 +19,7 @@ "status": ":passport_control: Hi @mgol,\n\nI can't [accept a merge request](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-make-a-pull-request) until the PR has a green CI and was appropriately reviewed. I will let you know once that happens.\n\nThanks, and happy typing!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48652-retract-merge-offer/result.json b/src/_tests/fixtures/48652-retract-merge-offer/result.json index 83e848d07..426502a37 100644 --- a/src/_tests/fixtures/48652-retract-merge-offer/result.json +++ b/src/_tests/fixtures/48652-retract-merge-offer/result.json @@ -15,7 +15,7 @@ "status": "@mgol One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48708/result.json b/src/_tests/fixtures/48708/result.json index dafd58f19..b142798c5 100644 --- a/src/_tests/fixtures/48708/result.json +++ b/src/_tests/fixtures/48708/result.json @@ -21,7 +21,7 @@ "status": "@martin-badin I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed in a week if the issues aren't addressed." } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/48945/result.json b/src/_tests/fixtures/48945/result.json index cbc4d3fed..af4ed1fa1 100644 --- a/src/_tests/fixtures/48945/result.json +++ b/src/_tests/fixtures/48945/result.json @@ -15,7 +15,7 @@ "status": "@google-api-typings-generator One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/49417/result.json b/src/_tests/fixtures/49417/result.json index 449eb20e4..8c0204c24 100644 --- a/src/_tests/fixtures/49417/result.json +++ b/src/_tests/fixtures/49417/result.json @@ -20,7 +20,7 @@ "status": "@tuuling Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/49548/result.json b/src/_tests/fixtures/49548/result.json index 90db16aaf..bf6d41c96 100644 --- a/src/_tests/fixtures/49548/result.json +++ b/src/_tests/fixtures/49548/result.json @@ -20,7 +20,7 @@ "status": "Re-ping «anyone?»:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!" } ], - "suggestions": [], + "explanations": [], "shouldClose": false, "shouldMerge": false, "shouldUpdateLabels": true, diff --git a/src/_tests/fixtures/49639/derived.json b/src/_tests/fixtures/49639/derived.json index 9fa8979a9..1b7ba2e2b 100644 --- a/src/_tests/fixtures/49639/derived.json +++ b/src/_tests/fixtures/49639/derived.json @@ -23,21 +23,19 @@ { "path": "types/jasmine/tsconfig.json", "kind": "package-meta", - "suspect": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it", - "suggestion": { + "suspect": { "startLine": 21, "endLine": 21, - "text": " \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it\n```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" } }, { "path": "types/jasmine/tslint.json", "kind": "package-meta", - "suspect": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it", - "suggestion": { + "suspect": { "startLine": 4, "endLine": 4, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it\n```suggestion\n```" } } ], diff --git a/src/_tests/fixtures/49639/mutations.json b/src/_tests/fixtures/49639/mutations.json index 44a7accbf..f4db9df2b 100644 --- a/src/_tests/fixtures/49639/mutations.json +++ b/src/_tests/fixtures/49639/mutations.json @@ -46,7 +46,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDcyOTI0NjE3Mw==", - "body": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n - Config files to check:\n - [`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it\n - [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d), [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -57,7 +57,7 @@ "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx", "path": "types/jasmine/tsconfig.json", "line": 21, - "body": "```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it\n```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" } } }, @@ -68,7 +68,7 @@ "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx", "path": "types/jasmine/tslint.json", "line": 4, - "body": "```suggestion\n```" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it\n```suggestion\n```" } } }, diff --git a/src/_tests/fixtures/49639/result.json b/src/_tests/fixtures/49639/result.json index 7bf6b18c2..476665b43 100644 --- a/src/_tests/fixtures/49639/result.json +++ b/src/_tests/fixtures/49639/result.json @@ -16,21 +16,21 @@ }, { "tag": "welcome", - "status": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n - Config files to check:\n - [`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it\n - [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`jasmine/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-522bbd567aec6bfd3e2cd29af157310bd47eb79dbe6a670beb4da4e1a14d0f2d), [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49639/files/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856#diff-0a3e03c56e43fc53245f1e4296782b62788ba4c9e70c9439d22b1998e681f55e))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 8 days.\n\n----------------------\n... diagnostics scrubbed ..." } ], - "suggestions": [ + "explanations": [ { "path": "types/jasmine/tsconfig.json", "startLine": 21, "endLine": 21, - "text": " \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it\n```suggestion\n \"forceConsistentCasingInFileNames\": true,\n \"strictFunctionTypes\": true\n```" }, { "path": "types/jasmine/tslint.json", "startLine": 4, "endLine": 4, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it\n```suggestion\n```" } ], "shouldClose": false, diff --git a/src/_tests/fixtures/49841/derived.json b/src/_tests/fixtures/49841/derived.json index 3d5024ae4..c2b99e93e 100644 --- a/src/_tests/fixtures/49841/derived.json +++ b/src/_tests/fixtures/49841/derived.json @@ -27,11 +27,10 @@ { "path": "types/react-native-sha1/tsconfig.json", "kind": "package-meta", - "suspect": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)", - "suggestion": { + "suspect": { "startLine": 17, "endLine": 17, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n```suggestion\n```" } }, { diff --git a/src/_tests/fixtures/49841/mutations.json b/src/_tests/fixtures/49841/mutations.json index 183a3aea1..0664e9f13 100644 --- a/src/_tests/fixtures/49841/mutations.json +++ b/src/_tests/fixtures/49841/mutations.json @@ -37,7 +37,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTI4OTE2Mjg5", - "body": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n - Config files to check:\n - [`react-native-sha1/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files/4849e8876b0ab7adc889ccc35b55fde6f0274837#diff-579fae17725faf40efb4aac22d7bcfb2337ec7080258e4a206f5a479968d3556): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -66,7 +66,7 @@ "pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTI4OTE2Mjg5", "path": "types/react-native-sha1/tsconfig.json", "line": 17, - "body": "```suggestion\n```" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n```suggestion\n```" } } }, diff --git a/src/_tests/fixtures/49841/result.json b/src/_tests/fixtures/49841/result.json index 9a428c6c8..9715ee52d 100644 --- a/src/_tests/fixtures/49841/result.json +++ b/src/_tests/fixtures/49841/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n - Config files to check:\n - [`react-native-sha1/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files/4849e8876b0ab7adc889ccc35b55fde6f0274837#diff-579fae17725faf40efb4aac22d7bcfb2337ec7080258e4a206f5a479968d3556): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", @@ -20,12 +20,12 @@ "status": "@shekari-ah The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/4849e8876b0ab7adc889ccc35b55fde6f0274837/checks?check_suite_id=1574877739).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!" } ], - "suggestions": [ + "explanations": [ { "path": "types/react-native-sha1/tsconfig.json", "startLine": 17, "endLine": 17, - "text": "" + "body": "not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson)\n```suggestion\n```" } ], "shouldClose": false,