diff --git a/src/_tests/fixtures/38979/mutations.json b/src/_tests/fixtures/38979/mutations.json index 558b0199..67d0d75e 100644 --- a/src/_tests/fixtures/38979/mutations.json +++ b/src/_tests/fixtures/38979/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==", - "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` — [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=38979&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` — [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=38979&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -13,8 +13,7 @@ "variables": { "input": { "labelIds": [ - "MDU6TGFiZWwxNjA4NjM0NDg0", - "MDU6TGFiZWwyNDYyODA0MzE1" + "MDU6TGFiZWwxNjA4NjM0NDg0" ], "labelableId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0" } @@ -37,7 +36,7 @@ "variables": { "input": { "contentId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", - "projectColumnId": "MDEzOlByb2plY3RDb2x1bW45ODY3MDA2" + "projectColumnId": "MDEzOlByb2plY3RDb2x1bW43NTUyOTIy" } } }, @@ -58,14 +57,5 @@ "body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } - }, - { - "mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n", - "variables": { - "input": { - "subjectId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", - "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)\n" - } - } } ] diff --git a/src/_tests/fixtures/38979/result.json b/src/_tests/fixtures/38979/result.json index ec055e48..944289ad 100644 --- a/src/_tests/fixtures/38979/result.json +++ b/src/_tests/fixtures/38979/result.json @@ -1,14 +1,13 @@ { - "projectColumn": "Needs Maintainer Action", + "projectColumn": "Needs Maintainer Review", "labels": [ "Critical package", - "Other Approved", - "Unreviewed" + "Other Approved" ], "responseComments": [ { "tag": "welcome", - "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` — [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=38979&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` — [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=38979&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", @@ -17,10 +16,6 @@ { "tag": "stale-ping-764528-0e6e7f4", "status": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" - }, - { - "tag": "Unreviewed:done", - "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)" } ], "shouldClose": false, diff --git a/src/_tests/fixtures/43695-duplicate-comment/mutations.json b/src/_tests/fixtures/43695-duplicate-comment/mutations.json index f7db7066..22753919 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/mutations.json +++ b/src/_tests/fixtures/43695-duplicate-comment/mutations.json @@ -63,7 +63,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", - "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping @«anyone?».)\n" + "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping «anyone?».)\n" } } } diff --git a/src/_tests/fixtures/43695-duplicate-comment/result.json b/src/_tests/fixtures/43695-duplicate-comment/result.json index 4bc4bb86..b0cff19e 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/result.json +++ b/src/_tests/fixtures/43695-duplicate-comment/result.json @@ -19,7 +19,7 @@ }, { "tag": "Unreviewed:done", - "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping @«anyone?».)" + "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping «anyone?».)" } ], "shouldClose": false, diff --git a/src/_tests/fixtures/44857/mutations.json b/src/_tests/fixtures/44857/mutations.json index f07baab3..5a99d651 100644 --- a/src/_tests/fixtures/44857/mutations.json +++ b/src/_tests/fixtures/44857/mutations.json @@ -30,6 +30,15 @@ } } }, + { + "mutation": "mutation ($input: MoveProjectCardInput!) {\n moveProjectCard(input: $input) {\n __typename\n }\n}\n", + "variables": { + "input": { + "cardId": "MDExOlByb2plY3RDYXJkMzg0NjYwNjg=", + "columnId": "MDEzOlByb2plY3RDb2x1bW43NTUyOTIy" + } + } + }, { "mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n", "variables": { diff --git a/src/_tests/fixtures/44857/result.json b/src/_tests/fixtures/44857/result.json index b09b3dfb..5bbbe763 100644 --- a/src/_tests/fixtures/44857/result.json +++ b/src/_tests/fixtures/44857/result.json @@ -1,5 +1,5 @@ { - "projectColumn": "Needs Maintainer Action", + "projectColumn": "Needs Maintainer Review", "labels": [ "Critical package", "Author is Owner", diff --git a/src/_tests/fixtures/44989-14days/mutations.json b/src/_tests/fixtures/44989-14days/mutations.json index 8c6464a0..9c652e8e 100644 --- a/src/_tests/fixtures/44989-14days/mutations.json +++ b/src/_tests/fixtures/44989-14days/mutations.json @@ -33,7 +33,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NDIyMDc5Mjk3", - "body": "Re-ping @petr-motejlek / @TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone:\n\nThis PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 22nd (in three weeks) if this doesn't happen.\n\n(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)\n" + "body": "Re-ping @petr-motejlek / @TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii:\n\nThis PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 22nd (in three weeks) if this doesn't happen.\n\n(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)\n" } } } diff --git a/src/_tests/fixtures/44989-14days/result.json b/src/_tests/fixtures/44989-14days/result.json index 32947af2..7e1cf922 100644 --- a/src/_tests/fixtures/44989-14days/result.json +++ b/src/_tests/fixtures/44989-14days/result.json @@ -17,7 +17,7 @@ }, { "tag": "Unmerged:nearly:2020-05-23", - "status": "Re-ping @petr-motejlek / @TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone:\n\nThis PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 22nd (in three weeks) if this doesn't happen.\n\n(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)" + "status": "Re-ping @petr-motejlek / @TheHandsomeCoder, @donnut, @mdekrey, @sbking, @afharo, @teves-castro, @1M0reBug, @hojberg, @samsonkeung, @angeloocana, @raynerd, @moshensky, @ethanresnick, @deftomat, @blimusiek, @biern, @rayhaneh, @rgm, @drewwyatt, @jottenlips, @minitesh, @krantisinh, @pirix-gh, @brekk, @nemo108, @jituanlin, @Philippe-mills, @Saul-Mirone, @Nicholaiii:\n\nThis PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 22nd (in three weeks) if this doesn't happen.\n\n(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)" } ], "shouldClose": false, diff --git a/src/_tests/fixtures/49548/mutations.json b/src/_tests/fixtures/49548/mutations.json index df6cf385..a5a495d1 100644 --- a/src/_tests/fixtures/49548/mutations.json +++ b/src/_tests/fixtures/49548/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTIwODA1MjIx", - "body": "Re-ping @«anyone?»:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!\n" + "body": "Re-ping «anyone?»:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!\n" } } } diff --git a/src/_tests/fixtures/49548/result.json b/src/_tests/fixtures/49548/result.json index 82d5cff8..8b4d4f42 100644 --- a/src/_tests/fixtures/49548/result.json +++ b/src/_tests/fixtures/49548/result.json @@ -16,7 +16,7 @@ }, { "tag": "Unreviewed:nearly:2020-11-16", - "status": "Re-ping @«anyone?»:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!" + "status": "Re-ping «anyone?»:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!" } ], "shouldClose": false, diff --git a/src/_tests/fixtures/49575/mutations.json b/src/_tests/fixtures/49575/mutations.json index a2d17964..09bd5f54 100644 --- a/src/_tests/fixtures/49575/mutations.json +++ b/src/_tests/fixtures/49575/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTIxMTM3NjEy", - "body": "@jablko Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 0 packages in this PR (and infra files)\n\n* Infra files\n - [`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35)\n - [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235)\n - [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2)\n - [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae)\n - [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5)\n - [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119)\n - [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49575&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect DT infrastructure ([`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35), [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235), [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2), [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae), [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5), [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119), [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 7 days.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@jablko Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 0 packages in this PR (and infra files)\n\n* Infra files\n - [`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35)\n - [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235)\n - [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2)\n - [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae)\n - [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5)\n - [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119)\n - [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49575&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect DT infrastructure ([`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35), [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235), [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2), [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae), [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5), [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119), [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/49575/result.json b/src/_tests/fixtures/49575/result.json index a7eed0b5..6a63f5ad 100644 --- a/src/_tests/fixtures/49575/result.json +++ b/src/_tests/fixtures/49575/result.json @@ -7,7 +7,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@jablko Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 0 packages in this PR (and infra files)\n\n* Infra files\n - [`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35)\n - [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235)\n - [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2)\n - [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae)\n - [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5)\n - [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119)\n - [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49575&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect DT infrastructure ([`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35), [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235), [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2), [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae), [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5), [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119), [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 7 days.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@jablko Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 0 packages in this PR (and infra files)\n\n* Infra files\n - [`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35)\n - [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235)\n - [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2)\n - [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae)\n - [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5)\n - [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119)\n - [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49575&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect DT infrastructure ([`.github/PULL_REQUEST_TEMPLATE.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35), [`README.cn.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-97a2a8d47e133a2b24ad7bc1a2e25710f534470e28a73efb62da312a3bb19235), [`README.es.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-42010a55cd1784b825a37c762cc91d75421f3ed4515f1047cf5506444949a0c2), [`README.ko.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-86fa6921bcebf260d55d8a3742c1b513bd78f4ea18366db989b5a03c68c563ae), [`README.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5), [`README.pt.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-822bdbb1cbe31bcc1afd1ddbbd7b3191052e07c9996334e645a22694e3cc2119), [`README.ru.md`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files/cdd66f483bb0103f6e6d1eb7b07192ff95718f25#diff-fb460bf71153d8224708cfa7298df0409d20c207f5b252b74906895bd8e1ac42))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/51338/mutations.json b/src/_tests/fixtures/51338/mutations.json index 2639f50f..07874b4c 100644 --- a/src/_tests/fixtures/51338/mutations.json +++ b/src/_tests/fixtures/51338/mutations.json @@ -4,18 +4,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDc4MjIxMzI4Nw==", - "body": "@pkuczynski Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `koa` — [on npm](https://www.npmjs.com/package/koa), [on unpkg](https://unpkg.com/browse/koa@latest/) (author is owner)\n - owner-approval: @tellnes\n - Config files to check:\n - [`koa/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51338/files/4a7712f61d17eb33e89171f317deeb31b3d555ae#diff-1730c5405d0220a98f28feeec2de3f5a511ebc6a04ceadf12415b81de841672e): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.esModuleInterop`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=51338&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 11 days — please try to get reviewers!\n\n----------------------\n... diagnostics scrubbed ...\n" - } - } - }, - { - "mutation": "mutation ($input: AddLabelsToLabelableInput!) {\n addLabelsToLabelable(input: $input) {\n __typename\n }\n}\n", - "variables": { - "input": { - "labelIds": [ - "MDU6TGFiZWwyNDYyODA0MzE1" - ], - "labelableId": "MDExOlB1bGxSZXF1ZXN0NTc2NTk4OTQ2" + "body": "@pkuczynski Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `koa` — [on npm](https://www.npmjs.com/package/koa), [on unpkg](https://unpkg.com/browse/koa@latest/) (author is owner)\n - owner-approval: @tellnes\n - Config files to check:\n - [`koa/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51338/files/4a7712f61d17eb33e89171f317deeb31b3d555ae#diff-1730c5405d0220a98f28feeec2de3f5a511ebc6a04ceadf12415b81de841672e): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.esModuleInterop`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=51338&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, @@ -27,14 +16,5 @@ "body": ":hourglass_flowing_sand: Hi @pkuczynski,\n\nIt's been a few days since this PR was approved by tellnes and we're waiting for a DT maintainer to give a review.\n\nIf you would like to short-circuit this wait, you can edit some of the [test files](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-my-package-teststs) in the package which verify how the `.d.ts` files work. This would allow the PR to be merged by you or the DT module owners after a re-review.\n" } } - }, - { - "mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n", - "variables": { - "input": { - "subjectId": "MDExOlB1bGxSZXF1ZXN0NTc2NTk4OTQ2", - "body": "Re-ping @DavidCai1993, @jkeylu, @brikou, @harryparkdotio, @chatoo2412:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!\n" - } - } } ] diff --git a/src/_tests/fixtures/51338/result.json b/src/_tests/fixtures/51338/result.json index 00a37637..9fdf37ea 100644 --- a/src/_tests/fixtures/51338/result.json +++ b/src/_tests/fixtures/51338/result.json @@ -5,8 +5,7 @@ "Owner Approved", "Author is Owner", "Check Config", - "Untested Change", - "Unreviewed" + "Untested Change" ], "responseComments": [ { @@ -15,15 +14,11 @@ }, { "tag": "welcome", - "status": "@pkuczynski Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `koa` — [on npm](https://www.npmjs.com/package/koa), [on unpkg](https://unpkg.com/browse/koa@latest/) (author is owner)\n - owner-approval: @tellnes\n - Config files to check:\n - [`koa/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51338/files/4a7712f61d17eb33e89171f317deeb31b3d555ae#diff-1730c5405d0220a98f28feeec2de3f5a511ebc6a04ceadf12415b81de841672e): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.esModuleInterop`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=51338&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 11 days — please try to get reviewers!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@pkuczynski Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `koa` — [on npm](https://www.npmjs.com/package/koa), [on unpkg](https://unpkg.com/browse/koa@latest/) (author is owner)\n - owner-approval: @tellnes\n - Config files to check:\n - [`koa/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51338/files/4a7712f61d17eb33e89171f317deeb31b3d555ae#diff-1730c5405d0220a98f28feeec2de3f5a511ebc6a04ceadf12415b81de841672e): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.esModuleInterop`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=51338&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "wait-for-merge-offer-4a7712f", "status": ":hourglass_flowing_sand: Hi @pkuczynski,\n\nIt's been a few days since this PR was approved by tellnes and we're waiting for a DT maintainer to give a review.\n\nIf you would like to short-circuit this wait, you can edit some of the [test files](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-my-package-teststs) in the package which verify how the `.d.ts` files work. This would allow the PR to be merged by you or the DT module owners after a re-review." - }, - { - "tag": "Unreviewed:nearly:2021-02-19", - "status": "Re-ping @DavidCai1993, @jkeylu, @brikou, @harryparkdotio, @chatoo2412:\n\nThis PR has been out for over a week, yet I haven't seen any reviews.\n\nCould someone please give it some attention? Thanks!" } ], "shouldClose": false,