Join the Potential Rework

[marvin1099]

If you like to join the Team for the potential wemod-launcher rework,
you can reach out here, if you want to.
Feel free to reach out in other ways.

[Marakai]

Hello!

I just newly cloned the repo and am starting the basics of importing it into my IDE, getting to it to build/package in my env, just starting at the bottom.

In another reply to me you stated you use PDM (I come from a corpo env where it's all Poetry, but it's fine, if you've seen one package/build manager in Python, you've seen them all), so I went and grabbed it.

It does seem that PDM is pretty opinionated, because the first thing it did when I ran pdm init was to create pyproject.toml as README.md rather than use the existing readme.md and a "proper" sub-dir for the source files - as well as a tests sub-dir for unit tests and friends, which save me the effort.

Looking at the dev branch, none of these are in place, it still looks like a regular setuptools project?

[marvin1099]

PDM is based on a bunch of Python and pip standards. So its while it might be opinionated it comes very close to what a official Python package manager may look like (like pip but more up to date).
Next Dev and main are still a setuptools project yes, the refactor uses PDM.
I don't want the main and Dev to distance itself from the refactor as I do want to replace Dev with the refactor (and main) at some point.
As the work on the refactor is going pretty slow its probably still worth to work on dev.
The deprivation of Dev will happen but its quite a bit ahead in the future.
Since you mentioned it you can set the name of the readme in the project.toml.
The subdir structure is not used yet as this project when it started was very simple so the fist Dev did not use a proper subdir structure, that is something that we wanted to change in the refactor.
So you still gave the choice on what you like to work but the refactor is a bit under development (have to fix some issues, before others can effectively help on it; Its not really ready for helping hands right not; this will be ready for help soon).

[Marakai]

The thing is that one of the first things I would normally do, would also be a refactor dive-in. Also a re-structure of the code and intro unit tests, if at all possible. So we'd end up with a lot of clashing and overlaps. I need to look at the WIP branch, maybe I can cherry pick some bits.

[marvin1099]

Jes providing a binary was something that I wanted to make work but Im just not that motivated to make new things happen.
Good to have someone new and motivated.
I will of course check on your code for fun every once in a while, and when its time to merge too of course.

[Marakai]

How about rewriting the whole thing in Go?

just kidding! Though... one single simple binary to install and run has an attraction.

[marvin1099]

@Marakai kinda curious if you did make anything or did not have motivation / time.
I'm just thinking about it you know.

[Marakai]

@Marakai kinda curious if you did make anything or did not have motivation / time. I'm just thinking about it you know.

TBH, I'm still trying to work out the internals. For example getting it to work so I can debug it in my IDE (Pycharm). As per what you suggested, I'm using Proton-GE (with UMU-Launcher), so that's a number of moving parts I'm trying to get to play together in one IDE session. :|

[marvin1099]

@Marakai kinda curious if you did make anything or did not have motivation / time. I'm just thinking about it you know.

TBH, I'm still trying to work out the internals. For example getting it to work so I can debug it in my IDE (Pycharm). As per what you suggested, I'm using Proton-GE (with UMU-Launcher), so that's a number of moving parts I'm trying to get to play together in one IDE session. :|

I see, if you want some idea of the launcher right now you can see how it works in English (not in code) right here.
The launcher is basically a fancy argument parser.

[AvicusPT]

It's working perfectly, just ignore the MS32 error and it's good to go. I'm running it on Arch Linux (Garuda). It even detects other games. I will try it out on Lutris to see if it runs on other game platforms