fix: consider NOT_FOUND after reset callbacks as unhandled request (#124)

Author: brian-mulier

tzatziki-http/src/main/java/com/decathlon/tzatziki/steps/HttpSteps.java

@@ -468,14 +468,15 @@ public void mockserver_has_not_been_called_on(Guard guard, String path) {
     public void after() {
         if (doNotAllowUnhandledRequests) {
             List<LogEventRequestAndResponse> requestAndResponses = retrieveRequestResponses(request());
+            String notFoundMessageRegex = "Not Found(?: Again!)?";
             Set<HttpRequest> unhandledRequests = requestAndResponses
                     .stream()
-                    .filter(requestAndResponse -> "Not Found".equals(requestAndResponse.getHttpResponse().getReasonPhrase()))
+                    .filter(requestAndResponse -> Optional.ofNullable(requestAndResponse.getHttpResponse().getReasonPhrase()).orElse("").matches(notFoundMessageRegex))
                     .map(requestAndResponse -> (HttpRequest) requestAndResponse.getHttpRequest())
                     .collect(Collectors.toSet());
             // we make a second pass, the calls might have been handled later on
             requestAndResponses.stream()
-                    .filter(requestAndResponse -> !"Not Found".equals(requestAndResponse.getHttpResponse().getReasonPhrase()))
+                    .filter(requestAndResponse -> !Optional.ofNullable(requestAndResponse.getHttpResponse().getReasonPhrase()).orElse("").matches(notFoundMessageRegex))
                     .forEach(requestAndResponse -> unhandledRequests.remove((HttpRequest) requestAndResponse.getHttpRequest()));
             withFailMessage(() -> assertThat(unhandledRequests).isEmpty(), () -> "unhandled requests: %s".formatted(unhandledRequests));
         }

tzatziki-http/src/test/resources/com/decathlon/tzatziki/steps/http.feature

@@ -1215,4 +1215,16 @@ Feature: to interact with an http service and setup mocks
     Examples:
       | mocksRange |
       | 2-150      |
-      | 151-250    |
+      | 151-250    |
+
+  @ignore @run-manually
+  Scenario Template: Mocks from other tests should be considered as unhandled requests
+    * a root logger set to INFO
+    Given that if <idx> == 1 => getting on "http://backend/unhandled" will return a status OK_200
+    And that if <idx> == 2 => getting on "http://backend/justForHostnameMock" will return a status OK_200
+    Then we get on "http://backend/unhandled"
+
+    Examples:
+      | idx |
+      | 1   |
+      | 2   |