Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to launch BrowserRouter #29

Open
mudnug opened this issue Nov 25, 2024 · 10 comments
Open

Fails to launch BrowserRouter #29

mudnug opened this issue Nov 25, 2024 · 10 comments

Comments

@mudnug
Copy link

mudnug commented Nov 25, 2024

Using ?? fails as does the default search in PowerToys. Is it possible to configure how the command is sent to the browser exe?

Notably, "Open" works fine but search doesn't if I am not using this plugin

image

@Daydreamer-riri
Copy link
Owner

Daydreamer-riri commented Nov 25, 2024

Please provide your configuration file, as well as your powertoys version.
And what is your default browser?

@mudnug
Copy link
Author

mudnug commented Nov 25, 2024

Release v0.86.0
No config / default config

@Daydreamer-riri
Copy link
Owner

Please refer to https://github.com/Daydreamer-riri/PowerToys-Run-WebSearchShortcut?tab=readme-ov-file#configuration.

I need to replicate your situation before I can help you out.

What exactly do you mean by 'fails'?

@mudnug
Copy link
Author

mudnug commented Nov 25, 2024

I'm guessing that the plugin uses something underlying in PowerToys? It fails with a message box. This is why I was asking if it's configurable so that I can fix the way it's trying to call the browser. Thanks for being responsive by the way!

image

@Daydreamer-riri
Copy link
Owner

It could be an upstream problem. What is your default browser? I'm guessing it has something to do with your browser.

@mudnug
Copy link
Author

mudnug commented Nov 25, 2024

I would suppose it is an upstream problem; How is the call to the browser initiated? I assume the arguments don't have quotes where they are expected or something like that... Notably, "upstream" if I use a URL instead of a search it will open the browser just fine
BrowseRouter as shown in the msgbox

@Daydreamer-riri
Copy link
Owner

I use the same method as WebSearch which is built-in.

@mudnug
Copy link
Author

mudnug commented Nov 26, 2024

Are you familiar enough with their code for web search that you can point me to where it launches the browser?

@mudnug
Copy link
Author

mudnug commented Nov 27, 2024

Perhaps one of the devs will help triage it at microsoft/PowerToys#36083

@Daydreamer-riri
Copy link
Owner

Daydreamer-riri commented Nov 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants