Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit attribute value length for pinpoint #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nougad
Copy link

@nougad nougad commented Oct 31, 2021

Pinpoint has a maximum number of characters per attribute value of 200:
https://docs.aws.amazon.com/pinpoint/latest/developerguide/quotas.html#quotas-events

This in particular applies to the referrer which an be very long. Better
to limit the event than getting it rejected by pinpoint.

BTW: Any reason why the official pinpoint client is added as dependency but not used? https://github.com/DavidWells/analytics/blob/master/packages/analytics-plugin-aws-pinpoint/package.json#L72 I think that would catch issues like this client side.

Pinpoint has a maximum number of characters per attribute value of 200:
https://docs.aws.amazon.com/pinpoint/latest/developerguide/quotas.html#quotas-events

This in particular applies to the referrer which an be very long. Better
to limit the event than getting it rejected by pinpoint.
@nougad nougad marked this pull request as ready for review October 31, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant