Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom ID resolvers #230

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

UnbrandedTech
Copy link

@UnbrandedTech UnbrandedTech commented Oct 27, 2021

Trying to implement a @todo I saw in @analytics/core:

@TODO add custom value reolvers for userId and anonId

A small issue I encountered is that most public functions except the analytics.user() function is async. We can easily make the custom resolvers async (allowing network requests, etc.) but it would be a breaking change. I think this is a small enough addition that is very helpful in the short term, even without allowing async resolvers and the team/project can discuss changing the signature in a future major version.

@UnbrandedTech UnbrandedTech marked this pull request as draft October 27, 2021 16:35
@UnbrandedTech
Copy link
Author

@DavidWells Do you have an opinion?

@UnbrandedTech UnbrandedTech marked this pull request as ready for review September 7, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant