Skip to content

Commit a3f3d6c

Browse files
docs: fix outdated CMake version requirement in README (#990)
The README stated that CMake 2.8.5+ was required, but CMakeLists.txt requires CMake 3.5+. This inconsistency caused confusion for users with CMake versions between 2.8.5 and 3.5. Also updated library_config/uninstall.cmake to match for consistency. Fixes #988
1 parent 5cc0e39 commit a3f3d6c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ cJSON is written in ANSI C (C89) in order to support as many platforms and compi
8989

9090
#### CMake
9191

92-
With CMake, cJSON supports a full blown build system. This way you get the most features. CMake with an equal or higher version than 2.8.5 is supported. With CMake it is recommended to do an out of tree build, meaning the compiled files are put in a directory separate from the source files. So in order to build cJSON with CMake on a Unix platform, make a `build` directory and run CMake inside it.
92+
With CMake, cJSON supports a full blown build system. This way you get the most features. CMake with an equal or higher version than 3.5 is supported. With CMake it is recommended to do an out of tree build, meaning the compiled files are put in a directory separate from the source files. So in order to build cJSON with CMake on a Unix platform, make a `build` directory and run CMake inside it.
9393

9494
```
9595
mkdir build

library_config/uninstall.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 2.8.5)
1+
cmake_minimum_required(VERSION 3.5)
22

33
set(MANIFEST "${CMAKE_CURRENT_BINARY_DIR}/install_manifest.txt")
44

0 commit comments

Comments
 (0)