Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: It limits the span to only 2 unlike OTEL #66

Open
muthurathnamswamy-8451 opened this issue Aug 20, 2024 · 1 comment
Open

[Bug]: It limits the span to only 2 unlike OTEL #66

muthurathnamswamy-8451 opened this issue Aug 20, 2024 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@muthurathnamswamy-8451
Copy link

Kong Version

3.6.1.7

Plugin Version

v0.2.1

On which environment your Kong instance is running?

Kubernetes

Plugin Configuration

{
            "config": {
                "agent_endpoint": null,
                "agent_host": null,
                "environment": null,
                "extraction_propagation_styles": [
                    "tracecontext"
                ],
                "generate_128bit_trace_ids": true,
                "header_tags": null,
                "initial_sample_rate": 1,
                "initial_samples_per_second": 200,
                "injection_propagation_styles": [
                    "tracecontext"
                ],
                "max_header_size": 512,
                "resource_name_rule": null,
                "service_name": "kong-internal",
                "static_tags": null,
                "trace_agent_port": null,
                "trace_agent_url": null,
                "version": null
            },
            "created_at": 1724093686,
            "enabled": false,
            "id": "ac6252ab-9050-4dde-be18-8564e8e444b2",
            "name": "ddtrace",
            "protocols": [
                "http"
            ],
            "updated_at": 1724177689
        }

What happened?

I tried playing around with these parameters and note that DD_AGENT_HOST value is being obtained from the environment variable:

Extraction Propagation Style and Injection Propagation Styles to following values individually

  1. datadog
  2. tracecontext
  3. datadog and tracecontext

Increased the Initial samples per second value to 200, sent about 250 requests

image

May I know what config changes can be made to DDTRACE to have more spans similar to OTEL Plugin (OTEL Span screen shot shown below for reference), appreciate your inputs.

image

@muthurathnamswamy-8451 muthurathnamswamy-8451 added the bug Something isn't working label Aug 20, 2024
@dmehala dmehala added question Further information is requested and removed bug Something isn't working labels Aug 21, 2024
@dmehala
Copy link
Contributor

dmehala commented Aug 22, 2024

Hi @muthurathnamswamy-8451

May I know what config changes can be made to DDTRACE to have more spans similar to OTEL Plugin

Currently, it is not possible to generate more spans similar to those create by Kong's OTEL plugin. This limitation is because Kong's tracer is used to instrument internal code, which is beyond the scope of what plugins, like DDTRACE, can access.

To achieve the desired outcome, Kong would need to expose a tracer interface that DDTRACE could implement. I have been considering suggesting a similar approach to Kong, but I haven't had the chance to fully articulate my thoughts yet.

In summary, I understand your concern and agree that there should be consistency between the two modules. I am actively working on addressing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants