Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only match against real requirements #261

Open
AngellusMortis opened this issue Jul 4, 2023 · 0 comments
Open

Only match against real requirements #261

AngellusMortis opened this issue Jul 4, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AngellusMortis
Copy link
Contributor

AngellusMortis commented Jul 4, 2023

I have noticed that guarddog still tries to scan the partial matches inside a requirements.txt. It should only match real requirements not partial matches or comments.

Comments:

pip-tools is a popular tool to generate requirements.txt files. It can add comments to list the source of a package so you can track the dep tree easier.

Example:
image

Partial Matches

Sometimes it matches against substrings in other requirements.

Example:

image

@AngellusMortis AngellusMortis changed the title Ingore Lines that begin with comments Only match against real requirements Jul 4, 2023
@christophetd christophetd added enhancement New feature or request good first issue Good for newcomers labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants