Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full DBM propagation for pgx #2711

Open
ewhauser opened this issue May 25, 2024 · 5 comments
Open

Full DBM propagation for pgx #2711

ewhauser opened this issue May 25, 2024 · 5 comments
Assignees
@rarguelloF
Labels
apm:ecosystem contrib/* related feature requests or bugs proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@ewhauser
Copy link

ewhauser commented May 25, 2024 •
edited

pgx needs support for DBM trace propagation (https://docs.datadoghq.com/database_monitoring/connect_dbm_and_apm/?tab=go) like lib/pq
@ewhauser ewhauser added the enhancement quick change/addition that does not need full team approval label May 25, 2024
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label May 25, 2024
@felixge felixge removed the needs-triage New issues that have not yet been triaged label Jun 6, 2024
@felixge
Copy link
Member

felixge commented Jun 6, 2024

👋 Thanks for submitting this and sorry for the delay. I've pinged the internal team owning this, hopefully they'll get to it ASAP.

@rarguelloF
Copy link
Contributor

Hello @ewhauser, thanks for opening an issue!

What instrumentation are you referring to? We currently don't have any instrumentation named dbx.

If your issue is about supporting a new instrumentation, please feel free to open a new issue with more details about your request, including a link to the github repository of the library.

We accept external PRs from external contributors, but if you want us to tackle the work feel free to reach out Datadog Support so we can best prioritize that work!

@rarguelloF rarguelloF added waiting-for-info waiting for answer from issue creator proposal more in depth change that requires full team approval and removed enhancement quick change/addition that does not need full team approval labels Jun 6, 2024
@rarguelloF rarguelloF self-assigned this Jun 6, 2024
@ewhauser ewhauser changed the title Full DBM propagation for dbx Full DBM propagation for pgx Jun 6, 2024
@ewhauser
Copy link
Author

ewhauser commented Jun 6, 2024

Apologies, that was I typo. I updated it to be pgx.

@caseycull
Copy link

caseycull commented Jun 6, 2024 •
edited

Hi @ewhauser, which DBMS types would you want this for?
(Postgres, MySQL, SQL Server, Oracle)

@ewhauser
Copy link
Author

ewhauser commented Jun 6, 2024

Postgres

@rarguelloF rarguelloF added proposal/accepted Accepted proposals apm:ecosystem contrib/* related feature requests or bugs and removed waiting-for-info waiting for answer from issue creator labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rarguelloF rarguelloF

Labels
apm:ecosystem contrib/* related feature requests or bugs proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@felixge @ewhauser @rarguelloF @caseycull