Skip to content

Commit aa22e25

Browse files
authored
CORE-93: try to unflake preview-drs-uri integration test (#5134)
1 parent 9647d6a commit aa22e25

File tree

2 files changed

+23
-16
lines changed

2 files changed

+23
-16
lines changed

integration-tests/slack/slack-notify-channels.json

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
"id": "C53JYBV9A"
1212
},
1313
{
14-
"name": "ia-notification-test",
15-
"id": "C03ATF4QXEV",
14+
"name": "dsp-analysis-non-prod-alerts",
15+
"id": "C07RX0CJV0D",
1616
"tests": [
1717
{
1818
"name": "run-analysis"
@@ -25,13 +25,7 @@
2525
},
2626
{
2727
"name": "run-analysis-azure"
28-
}
29-
]
30-
},
31-
{
32-
"name": "cromwell_jenkins_ci_errors",
33-
"id": "C01AG7GEJ3D",
34-
"tests": [
28+
},
3529
{
3630
"name": "find-workflow"
3731
},
@@ -64,6 +58,9 @@
6458
},
6559
{
6660
"name": "request-access"
61+
},
62+
{
63+
"name": "preview-drs-uri"
6764
}
6865
]
6966
},

integration-tests/tests/preview-drs-uri.js

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ const {
1313
waitForNoSpinners,
1414
input,
1515
signIntoTerra,
16-
noSpinnersAfter,
1716
} = require('../utils/integration-utils');
1817

1918
const testPreviewDrsUriFn = _.flow(
@@ -28,25 +27,36 @@ const testPreviewDrsUriFn = _.flow(
2827
},
2928
};
3029

30+
console.log('signing in...');
3131
await signIntoTerra(page, { token, testUrl });
3232

33+
console.log('creating entity...');
3334
await createEntityInWorkspace(page, billingProject, workspaceName, testEntity);
3435

36+
console.log('listing workspaces...');
3537
await click(page, clickable({ textContains: 'View Workspaces' }));
3638
await waitForNoSpinners(page);
39+
40+
console.log('opening test workspace...');
3741
await fillIn(page, input({ placeholder: 'Search by name, project, or bucket' }), workspaceName);
3842
await click(page, clickable({ textContains: workspaceName }), { timeout: Millis.ofMinute });
43+
await findText(page, 'About the workspace');
3944

40-
await noSpinnersAfter(page, {
41-
action: () => click(page, navChild('data')),
42-
});
43-
45+
// Wait for the "test_entity" link to appear.
4446
// Loading the workspace page now means we need to make a Google API call to
45-
// fetch the GCS bucket location. Wait a bit for it.
46-
await waitForNoSpinners(page);
47+
// fetch the GCS bucket location, which takes a while; we don't need to wait for
48+
// all spinners to disapper.
49+
console.log('opening Data tab...');
50+
await click(page, navChild('data'));
51+
await findText(page, `${testEntity.entityType}`);
52+
53+
console.log('opening data table...');
4754
await click(page, clickable({ textContains: testEntity.entityType }));
55+
console.log('opening preview for entity...');
4856
await click(page, elementInDataTableRow(testEntity.name, testEntity.attributes.file_uri));
57+
console.log('waiting for no spinners in preview modal...');
4958
await waitForNoSpinners(page);
59+
console.log('verifying text in preview modal...');
5060
await findText(page, 'Filename');
5161
await findText(page, 'File size');
5262
});

0 commit comments

Comments
 (0)