CORE-56: release provenance and versions (#5132)

Author: davidangb

src/libs/feature-previews-config.ts

@@ -45,26 +45,6 @@ export type FeaturePreview = {
 };
 
 const featurePreviewsConfig: readonly FeaturePreview[] = [
-  {
-    id: 'data-table-versioning',
-    title: 'Data Table Versioning',
-    description:
-      'Enabling this feature will allow you to save uniquely named versions of data tables. These saved versions will appear in the Data tab and can be restored at any time.',
-    groups: ['preview-data-versioning-and-provenance'],
-    feedbackUrl: `mailto:[email protected]?subject=${encodeURIComponent(
-      'Feedback on data table versioning'
-    )}`,
-  },
-  {
-    id: 'data-table-provenance',
-    title: 'Data Table Provenance',
-    description:
-      'Enabling this feature will allow you to view information about the workflow that generated data table columns and files.',
-    groups: ['preview-data-versioning-and-provenance'],
-    feedbackUrl: `mailto:[email protected]?subject=${encodeURIComponent(
-      'Feedback on data table provenance'
-    )}`,
-  },
   {
     id: JUPYTERLAB_GCP_FEATURE_ID,
     title: 'JupyterLab on GCP',

src/workspace-data/Data.js

@@ -22,7 +22,6 @@ import colors from 'src/libs/colors';
 import { getConfig } from 'src/libs/config';
 import { reportError, reportErrorAndRethrow, withErrorReporting } from 'src/libs/error';
 import Events, { extractWorkspaceDetails } from 'src/libs/events';
-import { isFeaturePreviewEnabled } from 'src/libs/feature-previews';
 import * as Nav from 'src/libs/nav';
 import { notify } from 'src/libs/notifications';
 import { forwardRefWithName, useCancellation, useOnMount } from 'src/libs/react-utils';
@@ -408,26 +407,25 @@ const DataTableActions = ({
               },
               'Delete table'
             ),
-          isFeaturePreviewEnabled('data-table-versioning') &&
-            h(Fragment, [
-              h(MenuDivider),
-              h(MenuButton, { onClick: () => setSavingVersion(true) }, ['Save version']),
-              h(
-                MenuButton,
-                {
-                  onClick: () => {
-                    onToggleVersionHistory(!isShowingVersionHistory);
-                    if (!isShowingVersionHistory) {
-                      Ajax().Metrics.captureEvent(Events.dataTableVersioningViewVersionHistory, {
-                        ...extractWorkspaceDetails(workspace.workspace),
-                        tableName,
-                      });
-                    }
-                  },
+          h(Fragment, [
+            h(MenuDivider),
+            h(MenuButton, { onClick: () => setSavingVersion(true) }, ['Save version']),
+            h(
+              MenuButton,
+              {
+                onClick: () => {
+                  onToggleVersionHistory(!isShowingVersionHistory);
+                  if (!isShowingVersionHistory) {
+                    Ajax().Metrics.captureEvent(Events.dataTableVersioningViewVersionHistory, {
+                      ...extractWorkspaceDetails(workspace.workspace),
+                      tableName,
+                    });
+                  }
                 },
-                [`${isShowingVersionHistory ? 'Hide' : 'Show'} version history`]
-              ),
-            ]),
+              },
+              [`${isShowingVersionHistory ? 'Hide' : 'Show'} version history`]
+            ),
+          ]),
         ]),
       },
       [
@@ -506,29 +504,6 @@ const DataTableActions = ({
   ]);
 };
 
-const DataTableFeaturePreviewFeedbackBanner = () => {
-  const isDataTableProvenanceEnabled = isFeaturePreviewEnabled('data-table-provenance');
-  const isDataTableVersioningEnabled = isFeaturePreviewEnabled('data-table-versioning');
-
-  const label = _.join(' and ', _.compact([isDataTableVersioningEnabled && 'versioning', isDataTableProvenanceEnabled && 'provenance']));
-  const feedbackUrl = `mailto:[email protected]?subject=${encodeURIComponent(`Feedback on data table ${label}`)}`;
-
-  return (
-    (isDataTableProvenanceEnabled || isDataTableVersioningEnabled) &&
-    div(
-      {
-        style: {
-          padding: '1rem',
-          borderBottom: `1px solid ${colors.accent()}`,
-          background: '#fff',
-          textAlign: 'center',
-        },
-      },
-      [h(Link, { ...Utils.newTabLinkProps, href: feedbackUrl }, [`Provide feedback on data table ${label}`])]
-    )
-  );
-};
-
 const workspaceDataTypes = Utils.enumify(['entities', 'entitiesVersion', 'snapshot', 'referenceData', 'localVariables', 'bucketObjects', 'wds']);
 
 export const WorkspaceData = _.flow(
@@ -1235,8 +1210,6 @@ export const WorkspaceData = _.flow(
             ]),
             h(SidebarSeparator, { sidebarWidth, setSidebarWidth }),
             div({ style: styles.tableViewPanel }, [
-              _.includes(selectedData?.type, [workspaceDataTypes.entities, workspaceDataTypes.entitiesVersion]) &&
-                h(DataTableFeaturePreviewFeedbackBanner),
               Utils.switchCase(
                 selectedData?.type,
                 [

src/workspace-data/data-table/entity-service/EntitiesContent.js

@@ -28,7 +28,6 @@ import { EntityServiceDataTableProvider } from 'src/libs/ajax/data-table-provide
 import colors from 'src/libs/colors';
 import { withErrorReporting } from 'src/libs/error';
 import Events, { extractWorkspaceDetails } from 'src/libs/events';
-import { isFeaturePreviewEnabled } from 'src/libs/feature-previews';
 import * as Nav from 'src/libs/nav';
 import { notify } from 'src/libs/notifications';
 import { useCancellation, useOnMount, withDisplayName } from 'src/libs/react-utils';
@@ -528,19 +527,17 @@ const EntitiesContent = ({
             borderBottom: `1px solid ${colors.grey(0.4)}`,
           },
           border: false,
-          extraColumnActions: isFeaturePreviewEnabled('data-table-provenance')
-            ? (columnName) => [
-                {
-                  label: 'Show Provenance',
-                  onClick: () => {
-                    if (!(loadingColumnProvenance || columnProvenance)) {
-                      loadColumnProvenance();
-                    }
-                    setShowColumnProvenance(columnName);
-                  },
-                },
-              ]
-            : undefined,
+          extraColumnActions: (columnName) => [
+            {
+              label: 'Show Provenance',
+              onClick: () => {
+                if (!(loadingColumnProvenance || columnProvenance)) {
+                  loadColumnProvenance();
+                }
+                setShowColumnProvenance(columnName);
+              },
+            },
+          ],
         }),
         addingEntity &&
           h(AddEntityModal, {

src/workspace-data/data-table/uri-viewer/UriViewer.js

@@ -11,7 +11,6 @@ import { Link } from 'src/components/common';
 import { parseGsUri } from 'src/components/data/data-utils';
 import { Ajax } from 'src/libs/ajax';
 import colors from 'src/libs/colors';
-import { isFeaturePreviewEnabled } from 'src/libs/feature-previews';
 import { useCancellation, useOnMount, withDisplayName } from 'src/libs/react-utils';
 import * as Utils from 'src/libs/utils';
 import { requesterPaysWrapper, withRequesterPaysHandler } from 'src/workspaces/common/requester-pays/bucket-utils';
@@ -186,8 +185,7 @@ export const UriViewer = _.flow(
         [
           timeCreated && els.cell([els.label('Created'), els.data(new Date(timeCreated).toLocaleString())]),
           updated && els.cell([els.label('Updated'), els.data(new Date(updated).toLocaleString())]),
-          isFeaturePreviewEnabled('data-table-provenance') &&
-            els.cell([els.label('Where did this file come from?'), els.data([h(FileProvenance, { workspace, fileUrl: uri })])]),
+          els.cell([els.label('Where did this file come from?'), els.data([h(FileProvenance, { workspace, fileUrl: uri })])]),
         ]
       )
     );