Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateAndReturnAsync not implemented? #47

Closed
djissam04 opened this issue Feb 13, 2025 · 2 comments · Fixed by #48
Closed

CreateAndReturnAsync not implemented? #47

djissam04 opened this issue Feb 13, 2025 · 2 comments · Fixed by #48

Comments

@djissam04
Copy link

Hi MarkMpn,

I appreciate your work on this project! I was reviewing the code and noticed that the CreateAndReturnAsync method is not implemented. I'm curious if there is a specific reason for this decision.

Would you be open to adding this method, or is there an alternative approach you’d recommend? I'd be happy to contribute if needed!

Looking forward to your thoughts.
@MarkMpn
Copy link
Contributor

MarkMpn commented Feb 13, 2025

This was copying the logic from the DVSC at the time. It looks like this has now been implemented as a call to Create then Retrieve - I'd be happy if you want to contribute a similar update here as well!

@djissam04 djissam04 mentioned this issue Feb 17, 2025
Merged
@djissam04
Copy link
Author

The issue is now fixed, and I have submitted a pull request for review. Let me know if any further adjustments are needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement CreateAndReturnAsync djissam04/DataverseClient
2 participants
@djissam04 @MarkMpn