Add support for custom objects and fields #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1 Add support for custom objects and fields in JSON feed. * Add `CustomObjects` property to `JsonFeed` and `JsonFeedItem` classes to store custom objects. * Update `Simple.json` test resource to include examples of custom objects with names starting with an underscore and alphanumeric member keys. * Add test in `JsonFeedTests.cs` to verify the handling of custom objects in the feed. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DanRigby/JsonFeed.NET/issues/1?shareId=XXXX-XXXX-XXXX-XXXX).
|
Not bad 🤖, not bad. |
|
Played around with this for a bit. The Unfortunately, with source generation enabled, we need to know our types and provide the JsonTypeInfo when serializing and deserializing. I'm at a bit of an impasse on the best way to handle that, so I'm going close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Add support for custom objects and fields in JSON feeds.
CustomObjectsproperty toJsonFeedandJsonFeedItemclasses to store custom objects.Simple.jsontest resource to include examples of custom objects with names starting with an underscore and alphanumeric member keys.JsonFeedTests.csto verify the handling of custom objects in the feed.For more details, open the Copilot Workspace session.