double checked api calls

Author: Arkady Emelyanov

README.md

@@ -107,12 +107,12 @@ ExecStart=/usr/bin/docker run --rm --name %n \
         -e "GITLAB_FILE_NAMESPACE=acme" \
         -e "GITLAB_REPO_FILE_EXTRA_LIST=composerList.json,npmList.json" \
         -p 8080:4000 \
-        dalee/comrade-pavlik2:1.0.3
+        dalee/comrade-pavlik2:1.0.5
 
 [Install]
 WantedBy=multi-user.target
 ```
-> Please check image version, stable version is >= 1.0.3
+> Please check image version, stable version is >= 1.0.5
 
 ### Project setup
 

pkg/client/gitlab/client_base.go

@@ -8,8 +8,8 @@ import (
 	"net/url"
 )
 
-//
-//
+// @see https://gitlab.com/gitlab-org/gitlab-ce/blob/8-5-stable/doc/api/projects.md#list-projects
+// https://docs.gitlab.com/ee/api/projects.html#list-projects
 //
 func (c *Client) GetProjectList() ([]*Project, error) {
 
@@ -32,12 +32,12 @@ func (c *Client) GetProjectList() ([]*Project, error) {
 	return projectList, nil
 }
 
-//
-//
+// @see https://gitlab.com/gitlab-org/gitlab-ce/blob/8-5-stable/doc/api/projects.md#get-single-project
+// @see https://docs.gitlab.com/ee/api/projects.html#get-single-project
 //
 func (c *Client) GetProjectById(projectId int) (*Project, error) {
-
 	endpoint := fmt.Sprintf("projects/%d", projectId)
+
 	pageList, err := c.executeAPIMethod(endpoint)
 	if err != nil {
 		return nil, err
@@ -55,19 +55,18 @@ func (c *Client) GetProjectById(projectId int) (*Project, error) {
 	return result, nil
 }
 
-//
-//
+// @see https://gitlab.com/gitlab-org/gitlab-ce/blob/8-5-stable/doc/api/tags.md#list-project-repository-tags
+// @see https://docs.gitlab.com/ee/api/tags.html#list-project-repository-tags
 //
 func (c *Client) GetTagList(project *Project) ([]*Tag, error) {
-
 	endpoint := fmt.Sprintf("projects/%d/repository/tags", project.ID)
+
 	pageList, err := c.executeAPIMethod(endpoint)
 	if err != nil {
 		return nil, err
 	}
 
 	tagList := make([]*Tag, 0)
-
 	for _, body := range pageList {
 		page := make([]*Tag, 0)
 		if err := json.Unmarshal(body, &page); err != nil {
@@ -80,38 +79,35 @@ func (c *Client) GetTagList(project *Project) ([]*Tag, error) {
 	return tagList, nil
 }
 
-//
-//
+// @see https://gitlab.com/gitlab-org/gitlab-ce/blob/8-5-stable/doc/api/repositories.md#get-file-archive
+// @see https://docs.gitlab.com/ee/api/repositories.html#get-file-archive
 //
 func (c *Client) GetArchive(project *Project, ref string) ([]byte, error) {
-	// v4 uses sha as parameter name
-	// v3 uses ref as parameter name
-	refParam := "ref"
-	if c.HasV4Support {
-		refParam = "sha"
-	}
-
 	endpoint := fmt.Sprintf(
-		"projects/%d/repository/archive.tar.gz?%s=%s",
+		"projects/%d/repository/archive.tar.gz?sha=%s",
 		project.ID,
-		refParam,
 		url.QueryEscape(ref),
 	)
 
 	pageList, err := c.executeAPIMethod(endpoint)
 	if err != nil {
 		return nil, err
 	}
-
 	if len(pageList) == 0 {
 		return nil, errors.New("Archive operation failed")
 	}
 
 	return pageList[0], nil
 }
 
+// @see https://gitlab.com/gitlab-org/gitlab-ce/blob/8-5-stable/doc/api/repository_files.md#get-file-from-repository
+// for v3 file_path should be QueryString parameter.
 //
+// @see https://docs.gitlab.com/ee/api/repository_files.html#get-file-from-repository
+// for v4 file_path is not a parameter but part of URI. Should be encoded anyway.
+// update, right now this one doesn't seem's to work.
 //
+// KEEP EYE ON THIS METHOD, v4 right now doesn't work as expected.
 //
 func (c *Client) GetFile(project *Project, path, ref string) ([]byte, error) {