-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source id formatting as string #43
Comments
@bieryAtFnal Any insight? |
I think it followed from the earlier element and link IDs which were also always expressed in hex. I think this is a fairly easy change to make, though it may have some knock-on effects in the HDF5 file format (if they're processing Source ID strings). |
If we stop using hex, would the numeric values be zero-padded or simple numbers? I've only run a quick test so far, but some things "just work" with an unadorned decimal number. For example, I can run AND, we will certainly need to check with offline folks, before we change this. They may be using the hex digit for something, even though they don't need to ... |
We could add some padding with zeroes to regularise the size of the field. You're right about offline, although I hope they're not using it... |
The
SourceID::to_string
method formats the source id as a hex number.What's the rationale for that? The source id doesn't seem to have any substructure that the hex representation makes easier to visualise, nor the id is expressed as an ex elsewhere (e.g. in the hardware map).
The text was updated successfully, but these errors were encountered: