Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fire and dragonfire rendering is... weird? #152

Open
ab9rf opened this issue Jan 19, 2025 · 2 comments
Open

fire and dragonfire rendering is... weird? #152

ab9rf opened this issue Jan 19, 2025 · 2 comments

Comments

@ab9rf
Copy link
Member

ab9rf commented Jan 19, 2025

The code for rendering dragonfire and fire flows, currently render with the same sprite, which may not be desirable in v50, since, as of v50, dragonfire is canonically blue (rather than red), at least in the standard premium tile set.

It may therefore be desirable to split dragonfire and fire to use distinct tiles and provide a blue fire tile for dragonfire.

@dhthwy
Copy link

dhthwy commented Jan 19, 2025

I agree it would be desirable for the colors to align with canonical. edit to remove typo

@realSquidCoder
Copy link
Collaborator

https://github.com/DFHack/stonesense/blob/master/Tile.cpp#L644-L657

It would appear there used to be code to handle it, but it's commented out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants