Fix SonarCloud quality gate failures (#43)

* Fix SonarCloud quality gate failures

https://eaflood.atlassian.net/browse/NI-47

* Provide coverage for Lambda function schemas

Author: pwadmore-ea

lib/functions/getMessage.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const service = require('../helpers/service')
-const eventSchema = require('../helpers/schemas').getMessageEventSchema
+const eventSchema = require('../schemas/getMessageEventSchema')
 
 module.exports.getMessage = async (event) => {
   const response = {

lib/functions/processMessage.js

@@ -5,7 +5,7 @@ const moment = require('moment')
 const AWSConfig = require('../../config/config.json').aws
 const service = require('../helpers/service')
 const Message = require('../models/message')
-const eventSchema = require('../helpers/schemas.js').processMessageEventSchema
+const eventSchema = require('../schemas/processMessageEventSchema')
 
 module.exports.processMessage = async (event) => {
   const response = {

lib/helpers/schemas.js

@@ -0,0 +1,9 @@
+'use strict'
+
+const Joi = require('joi')
+
+module.exports = Joi.object({
+  pathParameters: Joi.object().required().keys({
+    id: Joi.string().hex().required()
+  })
+})

lib/schemas/getMessageEventSchema.js

@@ -0,0 +1,7 @@
+'use strict'
+
+const Joi = require('joi')
+
+module.exports = Joi.object({
+  bodyXml: Joi.string().required()
+})

lib/schemas/processMessageEventSchema.js

@@ -5,8 +5,8 @@ const Lab = require('@hapi/lab')
 const lab = exports.lab = Lab.script()
 const Code = require('@hapi/code')
 const configSchema = require('../config/schema')
-const schemas = require('../lib/helpers/schemas')
-const { getMessageEventSchema, processMessageEventSchema } = require('../lib/helpers/schemas')
+const getMessageEventSchema = require('../lib/schemas/getMessageEventSchema')
+const processMessageEventSchema = require('../lib/schemas/processMessageEventSchema')
 
 lab.experiment('schemas', () => {
   lab.test('configSchema', () => {
@@ -56,31 +56,28 @@ lab.experiment('schemas', () => {
 
     Code.expect(validationResult.error).to.not.be.null()
   })
-  lab.test('module exports the schemas correctly and validate their behavior', () => {
-    Code.expect(schemas).to.be.an.object()
-    Code.expect(schemas).to.include(['getMessageEventSchema', 'processMessageEventSchema'])
-
+  lab.test('modules export the schemas correctly and validate their behavior', () => {
     // Test valid data for getMessageEventSchema
     const validGetMessageData = { pathParameters: { id: 'a1b2c3d4' } }
-    const getMessageValidationResult = schemas.getMessageEventSchema.validate(validGetMessageData)
+    const getMessageValidationResult = getMessageEventSchema.validate(validGetMessageData)
     Code.expect(getMessageValidationResult.error).to.not.exist()
     Code.expect(getMessageValidationResult.value).to.equal(validGetMessageData)
 
     // Test invalid data for getMessageEventSchema
     const invalidGetMessageData = { pathParameters: { id: 'invalid' } }
-    const invalidGetMessageResult = schemas.getMessageEventSchema.validate(invalidGetMessageData)
+    const invalidGetMessageResult = getMessageEventSchema.validate(invalidGetMessageData)
     Code.expect(invalidGetMessageResult.error).to.not.be.null()
     Code.expect(invalidGetMessageResult.error.details[0].message).to.contain('must only contain hexadecimal characters')
 
     // Test valid data for processMessageEventSchema
     const validProcessMessageData = { bodyXml: '<xml />' }
-    const processMessageValidationResult = schemas.processMessageEventSchema.validate(validProcessMessageData)
+    const processMessageValidationResult = processMessageEventSchema.validate(validProcessMessageData)
     Code.expect(processMessageValidationResult.error).to.not.exist()
     Code.expect(processMessageValidationResult.value).to.equal(validProcessMessageData)
 
     // Test invalid data for processMessageEventSchema
     const invalidProcessMessageData = { bodyXml: 123 }
-    const invalidProcessMessageResult = schemas.processMessageEventSchema.validate(invalidProcessMessageData)
+    const invalidProcessMessageResult = processMessageEventSchema.validate(invalidProcessMessageData)
     Code.expect(invalidProcessMessageResult.error).to.not.be.null()
     Code.expect(invalidProcessMessageResult.error.details[0].message).to.contain('must be a string')
   })