Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: running simulated with calibrated model weirdness #6216

Closed
Tom-Szendrey opened this issue Jan 23, 2025 · 1 comment · Fixed by #6404
Closed

[Bug]: running simulated with calibrated model weirdness #6216

Tom-Szendrey opened this issue Jan 23, 2025 · 1 comment · Fixed by #6404
Assignees

Comments

@Tom-Szendrey
Copy link
Contributor

Tom-Szendrey commented Jan 23, 2025

https://app.staging.terarium.ai/projects/dd6fbf86-bfee-4cee-8403-8a01687b220b/workflow/62a32a3f-4dd2-466c-856b-3b1f298ac6d3

Observations:

  1. This will fail when ran with normal settings
  2. When run with fast settings this passes but the charts are empty
@Tom-Szendrey Tom-Szendrey self-assigned this Jan 23, 2025
@Tom-Szendrey Tom-Szendrey changed the title running simulated with calibrated model weirdness [Bug]: running simulated with calibrated model weirdness Jan 23, 2025
@Tom-Szendrey
Copy link
Contributor Author

Issue:

We are not receiving a correct model configuration from /model-configuraiton/as-configured-model/{id} when we provide a calibrated model configuration.

Explanation:

When we hit save as within the drilldown we will create a new model configuration. This model configuration's parameters will not have parameterSemanticList but instead will contain a inferredParameterList
Within the inferredParameterList we do not have a value field just a mean field.
When we get as configured model we will not have a value to fill in for semantics.ode.parameters we will then default this value to 1.
As we are overwriting this value with inferred parameters this should not matter. Except when this parameter is a constant it will not be inferred and overwritten.

Examples

this config is broken.json
This config is not brokn.json

broken - as configured model.json
Working - as configured model.json

@Tom-Szendrey Tom-Szendrey linked a pull request Feb 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant