Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The "Transitions" table in the model page are missing the rate laws and have other issues #5919

Closed
3 tasks done
liunelson opened this issue Dec 20, 2024 · 0 comments · Fixed by #5951
Closed
3 tasks done
Assignees
Labels
bug Something isn't working

Comments

@liunelson
Copy link
Member

liunelson commented Dec 20, 2024

Describe the bug

Issues:

  • the Transitions table in the model page used to show the rate law that is associated with each transition/template. These rate laws are now missing. They should be shown in a code font (since the rate laws are SymPy expressions).
  • I have no idea what the purpose of the template-, template- on each row. What should shown as the first, bolded entry of each row should be just the model.transitions[].id of each transition/template in the model AMR object. The editable text field should be model.transitions[].properties.name.
  • Model transitions/Templates have no 'unit' property in general and the 'Unit' field should be removed from the table.

Screenshots
Image

@liunelson liunelson added the bug Something isn't working label Dec 20, 2024
@blanchco blanchco linked a pull request Jan 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants