Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Simulate charts are broken when the simulation result is empty or in bad state. #5164

Open
liunelson opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@liunelson
Copy link
Member

Describe the bug

Holly and I encountered this issue with `Simulate``.

When we ran this model & its configuration, the line charts are broken.

This seems to occur when the configuration is problematic (initial expressions are set to integers instead of floats) and causes Simulate to return some unexpected result (empty dataframe?).

Image
Image

To Reproduce
Steps to reproduce the behavior:

  1. Go to this workflow https://app.staging.terarium.ai/projects/eb16a7a8-17f1-4295-a938-146969f8f1a1/workflow/b9be7f12-0b70-469c-a66f-3030f8e3aa2d
  2. Go to this Simulate operator https://app.staging.terarium.ai/projects/eb16a7a8-17f1-4295-a938-146969f8f1a1/workflow/b9be7f12-0b70-469c-a66f-3030f8e3aa2d?operator=2ba8e5d4-f191-4771-a1ba-3c6a170e061d
  3. Run this with the Euler solver option
  4. See broken line chart

Expected behavior
It's unclear what pyciemss-service.simulate returned but the chart should not break like this.

@liunelson liunelson added the bug Something isn't working label Oct 16, 2024
@YohannParis
Copy link
Member

@liunelson isn't this issue related to that integer/float bug with PyCIEMSS?
ciemss/pyciemss#618

@YohannParis YohannParis assigned liunelson and unassigned YohannParis Oct 16, 2024
@liunelson
Copy link
Member Author

@YohannParis This can be reproduced that way (by using integers as initial condition expressions). However, no error was raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants