Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook re-run notifications #4754

Open
jamiewaese-uncharted opened this issue Sep 11, 2024 · 1 comment · May be fixed by #5162
Open

Notebook re-run notifications #4754

jamiewaese-uncharted opened this issue Sep 11, 2024 · 1 comment · May be fixed by #5162
Assignees
Labels
feature New feature or request

Comments

@jamiewaese-uncharted
Copy link
Contributor

jamiewaese-uncharted commented Sep 11, 2024

Issue 1: Add 'Re-run all cells' button and notification

CURRENT
When you open a previously generated Transform dataset operator, it loads the input and output text of the previous run, and it indicates that the kernel is "Ready", but none of the transformations are actually available to use.

Image

PROPOSED
There should be an indicator to tell users that the cells need to be re-run if they want to make any changes or use anything the operator generated downstream.

There should also be a "Re-run all cells" button on the toolbar.

It would be nice if you can make the page look more like this:
Image

@brittanykondo brittanykondo changed the title [Design] notebook re-run notifications Notebook re-run notifications Sep 11, 2024
@brittanykondo brittanykondo added the feature New feature or request label Sep 11, 2024
@dgauldie
Copy link
Collaborator

The "Save for reuse" button should be disabled when the yellow banner is there. This adds a guardrail to prevent saving dataframes as datasets when the session is not active.

@dgauldie dgauldie assigned mloppie and unassigned shawnyama Sep 20, 2024
@mloppie mloppie linked a pull request Oct 16, 2024 that will close this issue
@mloppie mloppie linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants