From 1ef416eddd5edddc99a053dedc7bd7addb20a930 Mon Sep 17 00:00:00 2001
From: Yohann Paris <github@yohannparis.com>
Date: Mon, 13 May 2024 09:44:12 -0400
Subject: [PATCH] Organise workflows (#3602)

---
 .github/workflows/commitlint.yaml      | 37 --------------------------
 .github/workflows/lint-server.yaml     |  8 ------
 .github/workflows/test-server.yaml     |  5 ++++
 .github/workflows/test-taskrunner.yaml |  5 ++++
 4 files changed, 10 insertions(+), 45 deletions(-)
 delete mode 100644 .github/workflows/commitlint.yaml

diff --git a/.github/workflows/commitlint.yaml b/.github/workflows/commitlint.yaml
deleted file mode 100644
index 58b3e41e5b..0000000000
--- a/.github/workflows/commitlint.yaml
+++ /dev/null
@@ -1,37 +0,0 @@
----
-# This action makes PRs require conventional commits in both
-#   the pull request title, and commit message.
-#
-#   See: https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional
-
-name: Lint PR Commit Messages
-# yamllint disable-line rule:truthy
-on:
-  pull_request:
-    types: ['opened', 'edited', 'reopened', 'synchronize']
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
-
-jobs:
-  commitlint:
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v3
-      # Uncomment this if you want to validate all commits in this PR not just the PR comment
-      # with:
-      #   fetch-depth: 0
-      - name: Use Node.js 20.10.0 LTS
-        uses: actions/setup-node@v3
-        with:
-          node-version: 20.10.0
-          cache: 'yarn'
-      - name: Install CommitLint Dependency
-        run: yarn add @commitlint/config-conventional
-      # Uncomment this if you want to validate all commits in this PR not just the PR comment
-      # - uses: wagoid/commitlint-github-action@v5
-      - name: Lint the PR message
-        uses: JulienKode/pull-request-name-linter-action@v0.5.0
-        with:
-          configuration-path: ./.commitlintrc.yaml
diff --git a/.github/workflows/lint-server.yaml b/.github/workflows/lint-server.yaml
index bad6f100de..2c074e66d7 100644
--- a/.github/workflows/lint-server.yaml
+++ b/.github/workflows/lint-server.yaml
@@ -4,14 +4,6 @@ name: Lint Server
 # yamllint disable-line rule:truthy
 on:
   workflow_call:
-  push:
-    paths:
-      - 'packages/server/**'
-    branches: [ 'main' ]
-  pull_request:
-    paths:
-      - 'packages/server/**'
-    branches: [ 'main' ]
 
 jobs:
   lintServer:
diff --git a/.github/workflows/test-server.yaml b/.github/workflows/test-server.yaml
index d9643dfe9c..45e1840508 100644
--- a/.github/workflows/test-server.yaml
+++ b/.github/workflows/test-server.yaml
@@ -23,9 +23,14 @@ on:
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
+  lint-server:
+    name: Lint and format server
+    uses: ./.github/workflows/lint-server.yml
+
   server-tests:
     # The type of runner that the job will run on
     runs-on: ubuntu-22.04
+    needs: lint-server
 
     permissions:
       contents: read
diff --git a/.github/workflows/test-taskrunner.yaml b/.github/workflows/test-taskrunner.yaml
index 8d75fb948f..5416a8f6dc 100644
--- a/.github/workflows/test-taskrunner.yaml
+++ b/.github/workflows/test-taskrunner.yaml
@@ -22,9 +22,14 @@ on:
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
+  lint-server:
+    name: Lint and format server
+    uses: ./.github/workflows/lint-server.yml
+
   taskrunner-tests:
     # The type of runner that the job will run on
     runs-on: ubuntu-22.04
+    needs: lint-server
 
     permissions:
       contents: read