Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensembles as parametric types of Simulate/Calibrate #152

Closed
jClugstor opened this issue Dec 8, 2023 · 2 comments
Closed

Ensembles as parametric types of Simulate/Calibrate #152

jClugstor opened this issue Dec 8, 2023 · 2 comments

Comments

@jClugstor
Copy link
Collaborator

Right now the Ensemble structs are parametric, and hold a list of operations that are either simulate/calibrate objects. Knowing more about ensembles lately, I think this is not very useful, and ends up making the solving functions for the ensembles more complicated than they need to be. Especially ensemble calibrate, which really isn't a bunch of ensemble operations, it's more of it's own thing.

I propose making two different structs, EnsembleSimulate, and EnsembleCalibrate.
@joshday
Copy link
Collaborator

joshday commented Dec 8, 2023

Sounds good to me!

@jClugstor
Copy link
Collaborator Author

fixed by #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshday @jClugstor