Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that calibrate respects solution mappings #143

Closed
jClugstor opened this issue Dec 1, 2023 · 1 comment · Fixed by #144
Closed

Ensure that calibrate respects solution mappings #143

jClugstor opened this issue Dec 1, 2023 · 1 comment · Fixed by #144
Assignees
@jClugstor

Comments

@jClugstor
Copy link
Collaborator

Right now it seems that the calibrate endpoint does not respect the solution_mappings part of the data request. This means that if any of the columns of the state data have different labels than the states in the equations, the calibration has no way of knowing which column matches to which state. Also true for timestamp.
@jClugstor jClugstor self-assigned this Dec 1, 2023
@jClugstor
Copy link
Collaborator Author

Scratch that for the state data, that all gets taken care of. All that needs to change is the timestamp.

@jClugstor jClugstor changed the title Ensure that calibrate and calibrate-ensemble respect solution mappings Ensure that calibrate respects solution mappings Dec 1, 2023
@jClugstor jClugstor mentioned this issue Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jClugstor jClugstor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use the mappings tstep as timestamp jClugstor/simulation-service
1 participant
@jClugstor