Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minior updates to calibrate, simulate #108

Closed
wants to merge 7 commits into from
Closed

Minior updates to calibrate, simulate #108

wants to merge 7 commits into from

Conversation

Tom-Szendrey
Copy link
Contributor

Description

Throw learning rate into the main body rather than extra.
Moving solver method and solver_options too

@Tom-Szendrey Tom-Szendrey requested a review from dvince2 July 29, 2024 15:24
# autoguide: pyro.infer.autoguide.AutoLowRankMultivariateNormal
solver_method: str = Field(
"dopri5", description="Optional field for CIEMSS calibration", example="dopri5"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we making these changes? Have we consider the impact and the types of corresponding changes we need to make?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are a result of the changes requested here: DARPA-ASKEM/terarium#4201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyciemss-service update for https://github.com/DARPA-ASKEM/terarium/pull/4293
3 participants