Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for duplication elements during collection insertion #2117

Open
lifflander opened this issue Mar 27, 2023 · 2 comments · May be fixed by #2118
Open

Check for duplication elements during collection insertion #2117

lifflander opened this issue Mar 27, 2023 · 2 comments · May be fixed by #2118
Assignees
@lifflander @cz4rs
Labels
type: task

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

Add a layer of debugging for this case
@lifflander lifflander self-assigned this Mar 27, 2023
lifflander added a commit that referenced this issue Mar 27, 2023
@lifflander
#2117: location: add new assertions to detect duplicate insertions
b5db4aa
@lifflander lifflander linked a pull request Mar 27, 2023 that will close this issue
Draft
@lifflander lifflander linked a pull request Mar 27, 2023 that will close this issue
#2117: location: add new assertions to detect duplicate insertions #2118
Draft
lifflander added a commit that referenced this issue Mar 27, 2023
@lifflander
#2117: location: add new assertions to detect duplicate insertions
99fb383
lifflander added a commit that referenced this issue Mar 28, 2023
@lifflander
#2117: location: loosen assertion
cc3ab0a
@PhilMiller
Copy link
Member

I remember discussing a good protocol for detecting exactly these issues. Maybe check the issue or PR in which we introduced this kind of insertion.

@PhilMiller
Copy link
Member

Ok, here's the discussion I was thinking of: #820 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifflander lifflander

@cz4rs cz4rs

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2117: location: add new assertions to detect duplicate insertions DARMA-tasking/vt
3 participants
@PhilMiller @lifflander @cz4rs